Skip to contentSkip to conversation

soc: ti: k3-socinfo: fix regmap leak on probe failure

PATCH In review Johan Hovold 3 participants 4 messages Nov 27, 2025 – Jan 14

Subsystems (2)
Stable branch TI Keystone multicore navigator drivers
lore
Share & tools
lore

Johan Hovold

author
#0 lore raw

PATCH 1/1 soc: ti: k3-socinfo: fix regmap leak on probe failure

The mmio regmap allocated during probe is never freed.

Switch to using the device managed allocator so that the regmap is released on probe failures (e.g. probe deferral) and on driver unbind.

Fixes a5caf03188e4 ("soc: ti: k3-socinfo: Do not use syscon helper to build regmap")
Cc [email protected] # 6.15
Cc Andrew Davis <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
---
 drivers/soc/ti/k3-socinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/ti/k3-socinfo.c +1 -1
index 50c170a995f9..42275cb5ba1c 100644
@@ -141,7 +141,7 @@ static int k3_chipinfo_probe(struct platform_device *pdev)
 	if (IS_ERR(base))
 		return PTR_ERR(base);
 
-	regmap = regmap_init_mmio(dev, base, &k3_chipinfo_regmap_cfg);
+	regmap = devm_regmap_init_mmio(dev, base, &k3_chipinfo_regmap_cfg);
 	if (IS_ERR(regmap))
 		return PTR_ERR(regmap);
Signature · 1 line
2.51.2
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Johan Hovold

The mmio regmap allocated during probe is never freed.

Switch to using the device managed allocator so that the regmap is released on probe failures (e.g. probe deferral) and on driver unbind.

Fixes a5caf03188e4 ("soc: ti: k3-socinfo: Do not use syscon helper to build regmap")
Cc [email protected] # 6.15
Cc Andrew Davis <[email protected]>
Signed-off-by Johan Hovold <[email protected]>

---

Acked-by Andrew Davis <[email protected]>
Quoted 16 lines
  drivers/soc/ti/k3-socinfo.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/ti/k3-socinfo.c +1 -1
index 50c170a995f9..42275cb5ba1c 100644
@@ -141,7 +141,7 @@ static int k3_chipinfo_probe(struct platform_device *pdev)
  	if (IS_ERR(base))
  		return PTR_ERR(base);
 
-	regmap = regmap_init_mmio(dev, base, &k3_chipinfo_regmap_cfg);
+	regmap = devm_regmap_init_mmio(dev, base, &k3_chipinfo_regmap_cfg);
  	if (IS_ERR(regmap))
  		return PTR_ERR(regmap);
author
#2 lore raw
In reply to Johan Hovold
Quoted 9 lines · Johan Hovold

The mmio regmap allocated during probe is never freed.

Switch to using the device managed allocator so that the regmap is released on probe failures (e.g. probe deferral) and on driver unbind.

Fixes a5caf03188e4 ("soc: ti: k3-socinfo: Do not use syscon helper to build regmap")
Cc [email protected] # 6.15
Cc Andrew Davis <[email protected]>
Signed-off-by Johan Hovold <[email protected]>

Can this one be picked up now?

Johan

maintainer
#3 lore raw
In reply to Johan Hovold

Hi Johan Hovold,

Quoted 6 lines · Johan Hovold

The mmio regmap allocated during probe is never freed.

Switch to using the device managed allocator so that the regmap is released on probe failures (e.g. probe deferral) and on driver unbind.

I have applied the following to branch ti-drivers-soc-next on [1]. Apologies on missing this in my filter and thanks for following up. Thank you!

[1/1] soc: ti: k3-socinfo: fix regmap leak on probe failure

      commit: c933138d45176780fabbbe7da263e04d5b3e525d

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git

Signature · 4 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource