usb: linux/usb.h: Correct the description of the usb_device_driver member
PATCH 1/1 usb: linux/usb.h: Correct the description of the usb_device_driver member
From: Yi Cong <[email protected]>
In the current kernel USB device driver code, only the name field is required to be provided; all other fields are optional. Use the command grep -rnw "struct usb_device_driver" to inspect how specific drivers are declared.
Correct this part of the description.
--- include/linux/usb.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
include/linux/usb.h +1 -2
@@ -1295,8 +1295,7 @@ struct usb_driver {* resume and suspend functions will be called in addition to the driver's * own, so this part of the setup does not need to be replicated. * -* USB drivers must provide all the fields listed above except driver, -* match, and id_table. +* USB device drivers must provide a name, other driver fields are optional. */ struct usb_device_driver {const char *name;
Signature · 1 line
2.25.1
Quoted 6 lines · Yi Cong
From: Yi Cong <[email protected]>
In the current kernel USB device driver code, only the name field is required to be provided; all other fields are optional. Use the command grep -rnw "struct
usb_device_driver" to inspect how specific drivers are declared.
That last sentence should not be part of the patch description; it doesn't explain the patch's purpose or what the patch does. (It's not even correct, because the grep output doesn't show how the specific drivers are declared. It mainly shows the filenames and line numbers where the declarations start.)
Aside from that,
Alan Stern
Quoted 25 lines
Correct this part of the description.
Signed-off-by Yi Cong <[email protected]>--- include/linux/usb.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)include/linux/usb.h +1
-2@@ -1295,8 +1295,7 @@ struct usb_driver {* resume and suspend functions will be called in addition to the driver's * own, so this part of the setup does not need to be replicated. * -* USB drivers must provide all the fields listed above except driver, -* match, and id_table. +* USB device drivers must provide a name, other driver fields are optional. */ struct usb_device_driver {const char *name;Signature · 1 line
2.25.1
Quoted 9 lines · Alan Stern
Quoted 6 lines · Yi Cong
From: Yi Cong <[email protected]>
In the current kernel USB device driver code, only the name field is required to be provided; all other fields are optional. Use the command grep -rnw "struct
usb_device_driver" to inspect how specific drivers are declared.
Quoted 6 lines
That last sentence should not be part of the patch description; it doesn't explain the patch's purpose or what the patch does. (It's not even correct, because the grep output doesn't show how the specific drivers are declared. It mainly shows the filenames and line numbers where the declarations start.)
Thank you for the reply!
Do I need to update the commit message and send a new version of the patch?
Regards,
Yi Cong
Greg KH
maintainerQuoted 17 lines · Yi Cong
Quoted 9 lines · Alan Stern
Quoted 6 lines · Yi Cong
From: Yi Cong <[email protected]>
In the current kernel USB device driver code, only the name field is required to be provided; all other fields are optional. Use the command grep -rnw "struct
usb_device_driver" to inspect how specific drivers are declared.Quoted 6 lines
That last sentence should not be part of the patch description; it doesn't explain the patch's purpose or what the patch does. (It's not even correct, because the grep output doesn't show how the specific drivers are declared. It mainly shows the filenames and line numbers where the declarations start.)
Quoted 2 lines
Thank you for the reply!
Do I need to update the commit message and send a new version of the patch?
Yes please.