Skip to contentSkip to conversation

thermal: sprd: Use min instead of clamp in sprd_thm_temp_to_rawdata

PATCH Superseded Thorsten Blum 2 participants 2 messages Dec 2, 2025 – Dec 3, 2025

Subsystems (2)
Thermal Arm/spreadtrum SoC support
lore
Share & tools
lore

Thorsten Blum

author
#0 lore raw

PATCH 1/1 thermal: sprd: Use min instead of clamp in sprd_thm_temp_to_rawdata

Clamping 'val' to itself is unnecessary and the expression can be simplified by using min() instead. Casting SPRD_THM_RAW_DATA_HIGH to u32 is also redundant and can be removed.

Signed-off-by Thorsten Blum <[email protected]>
---
 drivers/thermal/sprd_thermal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/sprd_thermal.c +1 -1
index 44fa45f74da7..d683fcb0f8ab 100644
@@ -201,7 +201,7 @@ static int sprd_thm_temp_to_rawdata(int temp, struct sprd_thermal_sensor *sen)
 	 */
 	val = (temp + sen->cal_offset) / sen->cal_slope;
 
-	return clamp(val, val, (u32)(SPRD_THM_RAW_DATA_HIGH - 1));
+	return min(val, SPRD_THM_RAW_DATA_HIGH - 1);
 }
 
 static int sprd_thm_read_temp(struct thermal_zone_device *tz, int *temp)
Signature · 2 lines
Thorsten Blum <[email protected]>
GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Thorsten Blum

Clamping 'val' to itself is unnecessary and the expression can be simplified by using min() instead. Casting SPRD_THM_RAW_DATA_HIGH to u32 is also redundant and can be removed.

Signed-off-by Thorsten Blum <[email protected]>
---
  drivers/thermal/sprd_thermal.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/sprd_thermal.c +0 -0
index 44fa45f74da7..d683fcb0f8ab 100644

drivers/thermal/sprd_thermal.c static int sprd_thm_temp_to_rawdata(int temp, struct sprd_thermal_sensor *sen) · line 207

Quoted 8 lines
drivers/thermal/sprd_thermal.c +1 -1
@@ -201,7 +201,7 @@ static int sprd_thm_temp_to_rawdata(int temp, struct sprd_thermal_sensor *sen)
  	 */
  	val = (temp + sen->cal_offset) / sen->cal_slope;
 
-	return clamp(val, val, (u32)(SPRD_THM_RAW_DATA_HIGH - 1));
+	return min(val, SPRD_THM_RAW_DATA_HIGH - 1);
  }
 
  static int sprd_thm_read_temp(struct thermal_zone_device *tz, int *temp)

LGTM. Thanks.

Reviewed-by Baolin Wang <[email protected]>