Skip to contentSkip to conversation

ALSA: hda/realtek: Add codec IDs to HP ProBook G8 fixups

PATCH In review Ilyas Gasanov 2 participants 6 messages Dec 2, 2025 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda/realtek: Add codec IDs to HP ProBook G8 fixups

According to amixer output, as well as the result value of the GET_SUBSYSTEM_ID HDA verb, the codec's own subsystem ID may differ from that of the HDA controller.

The snd_hda_pick_fixup() function specifically inspects just the codec's subsystem ID, ignoring that of the controller, which causes mismatch on machines where the above is the case, unless the codec's subsystem ID is also covered.

For reference:

- https://linux-hardware.org/?probe=9829e4ea09&log=amixer
(HP ProBook 440 G8, MB 8A74, codec 10ec0236,103c8a7a)
- https://linux-hardware.org/?probe=5b2ca9b826&log=amixer
(HP ProBook 450 G8, MB 8A75, codec 10ec0236,103c8a7b)
- https://linux-hardware.org/?probe=228aee06a5&log=amixer
(HP ProBook 440 G8, MB 8A76, codec 10ec0236,103c8a7c)
- https://linux-hardware.org/?probe=1cd4bf968d&log=amixer
(HP ProBook 450 G8, MB 8A77, codec 10ec0236,103c8a7d)

---
 sound/hda/codecs/realtek/alc269.c | 4 ++++
 1 file changed, 4 insertions(+)
sound/hda/codecs/realtek/alc269.c +4 -0
index 4efc16ae6b5d..d34a196158aa 100644
@@ -6599,6 +6599,10 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a75, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
+	SND_PCI_QUIRK(0x103c, 0x8a7a, "HP ProBook 440 G8 (MB 8A74)", ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8a7b, "HP ProBook 450 G8 (MB 8A75)", ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8a7c, "HP ProBook 440 G8 (MB 8A76)", ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8a7d, "HP ProBook 450 G8 (MB 8A77)", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8aa8, "HP EliteBook 640 G9 (MB 8AA6)", ALC236_FIXUP_HP_GPIO_LED),
Signature · 1 line
2.51.0
#1 lore raw
Quoted 21 lines · Ilyas Gasanov

According to amixer output, as well as the result value of the GET_SUBSYSTEM_ID HDA verb, the codec's own subsystem ID may differ from that of the HDA controller.

The snd_hda_pick_fixup() function specifically inspects just the codec's subsystem ID, ignoring that of the controller, which causes mismatch on machines where the above is the case, unless the codec's subsystem ID is also covered.

For reference:

- https://linux-hardware.org/?probe=9829e4ea09&log=amixer
(HP ProBook 440 G8, MB 8A74, codec 10ec0236,103c8a7a)
- https://linux-hardware.org/?probe=5b2ca9b826&log=amixer
(HP ProBook 450 G8, MB 8A75, codec 10ec0236,103c8a7b)
- https://linux-hardware.org/?probe=228aee06a5&log=amixer
(HP ProBook 440 G8, MB 8A76, codec 10ec0236,103c8a7c)
- https://linux-hardware.org/?probe=1cd4bf968d&log=amixer
(HP ProBook 450 G8, MB 8A77, codec 10ec0236,103c8a7d)

Quoted 1 line

The primary matching is with PCI SSID, not the codec SSID. Do they have the same numbers on those machines?

thanks,

Takashi

Quoted 22 lines
---
 sound/hda/codecs/realtek/alc269.c | 4 ++++
 1 file changed, 4 insertions(+)
sound/hda/codecs/realtek/alc269.c +4 -0
index 4efc16ae6b5d..d34a196158aa 100644
@@ -6599,6 +6599,10 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a75, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
+	SND_PCI_QUIRK(0x103c, 0x8a7a, "HP ProBook 440 G8 (MB 8A74)", ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8a7b, "HP ProBook 450 G8 (MB 8A75)", ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8a7c, "HP ProBook 440 G8 (MB 8A76)", ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8a7d, "HP ProBook 450 G8 (MB 8A77)", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8aa8, "HP EliteBook 640 G9 (MB 8AA6)", ALC236_FIXUP_HP_GPIO_LED),
Signature · 1 line
2.51.0
#2 lore raw
Quoted 24 lines · Takashi Iwai
Quoted 21 lines · Ilyas Gasanov

According to amixer output, as well as the result value of the GET_SUBSYSTEM_ID HDA verb, the codec's own subsystem ID may differ from that of the HDA controller.

The snd_hda_pick_fixup() function specifically inspects just the codec's subsystem ID, ignoring that of the controller, which causes mismatch on machines where the above is the case, unless the codec's subsystem ID is also covered.

For reference:

- https://linux-hardware.org/?probe=9829e4ea09&log=amixer
(HP ProBook 440 G8, MB 8A74, codec 10ec0236,103c8a7a)
- https://linux-hardware.org/?probe=5b2ca9b826&log=amixer
(HP ProBook 450 G8, MB 8A75, codec 10ec0236,103c8a7b)
- https://linux-hardware.org/?probe=228aee06a5&log=amixer
(HP ProBook 440 G8, MB 8A76, codec 10ec0236,103c8a7c)
- https://linux-hardware.org/?probe=1cd4bf968d&log=amixer
(HP ProBook 450 G8, MB 8A77, codec 10ec0236,103c8a7d)

Quoted 3 lines
Quoted 1 line

The primary matching is with PCI SSID, not the codec SSID.

Good point. There is indeed a semantic difference between the SND_PCI_QUIRK() and HDA_CODEC_QUIRK() macros, specifically where the value of the .match_codec_ssid field is concerned.

Quoted 1 line

Do they have the same numbers on those machines?

From what it looks like:

- https://linux-hardware.org/?probe=9829e4ea09&log=lspci
Device: 00:1f.3
Class: Multimedia audio controller [0401]
SVendor: Hewlett-Packard Company [103c]
SDevice: ... [8a74]
(already covered)

- https://linux-hardware.org/?probe=5b2ca9b826&log=lspci
Device: 00:1f.3
Class: Multimedia audio controller [0401]
SVendor: Hewlett-Packard Company [103c]
SDevice: ... [8a75]
(already covered)

- https://linux-hardware.org/?probe=228aee06a5&log=lspci
Device: 00:1f.3
Class: Multimedia audio controller [0401]
SVendor: Hewlett-Packard Company [103c]
SDevice: ... [8a76]
(not covered yet)

- https://linux-hardware.org/?probe=1cd4bf968d&log=lspci
Device: 00:1f.3
Class: Multimedia audio controller [0401]
SVendor: Hewlett-Packard Company [103c]
SDevice: ... [8a77]
(not covered yet)

In short, PCI SSIDs 0x8a74 and 0x8a75 are already covered within alc269_fixup_tbl, but not 0x8a76 nor 0x8a77.

Quoted 28 lines

thanks,

Takashi

Quoted 22 lines
---
 sound/hda/codecs/realtek/alc269.c | 4 ++++
 1 file changed, 4 insertions(+)
sound/hda/codecs/realtek/alc269.c +4 -0
index 4efc16ae6b5d..d34a196158aa 100644
@@ -6599,6 +6599,10 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a75, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
+	SND_PCI_QUIRK(0x103c, 0x8a7a, "HP ProBook 440 G8 (MB 8A74)", ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8a7b, "HP ProBook 450 G8 (MB 8A75)", ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8a7c, "HP ProBook 440 G8 (MB 8A76)", ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8a7d, "HP ProBook 450 G8 (MB 8A77)", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8aa8, "HP EliteBook 640 G9 (MB 8AA6)", ALC236_FIXUP_HP_GPIO_LED),
Signature · 1 line
2.51.0
#3 lore raw
Quoted 58 lines · Ilyas Gasanov
Quoted 24 lines · Takashi Iwai
Quoted 21 lines · Ilyas Gasanov

According to amixer output, as well as the result value of the GET_SUBSYSTEM_ID HDA verb, the codec's own subsystem ID may differ from that of the HDA controller.

The snd_hda_pick_fixup() function specifically inspects just the codec's subsystem ID, ignoring that of the controller, which causes mismatch on machines where the above is the case, unless the codec's subsystem ID is also covered.

For reference:

- https://linux-hardware.org/?probe=9829e4ea09&log=amixer
(HP ProBook 440 G8, MB 8A74, codec 10ec0236,103c8a7a)
- https://linux-hardware.org/?probe=5b2ca9b826&log=amixer
(HP ProBook 450 G8, MB 8A75, codec 10ec0236,103c8a7b)
- https://linux-hardware.org/?probe=228aee06a5&log=amixer
(HP ProBook 440 G8, MB 8A76, codec 10ec0236,103c8a7c)
- https://linux-hardware.org/?probe=1cd4bf968d&log=amixer
(HP ProBook 450 G8, MB 8A77, codec 10ec0236,103c8a7d)

Quoted 3 lines
Quoted 1 line

The primary matching is with PCI SSID, not the codec SSID.

Good point. There is indeed a semantic difference between the SND_PCI_QUIRK() and HDA_CODEC_QUIRK() macros, specifically where the value of the .match_codec_ssid field is concerned.

Quoted 1 line

Do they have the same numbers on those machines?

From what it looks like:

- https://linux-hardware.org/?probe=9829e4ea09&log=lspci
Device: 00:1f.3
Class: Multimedia audio controller [0401]
SVendor: Hewlett-Packard Company [103c]
SDevice: ... [8a74]
(already covered)

- https://linux-hardware.org/?probe=5b2ca9b826&log=lspci
Device: 00:1f.3
Class: Multimedia audio controller [0401]
SVendor: Hewlett-Packard Company [103c]
SDevice: ... [8a75]
(already covered)

- https://linux-hardware.org/?probe=228aee06a5&log=lspci
Device: 00:1f.3
Class: Multimedia audio controller [0401]
SVendor: Hewlett-Packard Company [103c]
SDevice: ... [8a76]
(not covered yet)

Quoted 8 lines

- https://linux-hardware.org/?probe=1cd4bf968d&log=lspci
Device: 00:1f.3
Class: Multimedia audio controller [0401]
SVendor: Hewlett-Packard Company [103c]
SDevice: ... [8a77]
(not covered yet)

In short, PCI SSIDs 0x8a74 and 0x8a75 are already covered within alc269_fixup_tbl, but not 0x8a76 nor 0x8a77.

OK, could you resubmit the fix just for those missing two?

thanks,

Takashi

#4 lore raw

PATCH v2 1/1 ALSA: hda/realtek: Add PCI SSIDs to HP ProBook quirks

In reply to Ilyas Gasanov

According to HW probes, there exist upgraded variants of HP ProBook 440/450 G8 notebook PC hardware, with PCI SSIDs not yet covered:

- https://linux-hardware.org/?id=pci:8086-a0c8-103c-8a76
(HP ProBook 440 G8, SSID 103C:8A76, Tiger Lake HDA, ALC236)
- https://linux-hardware.org/?id=pci:8086-a0c8-103c-8a77
(HP ProBook 450 G8, SSID 103C:8A77, Tiger Lake HDA, ALC236)

The HDA GPIO indices for the mic mute (0x1) and speaker mute (0x2) LEDs are virtually guaranteed to be identical for the HP ProBook 440/450 G8 variants with motherboard SSIDs 8A74/8A75 (BIOS T87) and 8A76/8A77 (BIOS T88); especially since spare keyboard parts are interchangeable between different revisions of the same notebook models, and thus necessarily have the same slot pinouts.

---
 sound/hda/codecs/realtek/alc269.c | 2 ++
 1 file changed, 2 insertions(+)
sound/hda/codecs/realtek/alc269.c +2 -0
index 4efc16ae6b5d..d90a6c01f63b 100644
@@ -6598,6 +6598,8 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8a6e, "HP EDNA 360", ALC287_FIXUP_CS35L41_I2C_4),
 	SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a75, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8a76, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8a77, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
 	SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED),
Signature · 1 line
2.51.0
Applied
#5 lore raw

Re: [PATCH v2] ALSA: hda/realtek: Add PCI SSIDs to HP ProBook quirks

Quoted 9 lines · Ilyas Gasanov

According to HW probes, there exist upgraded variants of HP ProBook 440/450 G8 notebook PC hardware, with PCI SSIDs not yet covered:

- https://linux-hardware.org/?id=pci:8086-a0c8-103c-8a76
(HP ProBook 440 G8, SSID 103C:8A76, Tiger Lake HDA, ALC236)
- https://linux-hardware.org/?id=pci:8086-a0c8-103c-8a77
(HP ProBook 450 G8, SSID 103C:8A77, Tiger Lake HDA, ALC236)

Quoted 8 lines

The HDA GPIO indices for the mic mute (0x1) and speaker mute (0x2) LEDs are virtually guaranteed to be identical for the HP ProBook 440/450 G8 variants with motherboard SSIDs 8A74/8A75 (BIOS T87) and 8A76/8A77 (BIOS T88); especially since spare keyboard parts are interchangeable between different revisions of the same notebook models, and thus necessarily have the same slot pinouts.

Thanks, applied now.

Takashi