Skip to contentSkip to conversation

nvmet: lift blocksize restriction to 64k

PATCH Superseded Hannes Reinecke 3 participants 3 messages Dec 3, 2025 – Dec 12, 2025

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvmet: lift blocksize restriction to 64k

With commit 47dd67532303 ("block/bdev: lift block size restrictions to 64k") we can now support up to 64k block sizes, so lift the restriction on 4k for file-backed namespaces.

Fixes 47dd67532303 ("block/bdev: lift block size restrictions to 64k")
---
 drivers/nvme/target/io-cmd-file.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/nvme/target/io-cmd-file.c +2 -3
index 2d068439b129..1ef4f262594a 100644
@@ -50,11 +50,10 @@ int nvmet_file_ns_enable(struct nvmet_ns *ns)
 	nvmet_file_ns_revalidate(ns);
 
 	/*
-	 * i_blkbits can be greater than the universally accepted upper bound,
-	 * so make sure we export a sane namespace lba_shift.
+	 * We can support blocksizes up to 64k (= 16 bits).
 	 */
 	ns->blksize_shift = min_t(u8,
-			file_inode(ns->file)->i_blkbits, 12);
+			file_inode(ns->file)->i_blkbits, 16);
 
 	ns->bvec_pool = mempool_create(NVMET_MIN_MPOOL_OBJ, mempool_alloc_slab,
 			mempool_free_slab, nvmet_bvec_cache);
Signature · 1 line
2.43.0
#1 lore raw

drivers/nvme/target/io-cmd-file.c int nvmet_file_ns_enable(struct nvmet_ns *ns) · line 56

Quoted 2 lines · Hannes Reinecke
drivers/nvme/target/io-cmd-file.c +1 -1
-			file_inode(ns->file)->i_blkbits, 12);
+			file_inode(ns->file)->i_blkbits, 16);

Make that ilog(SZ_64K) instead of the magic number shift?

Otherwise looks good.

maintainer Reviewed-by
#2 lore raw
Quoted 7 lines · Christoph Hellwig

drivers/nvme/target/io-cmd-file.c int nvmet_file_ns_enable(struct nvmet_ns *ns) · line 56

Quoted 2 lines · Hannes Reinecke
drivers/nvme/target/io-cmd-file.c +1 -1
-			file_inode(ns->file)->i_blkbits, 12);
+			file_inode(ns->file)->i_blkbits, 16);

Make that ilog(SZ_64K) instead of the magic number shift?

Otherwise looks good.

 lgtm with hch suggestio