dt-bindings: remoteproc: Fix dead link to Keystone DSP GPIO binding
Subsystems (2)
PATCH v2 1/1 dt-bindings: remoteproc: Fix dead link to Keystone DSP GPIO binding
The old text binding 'gpio-dsp-keystone.txt' was replaced by a DT schema in commit aff0a1701b020c8e6b172f28828fd4f3e6eed41a
("dt-bindings: gpio: Convert ti,keystone-dsp-gpio to DT schema").
Update the reference to point to the new file.
--- .../devicetree/bindings/remoteproc/ti,keystone-rproc.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt +1 -1
@@ -66,7 +66,7 @@ The following are the mandatory properties: - kick-gpios: Should specify the gpio device needed for the virtio IPC stack. This will be used to interrupt the remote processor. The gpio device to be used is as per the bindings in, - Documentation/devicetree/bindings/gpio/gpio-dsp-keystone.txt + Documentation/devicetree/bindings/gpio/ti,keystone-dsp-gpio.yaml SoC-specific Required properties: ---------------------------------
Signature · 1 line
2.34.1
Quoted 2 lines · Soham Metha
The old text binding 'gpio-dsp-keystone.txt' was replaced by a DT schema in commit
aff0a1701b020c8e6b172f28828fd4f3e6eed41a
Did you actually read what I asked? I think you just sent it too fast to be able to read entire multi-page document. If you read it, you would see that abbrev is 12 characters/digits.
Quoted 3 lines
("dt-bindings: gpio: Convert ti,keystone-dsp-gpio to DT schema").
Update the reference to point to the new file.
This wasn't here before, no need to add obvious statements.
Best regards,
Krzysztof
Thank you for the feedback.
Quoted 8 lines · Krzysztof Kozlowski
Quoted 2 lines · Soham Metha
The old text binding 'gpio-dsp-keystone.txt' was replaced by a DT schema in commit
aff0a1701b020c8e6b172f28828fd4f3e6eed41aDid you actually read what I asked? I think you just sent it too fast to be able to read entire multi-page document. If you read it, you would see that abbrev is 12 characters/digits.
I did see the documentation mention that the abbreviation should use at least 12 characters, but I didn’t notice any upper limit mentioned in the text. Because of this wording, I assumed longer values were acceptable.
Should I send a v3 with a 12-character abbreviation?
Quoted 8 lines
Quoted 3 lines
("dt-bindings: gpio: Convert ti,keystone-dsp-gpio to DT schema").
Update the reference to point to the new file.
This wasn't here before, no need to add obvious statements.
Best regards,
Krzysztof
--
Soham
Krzysztof Kozlowski
Acked-byQuoted 12 lines · Soham Metha
Thank you for the feedback.
Quoted 8 lines · Krzysztof Kozlowski
Quoted 2 lines · Soham Metha
The old text binding 'gpio-dsp-keystone.txt' was replaced by a DT schema in commit
aff0a1701b020c8e6b172f28828fd4f3e6eed41aDid you actually read what I asked? I think you just sent it too fast to be able to read entire multi-page document. If you read it, you would see that abbrev is 12 characters/digits.
Quoted 6 lines
I did see the documentation mention that the abbreviation should use at least 12 characters, but I didn’t notice any upper limit mentioned in the text. Because of this wording, I assumed longer values were acceptable.
Should I send a v3 with a 12-character abbreviation?
No need, this is just a nit.
Best regards,
Krzysztof
Quoted 11 lines · Soham Metha
The old text binding 'gpio-dsp-keystone.txt' was replaced by a DT schema in commit
aff0a1701b020c8e6b172f28828fd4f3e6eed41a
("dt-bindings: gpio: Convert ti,keystone-dsp-gpio to DT schema").Update the reference to point to the new file.
Signed-off-by Soham Metha <[email protected]>--- .../devicetree/bindings/remoteproc/ti,keystone-rproc.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied.
Thanks,
Mathieu
Quoted 16 lines
Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt +1
-1@@ -66,7 +66,7 @@ The following are the mandatory properties: - kick-gpios: Should specify the gpio device needed for the virtio IPC stack. This will be used to interrupt the remote processor. The gpio device to be used is as per the bindings in, - Documentation/devicetree/bindings/gpio/gpio-dsp-keystone.txt + Documentation/devicetree/bindings/gpio/ti,keystone-dsp-gpio.yaml SoC-specific Required properties: ---------------------------------Signature · 1 line
2.34.1