Skip to contentSkip to conversation

drm/imx: select DRM_DISPLAY_HELPER as needed

PATCH In review Arnd Bergmann 2 participants 2 messages Dec 4, 2025

Subsystems (4)
DRM drivers DRM misc Arm i.MX and Layerscape DRM drivers for Freescale i.MX 5/6
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 drm/imx: select DRM_DISPLAY_HELPER as needed

From: Arnd Bergmann <[email protected]>

CONFIG_DRM_BRIDGE_CONNECTOR is a bool option that turns on features of the display helpers, which are in a module controlled by the (tristate) CONFIG_DRM_DISPLAY_HELPER. If the display helpers are in a loadable module, a built-in driver trying to use the bridge connectors fails to link:

x86_64-linux-ld: drivers/gpu/drm/imx/ipuv3/parallel-display.o: in function `imx_pd_bind':
parallel-display.c:(.text+0xcd): undefined reference to `drm_bridge_connector_init'
x86_64-linux-ld: drivers/gpu/drm/imx/ipuv3/imx-ldb.o: in function `imx_ldb_bind':
imx-ldb.c:(.text+0x224): undefined reference to `drm_bridge_connector_init'

Select the DRM_BRIDGE_CONNECTOR symbol as well, to ensure it's built-in if anything needs it.

Fixes f94b9707a1c9 ("drm/imx: parallel-display: switch to imx_legacy_bridge / drm_bridge_connector")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/gpu/drm/imx/ipuv3/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/imx/ipuv3/Kconfig +2 -0
index acaf25089001..1c3825a86380 100644
@@ -13,6 +13,7 @@ config DRM_IMX
 config DRM_IMX_PARALLEL_DISPLAY
 	tristate "Support for parallel displays"
 	depends on DRM_IMX
+	select DRM_DISPLAY_HELPER
 	select DRM_BRIDGE
 	select DRM_BRIDGE_CONNECTOR
 	select DRM_IMX_LEGACY_BRIDGE

@@ -33,6 +34,7 @@ config DRM_IMX_LDB
 	depends on DRM_IMX
 	depends on COMMON_CLK
 	select MFD_SYSCON
+	select DRM_DISPLAY_HELPER
 	select DRM_BRIDGE
 	select DRM_BRIDGE_CONNECTOR
 	select DRM_PANEL_BRIDGE
Signature · 1 line
2.39.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

CONFIG_DRM_BRIDGE_CONNECTOR is a bool option that turns on features of the display helpers, which are in a module controlled by the (tristate) CONFIG_DRM_DISPLAY_HELPER. If the display helpers are in a loadable module, a built-in driver trying to use the bridge connectors fails to link:

x86_64-linux-ld: drivers/gpu/drm/imx/ipuv3/parallel-display.o: in function `imx_pd_bind':
parallel-display.c:(.text+0xcd): undefined reference to `drm_bridge_connector_init'
x86_64-linux-ld: drivers/gpu/drm/imx/ipuv3/imx-ldb.o: in function `imx_ldb_bind':
imx-ldb.c:(.text+0x224): undefined reference to `drm_bridge_connector_init'

Quoted 8 lines

Select the DRM_BRIDGE_CONNECTOR symbol as well, to ensure it's built-in if anything needs it.

Fixes f94b9707a1c9 ("drm/imx: parallel-display: switch to imx_legacy_bridge / drm_bridge_connector")
Signed-off-by Arnd Bergmann <[email protected]>
---
  drivers/gpu/drm/imx/ipuv3/Kconfig | 2 ++
  1 file changed, 2 insertions(+)
Reviewed-by Dmitry Baryshkov <[email protected]>
Signature · 2 lines
With best wishes
Dmitry