xfs: fix stupid compiler warning
PATCH 1/1 xfs: fix stupid compiler warning
From: Darrick J. Wong <[email protected]>
gcc 14.2 warns about:
xfs_attr_item.c: In function ‘xfs_attr_recover_work’:
xfs_attr_item.c:785:9: warning: ‘ip’ may be used uninitialized [-Wmaybe-uninitialized]
785 | xfs_trans_ijoin(tp, ip, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~xfs_attr_item.c:740:42: note: ‘ip’ was declared here
740 | struct xfs_inode *ip;
| ^~
I think this is bogus since xfs_attri_recover_work either returns a real pointer having initialized ip or an ERR_PTR having not touched it, but the tools are smarter than me so let's just null-init the variable anyway.
--- fs/xfs/xfs_attr_item.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_attr_item.c +1 -1
@@ -737,7 +737,7 @@ xfs_attr_recover_work(struct xfs_attri_log_item *attrip =ATTRI_ITEM (lip);struct xfs_attr_intent *attr;struct xfs_mount *mp = lip->li_log->l_mp; -struct xfs_inode *ip; +struct xfs_inode *ip =NULL ;struct xfs_da_args *args;struct xfs_trans *tp;struct xfs_trans_res resv;
Quoted 8 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
gcc 14.2 warns about:
xfs_attr_item.c: In function ‘xfs_attr_recover_work’:
xfs_attr_item.c:785:9: warning: ‘ip’ may be used uninitialized [-Wmaybe-uninitialized]785 | xfs_trans_ijoin(tp, ip, 0); | ^~~~~~~~~~~~~~~~~~~~~~~~~~
Quoted 9 lines
xfs_attr_item.c:740:42: note: ‘ip’ was declared here
740 | structxfs_inode*ip;
| ^~I think this is bogus since
xfs_attri_recover_workeither returns a real pointer having initialized ip or anERR_PTRhaving not touched it, but the tools are smarter than me so let's just null-init the variable anyway.
Looks good:
Quoted 29 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
gcc 14.2 warns about:
xfs_attr_item.c: In function ‘xfs_attr_recover_work’:
xfs_attr_item.c:785:9: warning: ‘ip’ may be used uninitialized [-Wmaybe-uninitialized]785 | xfs_trans_ijoin(tp, ip, 0); | ^~~~~~~~~~~~~~~~~~~~~~~~~~xfs_attr_item.c:740:42: note: ‘ip’ was declared here
740 | structxfs_inode*ip;
| ^~I think this is bogus since
xfs_attri_recover_workeither returns a real pointer having initialized ip or anERR_PTRhaving not touched it, but the tools are smarter than me so let's just null-init the variable anyway.Cc <[email protected]> # v6.8Fixes e70fb328d52772 ("xfs: recreate work items when recovering intent items")Signed-off-by "Darrick J. Wong" <[email protected]>--- fs/xfs/xfs_attr_item.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/xfs/xfs_attr_item.c +0
-0
fs/xfs/xfs_attr_item.c xfs_attr_recover_work( · line 743
Quoted 8 lines
fs/xfs/xfs_attr_item.c +1
-1@@ -737,7 +737,7 @@ xfs_attr_recover_work(struct xfs_attri_log_item *attrip =ATTRI_ITEM (lip);struct xfs_attr_intent *attr;struct xfs_mount *mp = lip->li_log->l_mp; -struct xfs_inode *ip; +struct xfs_inode *ip =NULL ;struct xfs_da_args *args;struct xfs_trans *tp;struct xfs_trans_res resv;
Looks good