media: i2c: ov5647: use our own mutex for the ctrl lock
PATCH v2 1/1 media: i2c: ov5647: use our own mutex for the ctrl lock
__v4l2_ctrl_handler_setup() and __v4l2_ctrl_modify_range() contains an assertion to verify that the v4l2_ctrl_handler::lock is held, as it should only be called when the lock has already been acquired. Therefore use our own mutex for the ctrl lock, otherwise a warning will be reported.
Fixes 4974c2f19fd8 ("media: ov5647: Support gain, exposure and AWB controls")
Signed-off-by Xiaolei Wang <[email protected]>
---
v1: https://patchwork.kernel.org/project/linux-media/patch/[email protected]/
v2: Compared to v1, directly using sensor->ctrls avoids introducing unnecessary variables and adds a fix tag to address the initial issue.
drivers/media/i2c/ov5647.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/media/i2c/ov5647.c +2 -0
@@ -1291,6 +1291,8 @@ static int ov5647_init_controls(struct ov5647 *sensor)v4l2_ctrl_handler_init (&sensor->ctrls,9 ); + sensor->ctrls.lock = &sensor->lock; +v4l2_ctrl_new_std (&sensor->ctrls, &ov5647_ctrl_ops,V4L2_CID_AUTOGAIN ,0 ,1 ,1 ,0 );
Signature · 1 line
2.43.0