Skip to contentSkip to conversation

perf test: Fix test case perf evlist tests for s390x

PATCH Superseded Thomas Richter 2 participants 2 messages Dec 9, 2025

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf test: Fix test case perf evlist tests for s390x

Perf test case 78: perf evlist tests fails on s390. The failure is causes by grouping events cycles and instructions because sampling does only support event cycles.
Change the group to -e '{cycles,cycles}' to fix this.

Output before:

  # ./perf test 78
  78: perf evlist tests              : FAILED!
  #

Output after:

  # ./perf test 78
  78: perf evlist tests              : Ok
  #
Fixes db452961de939 ("perf tests evlist: Add basic evlist test")
---
 tools/perf/tests/shell/evlist.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/tests/shell/evlist.sh +2 -2
index 140f099e75c1..80f808b3059d 100755
@@ -38,13 +38,13 @@ test_evlist_simple() {
 
 test_evlist_group() {
 	echo "Group evlist test"
-	if ! perf record -e "{cycles,instructions}" -o "${perfdata}" true 2> /dev/null
+	if ! perf record -e "{cycles,cycles}" -o "${perfdata}" true 2> /dev/null
 	then
 		echo "Group evlist [Skipped event group recording failed]"
 		return
 	fi
 
-	if ! perf evlist -i "${perfdata}" -g | grep -q "{.*cycles.*,.*instructions.*}"
+	if ! perf evlist -i "${perfdata}" -g | grep -q "{.*cycles.*,.*cycles.*}"
 	then
 		echo "Group evlist [Failed to list event group]"
 		err=1
Signature · 1 line
2.52.0
reviewer
#1 lore raw
Quoted 11 lines · Thomas Richter

Perf test case 78: perf evlist tests fails on s390. The failure is causes by grouping events cycles and instructions because sampling does only support event cycles.
Change the group to -e '{cycles,cycles}' to fix this.

Output before:

  # ./perf test 78
  78: perf evlist tests              : FAILED!
  #
Quoted 7 lines

Output after:

  # ./perf test 78
  78: perf evlist tests              : Ok
  #
Fixes db452961de939 ("perf tests evlist: Add basic evlist test")

Thanks Thomas, I always appreciate your help and fixes! Do you think we should switch to software events to remedy this issue? Perhaps cpu-clock and task-clock? I worry about event deduplication possibly causing issues were it to happen.

Thanks,
Ian

Quoted 27 lines
---
 tools/perf/tests/shell/evlist.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/tests/shell/evlist.sh +2 -3
index 140f099e75c1..80f808b3059d 100755
@@ -38,13 +38,13 @@ test_evlist_simple() {
 
 test_evlist_group() {
        echo "Group evlist test"
-       if ! perf record -e "{cycles,instructions}" -o "${perfdata}" true 2> /dev/null
+       if ! perf record -e "{cycles,cycles}" -o "${perfdata}" true 2> /dev/null
        then
                echo "Group evlist [Skipped event group recording failed]"
                return
        fi
 
-       if ! perf evlist -i "${perfdata}" -g | grep -q "{.*cycles.*,.*instructions.*}"
+       if ! perf evlist -i "${perfdata}" -g | grep -q "{.*cycles.*,.*cycles.*}"
        then
                echo "Group evlist [Failed to list event group]"
                err=1
--

2.52.0