arm64: broadcom: bcm2712: Drop rp1 overlay
Rob Herring (Arm)
maintainerPATCH v2 1/1 arm64: broadcom: bcm2712: Drop rp1 overlay
It's a requirement that DT overlays be applied at build time in order to validate them as overlays are not validated on their own, but the rp1.dtbo is not applied to anything. The rp1.dtso overlay doesn't work on its own as there are additional settings needed as seen in bcm2712-rpi-5-b.dts. In addition, the 'rp1_nexus' node is applied to the wrong place in the DT as it should be under a PCIe root port rather than the host bridge. There's also a duplicate overlay in drivers/misc/rp1/.
For these reasons, just drop the overlay to fix the warning until all these issues can be fixed.
---
The missing applying of rp1.dtbo is now a warning in v6.19-rc1. This should be sent to Linus ASAP.
v2:
- Drop the overlay instead of trying to rework. The addition of ethernet0 alias complicates that.
--- arch/arm64/boot/dts/broadcom/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm64/boot/dts/broadcom/Makefile +1 -2
@@ -14,8 +14,7 @@ dtb-$(CONFIG_ARCH_BCM2835) += bcm2711-rpi-400.dtb \ bcm2837-rpi-3-b.dtb \ bcm2837-rpi-3-b-plus.dtb \ bcm2837-rpi-cm3-io3.dtb \ - bcm2837-rpi-zero-2-w.dtb \ - rp1.dtbo + bcm2837-rpi-zero-2-w.dtb subdir-y += bcmbca subdir-y += northstar2
Signature · 1 line
2.51.0
Hi Rob,
Quoted 28 lines · Rob Herring (Arm)
It's a requirement that DT overlays be applied at build time in order to validate them as overlays are not validated on their own, but the rp1.dtbo is not applied to anything. The rp1.dtso overlay doesn't work on its own as there are additional settings needed as seen in
bcm2712-rpi-5-b.dts. In addition, the 'rp1_nexus' node is applied to the wrong place in the DT as it should be under a PCIe root port rather than the host bridge. There's also a duplicate overlay indrivers/misc/rp1/.For these reasons, just drop the overlay to fix the warning until all these issues can be fixed.
Signed-off-by Rob Herring (Arm) <[email protected]>---
The missing applying of rp1.dtbo is now a warning in v6.19-rc1. This should be sent to Linus ASAP.v2:
- Drop the overlay instead of trying to rework. The addition of ethernet0 alias complicates that.--- arch/arm64/boot/dts/broadcom/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)arch/arm64/boot/dts/broadcom/Makefile +0
-0
arch/arm64/boot/dts/broadcom/Makefile dtb-$(CONFIG_ARCH_BCM2835) += bcm2711-rpi-400.dtb \ · line 17
Quoted 6 lines
arch/arm64/boot/dts/broadcom/Makefile +1
-2@@ -14,8 +14,7 @@ dtb-$(CONFIG_ARCH_BCM2835) += bcm2711-rpi-400.dtb \ bcm2837-rpi-3-b.dtb \ bcm2837-rpi-3-b-plus.dtb \ bcm2837-rpi-cm3-io3.dtb \ - bcm2837-rpi-zero-2-w.dtb \ - rp1.dtbo + bcm2837-rpi-zero-2-w.dtb
I'm preparing a rework patch that drops the overlay too, it will fix this warning and the other concerns about RP1 DT hierarchy. Anyway, since this warning seems to annoy a lot of people, feel free to apply it in the meantime and I'll adapt accordingly, hence:
Thanks,
Andrea
Quoted 6 lines
arch/arm64/boot/dts/broadcom/Makefile +0
-0subdir-y += bcmbca subdir-y += northstar2Signature · 1 line
2.51.0