Skip to contentSkip to conversation

PCI/VGA: Don't assume the only VGA device on a system is `boot_vga`

PATCH Superseded Mario Limonciello (AMD) 1 participant 1 message Dec 14, 2025 PCI

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 PCI/VGA: Don't assume the only VGA device on a system is `boot_vga`

Some systems ship with multiple display class devices but not all of them are VGA devices. If the "only" VGA device on the system is not used for displaying the image on the screen marking it as boot_vga because nothing was found is totally wrong.

This behavior actually leads to mistakes of the wrong device being advertised to userspace and then userspace can make incorrect decisions.

As there is an accurate boot_display sysfs file stop lying about boot_vga by assuming if nothing is found it's the right device.

---
v2:
* Add tags
* Rebase on v6.19-rc1
* v1: https://lore.kernel.org/linux-pci/[email protected]/

---
 drivers/pci/vgaarb.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/pci/vgaarb.c +0 -7
index 436fa7f4c3873..baa242b140993 100644
@@ -652,13 +652,6 @@ static bool vga_is_boot_device(struct vga_device *vgadev)
 		return true;
 	}
 
-	/*
-	 * Vgadev has neither IO nor MEM enabled.  If we haven't found any
-	 * other VGA devices, it is the best candidate so far.
-	 */
-	if (!boot_vga)
-		return true;
-
 	return false;
 }
 
Signature · 1 line
2.43.0