ASoC: SOF: topology: Add context when sink or source widget is missing
Subsystems (3)
Peter Ujfalusi
maintainerPATCH 1/1 ASoC: SOF: topology: Add context when sink or source widget is missing
Add some context to the error prints when sink or source widget is not found by printing the name of the other side of the connection.
--- sound/soc/sof/topology.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
sound/soc/sof/topology.c +4 -4
@@ -2106,8 +2106,8 @@ static int sof_route_load(struct snd_soc_component *scomp, int index,/* source component */ source_swidget =snd_sof_find_swidget (scomp, (char *)route->source);if (!source_swidget) { -dev_err (scomp->dev,"error: source %s not found\n" , - route->source); +dev_err (scomp->dev,"source %s for sink %s is not found\n" , + route->source, route->sink); ret = -EINVAL ; goto err; }
@@ -2125,8 +2125,8 @@ static int sof_route_load(struct snd_soc_component *scomp, int index,/* sink component */ sink_swidget =snd_sof_find_swidget (scomp, (char *)route->sink);if (!sink_swidget) { -dev_err (scomp->dev,"error: sink %s not found\n" , - route->sink); +dev_err (scomp->dev,"sink %s for source %s is not found\n" , + route->sink, route->source); ret = -EINVAL ; goto err; }
Signature · 1 line
2.52.0
Mark Brown
maintainerQuoted 4 lines · Peter Ujfalusi
Add some context to the error prints when sink or source widget is not found by printing the name of the other side of the connection.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: SOF: topology: Add context when sink or source widget is missing
commit: 84085139290a38c5f8a14e5bba60936392c17c7f
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark