staging: rtl8723bs: coding style cleanup
v4 cover staging: rtl8723bs: coding style cleanup
Remove unnecessary braces and else block in odm_CfoTracking.c
Changes in v4:
- Include missing changelog
Changes in v3:
- Clean up commit message
Changes in v2
- Split the previous patch into two patches
Sanghyeon Lee (2):
staging: rtl8723bs: remove unnecessary braces
staging: rtl8723bs: remove unnecessary else block
drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)
Signature · 1 line
2.43.0
PATCH v4 1/2 staging: rtl8723bs: remove unnecessary braces
Remove unnecessary braces from single-line conditional statements in odm_CfoTracking.c to fix a checkpatch warning.
Signed-off-by Sanghyeon Lee <[email protected]>
--- drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
drivers/staging/rtl8723bs/hal/odm_CfoTracking.c +5 -7
@@ -100,9 +100,8 @@ void ODM_CfoTracking(void *pDM_VOID)u8 Adjust_Xtal =1 ;/* 4 Support ability */ -if (!(pDM_Odm->SupportAbility &ODM_BB_CFO_TRACKING )) { +if (!(pDM_Odm->SupportAbility &ODM_BB_CFO_TRACKING ))return ; - }if (!pDM_Odm->bLinked || !pDM_Odm->bOneEntryOnly) {/* 4 No link or more than one entry */
@@ -110,9 +109,9 @@ void ODM_CfoTracking(void *pDM_VOID) }else {/* 3 1. CFO Tracking */ /* 4 1.1 No new packet */ -if (pCfoTrack->packetCount == pCfoTrack->packetCount_pre) { +if (pCfoTrack->packetCount == pCfoTrack->packetCount_pre)return ; - } + pCfoTrack->packetCount_pre = pCfoTrack->packetCount;/* 4 1.2 Calculate CFO */
@@ -176,11 +175,10 @@ void ODM_CfoTracking(void *pDM_VOID) }/* 3 2. Dynamic ATC switch */ -if (CFO_ave <CFO_TH_ATC && CFO_ave > -CFO_TH_ATC ) { +if (CFO_ave <CFO_TH_ATC && CFO_ave > -CFO_TH_ATC )odm_SetATCStatus (pDM_Odm, false); - }else { +else odm_SetATCStatus (pDM_Odm, true); - } } }
Signature · 1 line
2.43.0
PATCH v4 2/2 staging: rtl8723bs: remove unnecessary else block
In reply to Sanghyeon LeeRemove unnecessary else block after return statement in odm_CfoTracking.c to fix a checkpatch warning.
Signed-off-by Sanghyeon Lee <[email protected]>
--- drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/hal/odm_CfoTracking.c +3 -2
@@ -132,8 +132,9 @@ void ODM_CfoTracking(void *pDM_VOID) ) { pCfoTrack->largeCFOHit =1 ;return ; - } else - pCfoTrack->largeCFOHit = 0; + } + + pCfoTrack->largeCFOHit =0 ; pCfoTrack->CFO_ave_pre = CFO_ave;/* 4 1.4 Dynamic Xtal threshold */
Signature · 1 line
2.43.0