drm/panthor: unlock on error in panthor_ioctl_bo_create()
Subsystems (4)
PATCH 1/1 drm/panthor: unlock on error in panthor_ioctl_bo_create()
Call drm_dev_exit() before returning -EINVAL.
Fixes cd2c9c3015e6 ("drm/panthor: Add flag to map GEM object Write-Back Cacheable")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/gpu/drm/panthor/panthor_drv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/panthor/panthor_drv.c +4 -2
@@ -923,8 +923,10 @@ static int panthor_ioctl_bo_create(struct drm_device *ddev, void *data, }if ((args->flags &DRM_PANTHOR_BO_NO_MMAP ) && - (args->flags &DRM_PANTHOR_BO_WB_MMAP )) -return -EINVAL ; + (args->flags &DRM_PANTHOR_BO_WB_MMAP )) { + ret = -EINVAL ; + goto out_dev_exit; + }if (args->exclusive_vm_id) { vm =panthor_vm_pool_get_vm (pfile->vms, args->exclusive_vm_id);
Signature · 1 line
2.51.0
Quoted 1 line · On Thu, 18 Dec 2025 10:48:22 +0300 Dan Carpenter <[email protected]>…
Call
drm_dev_exit()before returning-EINVAL.
Oops.
Reviewed-by Boris Brezillon <[email protected]>
Quoted 24 lines
Fixes cd2c9c3015e6 ("drm/panthor: Add flag to map GEM object Write-Back Cacheable")Signed-off-by Dan Carpenter <[email protected]>--- drivers/gpu/drm/panthor/panthor_drv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/gpu/drm/panthor/panthor_drv.c +4
-2@@ -923,8 +923,10 @@ static int panthor_ioctl_bo_create(struct drm_device *ddev, void *data, }if ((args->flags &DRM_PANTHOR_BO_NO_MMAP ) && - (args->flags &DRM_PANTHOR_BO_WB_MMAP )) -return -EINVAL ; + (args->flags &DRM_PANTHOR_BO_WB_MMAP )) { + ret = -EINVAL ; + goto out_dev_exit; + }if (args->exclusive_vm_id) { vm =panthor_vm_pool_get_vm (pfile->vms, args->exclusive_vm_id);
Quoted 4 lines · On Thu, 18 Dec 2025 10:48:22 +0300 Dan Carpenter <[email protected]>…
Call
drm_dev_exit()before returning-EINVAL.Fixes cd2c9c3015e6 ("drm/panthor: Add flag to map GEM object Write-Back Cacheable")Signed-off-by Dan Carpenter <[email protected]>
Queued to drm-misc-next.
Quoted 21 lines
--- drivers/gpu/drm/panthor/panthor_drv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/gpu/drm/panthor/panthor_drv.c +4
-2@@ -923,8 +923,10 @@ static int panthor_ioctl_bo_create(struct drm_device *ddev, void *data, }if ((args->flags &DRM_PANTHOR_BO_NO_MMAP ) && - (args->flags &DRM_PANTHOR_BO_WB_MMAP )) -return -EINVAL ; + (args->flags &DRM_PANTHOR_BO_WB_MMAP )) { + ret = -EINVAL ; + goto out_dev_exit; + }if (args->exclusive_vm_id) { vm =panthor_vm_pool_get_vm (pfile->vms, args->exclusive_vm_id);