Skip to contentSkip to conversation

drm/panthor: unlock on error in panthor_ioctl_bo_create()

PATCH Applied Dan Carpenter 2 participants 3 messages Dec 18, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/panthor: unlock on error in panthor_ioctl_bo_create()

Call drm_dev_exit() before returning -EINVAL.

Fixes cd2c9c3015e6 ("drm/panthor: Add flag to map GEM object Write-Back Cacheable")
---
 drivers/gpu/drm/panthor/panthor_drv.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/panthor/panthor_drv.c +4 -2
index 98d4e8d867ed..165dddfde6ca 100644
@@ -923,8 +923,10 @@ static int panthor_ioctl_bo_create(struct drm_device *ddev, void *data,
 	}
 
 	if ((args->flags & DRM_PANTHOR_BO_NO_MMAP) &&
-	    (args->flags & DRM_PANTHOR_BO_WB_MMAP))
-		return -EINVAL;
+	    (args->flags & DRM_PANTHOR_BO_WB_MMAP)) {
+		ret = -EINVAL;
+		goto out_dev_exit;
+	}
 
 	if (args->exclusive_vm_id) {
 		vm = panthor_vm_pool_get_vm(pfile->vms, args->exclusive_vm_id);
Signature · 1 line
2.51.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · On Thu, 18 Dec 2025 10:48:22 +0300 Dan Carpenter <[email protected]>…

Call drm_dev_exit() before returning -EINVAL.

Oops.

Quoted 24 lines
Fixes cd2c9c3015e6 ("drm/panthor: Add flag to map GEM object Write-Back Cacheable")
---
 drivers/gpu/drm/panthor/panthor_drv.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/panthor/panthor_drv.c +4 -2
index 98d4e8d867ed..165dddfde6ca 100644
@@ -923,8 +923,10 @@ static int panthor_ioctl_bo_create(struct drm_device *ddev, void *data,
 	}
 
 	if ((args->flags & DRM_PANTHOR_BO_NO_MMAP) &&
-	    (args->flags & DRM_PANTHOR_BO_WB_MMAP))
-		return -EINVAL;
+	    (args->flags & DRM_PANTHOR_BO_WB_MMAP)) {
+		ret = -EINVAL;
+		goto out_dev_exit;
+	}
 
 	if (args->exclusive_vm_id) {
 		vm = panthor_vm_pool_get_vm(pfile->vms, args->exclusive_vm_id);
maintainer Applied
#2 lore raw
In reply to Dan Carpenter
Quoted 4 lines · On Thu, 18 Dec 2025 10:48:22 +0300 Dan Carpenter <[email protected]>…

Call drm_dev_exit() before returning -EINVAL.

Fixes cd2c9c3015e6 ("drm/panthor: Add flag to map GEM object Write-Back Cacheable")

Queued to drm-misc-next.

Quoted 21 lines
---
 drivers/gpu/drm/panthor/panthor_drv.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/panthor/panthor_drv.c +4 -2
index 98d4e8d867ed..165dddfde6ca 100644
@@ -923,8 +923,10 @@ static int panthor_ioctl_bo_create(struct drm_device *ddev, void *data,
 	}
 
 	if ((args->flags & DRM_PANTHOR_BO_NO_MMAP) &&
-	    (args->flags & DRM_PANTHOR_BO_WB_MMAP))
-		return -EINVAL;
+	    (args->flags & DRM_PANTHOR_BO_WB_MMAP)) {
+		ret = -EINVAL;
+		goto out_dev_exit;
+	}
 
 	if (args->exclusive_vm_id) {
 		vm = panthor_vm_pool_get_vm(pfile->vms, args->exclusive_vm_id);