Skip to contentSkip to conversation

Correct minor spelling mistake in huge_memory.c.

PATCH In review [email protected] 2 participants 4 messages Dec 18, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Correct minor spelling mistake in huge_memory.c.

From: Kevin Lourenco <[email protected]>

No functional changes.

---
 mm/huge_memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/huge_memory.c +1 -1
index 40cf59301c21..5efd2cf4f073 100644
@@ -3220,7 +3220,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
 				swp_entry = make_readable_device_private_entry(
 							page_to_pfn(page + i));
 			/*
-			 * Young and dirty bits are not progated via swp_entry
+			 * Young and dirty bits are not propagated via swp_entry
 			 */
 			entry = swp_entry_to_pte(swp_entry);
 			if (soft_dirty)
Signature · 1 line
2.47.3
#1 lore raw
Quoted 3 lines · On 12/18/25 12:20, [email protected] wrote:

From: Kevin Lourenco <[email protected]>

No functional changes.

Subject: "mm/huge_memory: correct minor spelling mistake"

Then a simple "Let's correct progated -> propagated in a comment."

You can drop the "no functional change" part as you only modify a comment.

Quoted 11 lines
---
  mm/huge_memory.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
mm/huge_memory.c +0 -0
index 40cf59301c21..5efd2cf4f073 100644

mm/huge_memory.c static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, · line 3226

Quoted 8 lines
mm/huge_memory.c +1 -1
@@ -3220,7 +3220,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
  				swp_entry = make_readable_device_private_entry(
  							page_to_pfn(page + i));
  			/*
-			 * Young and dirty bits are not progated via swp_entry
+			 * Young and dirty bits are not propagated via swp_entry
  			 */
  			entry = swp_entry_to_pte(swp_entry);
  			if (soft_dirty)

Are there any other spelling issues in that file so we can avoid more of these patches that don't add a lot of value and only consume reviewer time?

Signature · 3 lines
Cheers

David
#2 lore raw

Hi David,

I have found no other spelling issues. I also did a deeper review of the mm/ directory in general and identified more than 20 evident typos across various files.

I was considering cleaning all of mm/ in one go to provide a more thorough and consistent update. However, if you feel that doing so would not add significant value and would only consume reviewer / my time, I completely understand and can refrain from submitting them. Alternatively, I could create a single patch that addresses all the typos at once in mm/.

Please let me know your preference.

Best regards,
Kevin

Quoted 39 lines · David Hildenbrand (Red Hat)
Quoted 3 lines · On 12/18/25 12:20, [email protected] wrote:

From: Kevin Lourenco <[email protected]>

No functional changes.

Subject: "mm/huge_memory: correct minor spelling mistake"

Then a simple "Let's correct progated -> propagated in a comment."

You can drop the "no functional change" part as you only modify a comment.

Quoted 11 lines
---
  mm/huge_memory.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
mm/huge_memory.c +0 -0
index 40cf59301c21..5efd2cf4f073 100644

mm/huge_memory.c static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, · line 3226

Quoted 8 lines
mm/huge_memory.c +1 -1
@@ -3220,7 +3220,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
                              swp_entry = make_readable_device_private_entry(
                                                      page_to_pfn(page + i));
                      /*
-                      * Young and dirty bits are not progated via swp_entry
+                      * Young and dirty bits are not propagated via swp_entry
                       */
                      entry = swp_entry_to_pte(swp_entry);
                      if (soft_dirty)

Are there any other spelling issues in that file so we can avoid more of these patches that don't add a lot of value and only consume reviewer time?

--
Cheers

David

#3 lore raw
Quoted 6 lines · Kevin Lourenco

Hi David,

I have found no other spelling issues. I also did a deeper review of the mm/ directory in general and identified more than 20 evident typos across various files.

Quoted 8 lines

I was considering cleaning all of mm/ in one go to provide a more thorough and consistent update. However, if you feel that doing so would not add significant value and would only consume reviewer / my time, I completely understand and can refrain from submitting them. Alternatively, I could create a single patch that addresses all the typos at once in mm/.

Please let me know your preference.

Hi Kevin,

then please send all of them in a single series, combining them in patches where reasonable.

For example, the feedback I gave you should be applied to all patches (e.g., subject prefix, patch description).

Imagine doing that as a reviewer to 20 individual patches from 20 individual contributors :)

Signature · 3 lines
Cheers

David