Skip to contentSkip to conversation

RDMA/bnxt_re: Replace cpu_to_be64 + le64_to_cpu with swab64

PATCH In review Thorsten Blum 2 participants 2 messages Dec 10, 2025 – Dec 18, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/bnxt_re: Replace cpu_to_be64 + le64_to_cpu with swab64

Replace cpu_to_be64(le64_to_cpu()) with swab64() to simplify bnxt_re_assign_pma_port_ext_counters(). No functional changes.

---
 drivers/infiniband/hw/bnxt_re/hw_counters.c | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)
drivers/infiniband/hw/bnxt_re/hw_counters.c +6 -13
index 651cf9d0e0c7..bb1137ad84c0 100644
@@ -290,19 +290,12 @@ int bnxt_re_assign_pma_port_ext_counters(struct bnxt_re_dev *rdev, struct ib_mad
 	pma_cnt_ext = (struct ib_pma_portcounters_ext *)(out_mad->data + 40);
 	if ((bnxt_qplib_is_chip_gen_p5(rdev->chip_ctx) && rdev->is_virtfn) ||
 	    !bnxt_qplib_is_chip_gen_p5(rdev->chip_ctx)) {
-		pma_cnt_ext->port_xmit_data =
-			cpu_to_be64(le64_to_cpu(hw_stats->tx_ucast_bytes) / 4);
-		pma_cnt_ext->port_rcv_data =
-			cpu_to_be64(le64_to_cpu(hw_stats->rx_ucast_bytes) / 4);
-		pma_cnt_ext->port_xmit_packets =
-			cpu_to_be64(le64_to_cpu(hw_stats->tx_ucast_pkts));
-		pma_cnt_ext->port_rcv_packets =
-			cpu_to_be64(le64_to_cpu(hw_stats->rx_ucast_pkts));
-		pma_cnt_ext->port_unicast_rcv_packets =
-			cpu_to_be64(le64_to_cpu(hw_stats->rx_ucast_pkts));
-		pma_cnt_ext->port_unicast_xmit_packets =
-			cpu_to_be64(le64_to_cpu(hw_stats->tx_ucast_pkts));
-
+		pma_cnt_ext->port_xmit_data = swab64(hw_stats->tx_ucast_bytes / 4);
+		pma_cnt_ext->port_rcv_data = swab64(hw_stats->rx_ucast_bytes / 4);
+		pma_cnt_ext->port_xmit_packets = swab64(hw_stats->tx_ucast_pkts);
+		pma_cnt_ext->port_rcv_packets = swab64(hw_stats->rx_ucast_pkts);
+		pma_cnt_ext->port_unicast_rcv_packets = swab64(hw_stats->rx_ucast_pkts);
+		pma_cnt_ext->port_unicast_xmit_packets = swab64(hw_stats->tx_ucast_pkts);
 	} else {
 		pma_cnt_ext->port_rcv_packets = cpu_to_be64(estat->rx_roce_good_pkts);
 		pma_cnt_ext->port_rcv_data = cpu_to_be64(estat->rx_roce_good_bytes / 4);
Signature · 2 lines
Thorsten Blum <[email protected]>
GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4
#1 lore raw
Quoted 13 lines · Thorsten Blum

Replace cpu_to_be64(le64_to_cpu()) with swab64() to simplify bnxt_re_assign_pma_port_ext_counters(). No functional changes.

---
 drivers/infiniband/hw/bnxt_re/hw_counters.c | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)
drivers/infiniband/hw/bnxt_re/hw_counters.c +0 -0
index 651cf9d0e0c7..bb1137ad84c0 100644

drivers/infiniband/hw/bnxt_re/hw_counters.c int bnxt_re_assign_pma_port_ext_counters(struct bnxt_re_dev *rdev, struct ib_mad · line 294

Quoted 7 lines
drivers/infiniband/hw/bnxt_re/hw_counters.c +1 -2
@@ -290,19 +290,12 @@ int bnxt_re_assign_pma_port_ext_counters(struct bnxt_re_dev *rdev, struct ib_mad
 	pma_cnt_ext = (struct ib_pma_portcounters_ext *)(out_mad->data + 40);
 	if ((bnxt_qplib_is_chip_gen_p5(rdev->chip_ctx) && rdev->is_virtfn) ||
 	    !bnxt_qplib_is_chip_gen_p5(rdev->chip_ctx)) {
-		pma_cnt_ext->port_xmit_data =
-			cpu_to_be64(le64_to_cpu(hw_stats->tx_ucast_bytes) / 4);
 
+		pma_cnt_ext->port_xmit_data = swab64(hw_stats->tx_ucast_bytes / 4);

Why do you think that the above two lines are equal?
hw_stats->tx_ucast_bytes is __le64 value and le64_to_cpu(hw_stats->tx_ucast_bytes) / 4) is not equal to hw_stats->tx_ucast_bytes / 4.

Thanks