Skip to contentSkip to conversation

drm/radeon: convert VCE logging to drm_* helpers

PATCH In review Mukesh Ogare 3 participants 4 messages Dec 20, 2025 – Jan 20

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/radeon: convert VCE logging to drm_* helpers

Replace legacy DRM_ERROR() and DRM_INFO() logging in the VCE code with drm_err() and drm_info() helpers that take a struct drm_device.

Using drm_* logging provides proper device context in dmesg, which is important for systems with multiple DRM devices, and aligns the radeon driver with current DRM logging practices.

No functional change intended.

---
 drivers/gpu/drm/radeon/radeon_vce.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/radeon/radeon_vce.c +1 -1
index a203992cb932..fd176034b251 100644
@@ -121,7 +121,7 @@ int radeon_vce_init(struct radeon_device *rdev)
 	if (sscanf(c, "%2u]", &rdev->vce.fb_version) != 1)
 		return -EINVAL;
 
-	drm_err(&rdev->ddev, "Found VCE firmware/feedback version %d.%d.%d / %d!\n",
+	drm_info(&rdev->ddev, "Found VCE firmware/feedback version %d.%d.%d / %d!\n",
 		 start, mid, end, rdev->vce.fb_version);
 
 	rdev->vce.fw_version = (start << 24) | (mid << 16) | (end << 8);
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 8 lines · Mukesh Ogare

Replace legacy DRM_ERROR() and DRM_INFO() logging in the VCE code with drm_err() and drm_info() helpers that take a struct drm_device.

Using drm_* logging provides proper device context in dmesg, which is important for systems with multiple DRM devices, and aligns the radeon driver with current DRM logging practices.

No functional change intended.

I agree that this should only be info level, but you turn an error level into an info level, so that is a functional change.

Please adjust the commit message accordingly.

Regards,
Christian.

Quoted 19 lines
---
 drivers/gpu/drm/radeon/radeon_vce.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/radeon/radeon_vce.c +1 -1
index a203992cb932..fd176034b251 100644
@@ -121,7 +121,7 @@ int radeon_vce_init(struct radeon_device *rdev)
 	if (sscanf(c, "%2u]", &rdev->vce.fb_version) != 1)
 		return -EINVAL;
 
-	drm_err(&rdev->ddev, "Found VCE firmware/feedback version %d.%d.%d / %d!\n",
+	drm_info(&rdev->ddev, "Found VCE firmware/feedback version %d.%d.%d / %d!\n",
 		 start, mid, end, rdev->vce.fb_version);
 
 	rdev->vce.fw_version = (start << 24) | (mid << 16) | (end << 8);
#2 lore raw

PATCH 1/1 drm/radeon: convert VCE logging to drm_* helpers

Replace legacy DRM_INFO() logging in the VCE code with drm_info() helper that takes a struct drm_device.

This provides proper device context in dmesg on multi-GPU systems and aligns the radeon driver with current DRM logging practices.

Note that this change logs firmware version information at info level and does not indicate a failure.

---
 drivers/gpu/drm/radeon/radeon_vce.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/radeon/radeon_vce.c +3 -2
index bdbc1bbe8a9b..ed631c0e5e28 100644
@@ -121,8 +121,9 @@ int radeon_vce_init(struct radeon_device *rdev)
 	if (sscanf(c, "%2u]", &rdev->vce.fb_version) != 1)
 		return -EINVAL;
 
-	DRM_INFO("Found VCE firmware/feedback version %d.%d.%d / %d!\n",
-		 start, mid, end, rdev->vce.fb_version);
+	drm_info(&rdev->ddev,
+			"Found VCE firmware/feedback version %d.%d.%d / %d!\n",
+			start, mid, end, rdev->vce.fb_version);
 
 	rdev->vce.fw_version = (start << 24) | (mid << 16) | (end << 8);
 
Signature · 1 line
2.43.0
Applied
#3 lore raw

Applied. Thanks!

Quoted 34 lines · Mukesh Ogare

Replace legacy DRM_INFO() logging in the VCE code with drm_info() helper that takes a struct drm_device.

This provides proper device context in dmesg on multi-GPU systems and aligns the radeon driver with current DRM logging practices.

Note that this change logs firmware version information at info level and does not indicate a failure.

---
 drivers/gpu/drm/radeon/radeon_vce.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/radeon/radeon_vce.c +3 -3
index bdbc1bbe8a9b..ed631c0e5e28 100644
@@ -121,8 +121,9 @@ int radeon_vce_init(struct radeon_device *rdev)
        if (sscanf(c, "%2u]", &rdev->vce.fb_version) != 1)
                return -EINVAL;
 
-       DRM_INFO("Found VCE firmware/feedback version %d.%d.%d / %d!\n",
-                start, mid, end, rdev->vce.fb_version);
+       drm_info(&rdev->ddev,
+                       "Found VCE firmware/feedback version %d.%d.%d / %d!\n",
+                       start, mid, end, rdev->vce.fb_version);
 
        rdev->vce.fw_version = (start << 24) | (mid << 16) | (end << 8);
 
--

2.43.0