Skip to contentSkip to conversation

selftests/mm: hugetlb cgroup charging: robustness fixes

PATCH Superseded Li Wang 2 participants 13 messages Dec 21, 2025

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Li Wang

author
#0 lore raw

v2 cover selftests/mm: hugetlb cgroup charging: robustness fixes

Changes in v2:
- 1/3: Parse -s using sscanf("%zu", ...) instead of strtoull().
- 2/3: Fix typo in charge_reserved_hugetlb.sh ("reseravation" -> "reservation").
- 3/3: No changes.

This series fixes a few issues in the hugetlb cgroup charging selftests (write_to_hugetlbfs.c + charge_reserved_hugetlb.sh) that show up on systems with large hugepages (e.g. 512MB) and when failures cause the test to wait indefinitely.

On an aarch64 64k page kernel with 512MB hugepages, the test consistently fails in write_to_hugetlbfs with ENOMEM and then hangs waiting for the expected usage values. The root cause is that charge_reserved_hugetlb.sh mounts hugetlbfs with a fixed size=256M, which is smaller than a single hugepage, resulting in a mount with size=0 capacity.

In addition, write_to_hugetlbfs previously parsed -s via atoi() into an int, which can overflow and print negative sizes.

Reproducer / environment:
- Kernel: 6.12.0-xxx.el10.aarch64+64k
- Hugepagesize: 524288 kB (512MB)
- ./charge_reserved_hugetlb.sh -cgroup-v2
- Observed mount: pagesize=512M,size=0 before this series

After applying the series, the test completes successfully on the above setup.

Li Wang (3):
selftests/mm/write_to_hugetlbfs: parse -s as size_t selftests/mm/charge_reserved_hugetlb.sh: add waits with timeout helper selftests/mm/charge_reserved_hugetlb: fix hugetlbfs mount size for
large hugepages

 .../selftests/mm/charge_reserved_hugetlb.sh   | 51 ++++++++++---------
 .../testing/selftests/mm/write_to_hugetlbfs.c |  9 ++--
 2 files changed, 34 insertions(+), 26 deletions(-)
Signature · 1 line
2.49.0
author
#1 lore raw

PATCH v2 1/3 selftests/mm/write_to_hugetlbfs: parse -s as size_t

write_to_hugetlbfs currently parses the -s size argument with atoi() into an int. This silently accepts malformed input, cannot report overflow, and can truncate large sizes.

--- Error log ---

 # uname -r
 6.12.0-xxx.el10.aarch64+64k
 # ls /sys/kernel/mm/hugepages/hugepages-*
 hugepages-16777216kB/  hugepages-2048kB/  hugepages-524288kB/

#./charge_reserved_hugetlb.sh -cgroup-v2
# -----------------------------------------
...

 # nr hugepages = 10
 # writing cgroup limit: 5368709120
 # writing reseravation limit: 5368709120
 ...
 # Writing to this path: /mnt/huge/test
 # Writing this size: -1610612736        <--------

Switch the size variable to size_t and parse -s with sscanf("%zu", ...). Also print the size using %zu.

This avoids incorrect behavior with large -s values and makes the utility more robust.

Cc David Hildenbrand <[email protected]>
Cc Mark Brown <[email protected]>
Cc Shuah Khan <[email protected]>
Cc Waiman Long <[email protected]>
---
 tools/testing/selftests/mm/write_to_hugetlbfs.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
tools/testing/selftests/mm/write_to_hugetlbfs.c +6 -3
index 34c91f7e6128..ecb5f7619960 100644
@@ -68,7 +68,7 @@ int main(int argc, char **argv)
 	int key = 0;
 	int *ptr = NULL;
 	int c = 0;
-	int size = 0;
+	size_t size = 0;
 	char path[256] = "";
 	enum method method = MAX_METHOD;
 	int want_sleep = 0, private = 0;
@@ -86,7 +86,10 @@ int main(int argc, char **argv)
 	while ((c = getopt(argc, argv, "s:p:m:owlrn")) != -1) {
 		switch (c) {
 		case 's':
-			size = atoi(optarg);
+			if (sscanf(optarg, "%zu", &size) != 1) {
+				perror("Invalid -s.");
+				exit_usage();
+			}
 			break;
 		case 'p':
 			strncpy(path, optarg, sizeof(path) - 1);
@@ -131,7 +134,7 @@ int main(int argc, char **argv)
 	}
 
 	if (size != 0) {
-		printf("Writing this size: %d\n", size);
+		printf("Writing this size: %zu\n", size);
 	} else {
 		errno = EINVAL;
 		perror("size not found");
Signature · 1 line
2.49.0
maintainer Acked-by on v2 1/3
#2 lore raw

Re: [PATCH v2 1/3] selftests/mm/write_to_hugetlbfs: parse -s as size_t

Quoted 14 lines · Li Wang

write_to_hugetlbfs currently parses the -s size argument with atoi() into an int. This silently accepts malformed input, cannot report overflow, and can truncate large sizes.

--- Error log ---

  # uname -r
  6.12.0-xxx.el10.aarch64+64k
  # ls /sys/kernel/mm/hugepages/hugepages-*
  hugepages-16777216kB/  hugepages-2048kB/  hugepages-524288kB/

#./charge_reserved_hugetlb.sh -cgroup-v2
# -----------------------------------------
...

Quoted 6 lines
  # nr hugepages = 10
  # writing cgroup limit: 5368709120
  # writing reseravation limit: 5368709120
  ...
  # Writing to this path: /mnt/huge/test
  # Writing this size: -1610612736        <--------

I mean, whoever does that should not expect anything reasonable to happen with these selftests ... so I don't think Fixes: should be added.

Signature · 3 lines
Cheers

David
author
#3 lore raw

PATCH v2 2/3 selftests/mm/charge_reserved_hugetlb.sh: add waits with timeout helper

In reply to Li Wang

The hugetlb cgroup usage wait loops in charge_reserved_hugetlb.sh were unbounded and could hang forever if the expected cgroup file value never appears (e.g. due to bugs, timing issues, or unexpected behavior).

--- Error log ---

  # uname -r
  6.12.0-xxx.el10.aarch64+64k
  # ls /sys/kernel/mm/hugepages/hugepages-*
  hugepages-16777216kB/  hugepages-2048kB/  hugepages-524288kB/

#./charge_reserved_hugetlb.sh -cgroup-v2
# -----------------------------------------
...

  # nr hugepages = 10
  # writing cgroup limit: 5368709120
  # writing reseravation limit: 5368709120
  ...
  # write_to_hugetlbfs: Error mapping the file: Cannot allocate memory
  # Waiting for hugetlb memory reservation to reach size 2684354560.
  # 0
  # Waiting for hugetlb memory reservation to reach size 2684354560.
  # 0
  # Waiting for hugetlb memory reservation to reach size 2684354560.
  # 0
  # Waiting for hugetlb memory reservation to reach size 2684354560.
  # 0
  # Waiting for hugetlb memory reservation to reach size 2684354560.
  # 0
  # Waiting for hugetlb memory reservation to reach size 2684354560.
  # 0
  ...

Introduce a small helper, wait_for_file_value(), and use it for:
- waiting for reservation usage to drop to 0,
- waiting for reservation usage to reach a given size,
- waiting for fault usage to reach a given size.

This makes the waits consistent and adds a hard timeout (120 tries with 0.5s sleep) so the test fails instead of stalling indefinitely.

Cc David Hildenbrand <[email protected]>
Cc Mark Brown <[email protected]>
Cc Shuah Khan <[email protected]>
Cc Waiman Long <[email protected]>
---
 .../selftests/mm/charge_reserved_hugetlb.sh   | 47 ++++++++++---------
 1 file changed, 26 insertions(+), 21 deletions(-)
tools/testing/selftests/mm/charge_reserved_hugetlb.sh +26 -21
index e1fe16bcbbe8..249a5776c074 100755
@@ -100,7 +100,7 @@ function setup_cgroup() {
   echo writing cgroup limit: "$cgroup_limit"
   echo "$cgroup_limit" >$cgroup_path/$name/hugetlb.${MB}MB.$fault_limit_file
 
-  echo writing reseravation limit: "$reservation_limit"
+  echo writing reservation limit: "$reservation_limit"
   echo "$reservation_limit" > \
     $cgroup_path/$name/hugetlb.${MB}MB.$reservation_limit_file
 
@@ -112,41 +112,46 @@ function setup_cgroup() {
   fi
 }
 
+function wait_for_file_value() {
+  local path="$1"
+  local expect="$2"
+  local max_tries="120"
+
+  local i cur
+  for ((i=1; i<=max_tries; i++)); do
+    cur="$(cat "$path")"
+    if [[ "$cur" == "$expect" ]]; then
+      return 0
+    fi
+    echo "Waiting for $path to become '$expect' (current: '$cur') (try $i/$max_tries)"
+    sleep 0.5
+  done
+
+  echo "ERROR: timeout waiting for $path to become '$expect' (last: '$cur')"
+  return 1
+}
+
 function wait_for_hugetlb_memory_to_get_depleted() {
   local cgroup="$1"
   local path="$cgroup_path/$cgroup/hugetlb.${MB}MB.$reservation_usage_file"
-  # Wait for hugetlbfs memory to get depleted.
-  while [ $(cat $path) != 0 ]; do
-    echo Waiting for hugetlb memory to get depleted.
-    cat $path
-    sleep 0.5
-  done
+
+  wait_for_file_value "$path" "0"
 }
 
 function wait_for_hugetlb_memory_to_get_reserved() {
   local cgroup="$1"
   local size="$2"
-
   local path="$cgroup_path/$cgroup/hugetlb.${MB}MB.$reservation_usage_file"
-  # Wait for hugetlbfs memory to get written.
-  while [ $(cat $path) != $size ]; do
-    echo Waiting for hugetlb memory reservation to reach size $size.
-    cat $path
-    sleep 0.5
-  done
+
+  wait_for_file_value "$path" "$size"
 }
 
 function wait_for_hugetlb_memory_to_get_written() {
   local cgroup="$1"
   local size="$2"
-
   local path="$cgroup_path/$cgroup/hugetlb.${MB}MB.$fault_usage_file"
-  # Wait for hugetlbfs memory to get written.
-  while [ $(cat $path) != $size ]; do
-    echo Waiting for hugetlb memory to reach size $size.
-    cat $path
-    sleep 0.5
-  done
+
+  wait_for_file_value "$path" "$size"
 }
 
 function write_hugetlbfs_and_get_usage() {
Signature · 1 line
2.49.0
#4 lore raw

Re: [PATCH v2 2/3] selftests/mm/charge_reserved_hugetlb.sh: add waits with timeout helper

Quoted 3 lines · Li Wang

The hugetlb cgroup usage wait loops in charge_reserved_hugetlb.sh were unbounded and could hang forever if the expected cgroup file value never appears (e.g. due to bugs, timing issues, or unexpected behavior).

Did you actually hit that in practice? Just wondering.

Quoted 61 lines

--- Error log ---

   # uname -r
   6.12.0-xxx.el10.aarch64+64k
   # ls /sys/kernel/mm/hugepages/hugepages-*
   hugepages-16777216kB/  hugepages-2048kB/  hugepages-524288kB/
   #./charge_reserved_hugetlb.sh -cgroup-v2
   # -----------------------------------------
   ...
   # nr hugepages = 10
   # writing cgroup limit: 5368709120
   # writing reseravation limit: 5368709120
   ...
   # write_to_hugetlbfs: Error mapping the file: Cannot allocate memory
   # Waiting for hugetlb memory reservation to reach size 2684354560.
   # 0
   # Waiting for hugetlb memory reservation to reach size 2684354560.
   # 0
   # Waiting for hugetlb memory reservation to reach size 2684354560.
   # 0
   # Waiting for hugetlb memory reservation to reach size 2684354560.
   # 0
   # Waiting for hugetlb memory reservation to reach size 2684354560.
   # 0
   # Waiting for hugetlb memory reservation to reach size 2684354560.
   # 0
   ...

Introduce a small helper, wait_for_file_value(), and use it for:
- waiting for reservation usage to drop to 0,
- waiting for reservation usage to reach a given size,
- waiting for fault usage to reach a given size.

This makes the waits consistent and adds a hard timeout (120 tries with 0.5s sleep) so the test fails instead of stalling indefinitely.

Cc David Hildenbrand <[email protected]>
Cc Mark Brown <[email protected]>
Cc Shuah Khan <[email protected]>
Cc Waiman Long <[email protected]>
---
  .../selftests/mm/charge_reserved_hugetlb.sh   | 47 ++++++++++---------
  1 file changed, 26 insertions(+), 21 deletions(-)
tools/testing/selftests/mm/charge_reserved_hugetlb.sh +1 -1
index e1fe16bcbbe8..249a5776c074 100755
@@ -100,7 +100,7 @@ function setup_cgroup() {
    echo writing cgroup limit: "$cgroup_limit"
    echo "$cgroup_limit" >$cgroup_path/$name/hugetlb.${MB}MB.$fault_limit_file
 
-  echo writing reseravation limit: "$reservation_limit"
+  echo writing reservation limit: "$reservation_limit"
    echo "$reservation_limit" > \
      $cgroup_path/$name/hugetlb.${MB}MB.$reservation_limit_file
 

tools/testing/selftests/mm/charge_reserved_hugetlb.sh function setup_cgroup() { · line 120

Quoted 9 lines
tools/testing/selftests/mm/charge_reserved_hugetlb.sh +6 -0
@@ -112,41 +112,46 @@ function setup_cgroup() {
    fi
  }
 
+function wait_for_file_value() {
+  local path="$1"
+  local expect="$2"
+  local max_tries="120"
+
+  local i cur

I would just move "cur" into the loop; I don't see a reason to print it on the error path when you printed the value on the last "Waiting" line?

	local cur="$(cat "$path")"

Also, not sure if you really need the "local i" here.

What if the path does not exist, do we want to catch that earlier and bail out instead of letting "cat" fail here?

tools/testing/selftests/mm/charge_reserved_hugetlb.sh function setup_cgroup() { · line 127

Quoted 7 lines
tools/testing/selftests/mm/charge_reserved_hugetlb.sh +7 -0
+  for ((i=1; i<=max_tries; i++)); do
+    cur="$(cat "$path")"
+    if [[ "$cur" == "$expect" ]]; then
+      return 0
+    fi
+    echo "Waiting for $path to become '$expect' (current: '$cur') (try $i/$max_tries)"
+    sleep 0.5

Any reason we don't go for the more intuitive "wait 1s" - max 60s wait?

tools/testing/selftests/mm/charge_reserved_hugetlb.sh function setup_cgroup() { · line 128

Quoted 1 line
tools/testing/selftests/mm/charge_reserved_hugetlb.sh +1 -0
+  done

Nothing else jumped at me.

Signature · 3 lines
Cheers

David
author
#5 lore raw

Re: [PATCH v2 2/3] selftests/mm/charge_reserved_hugetlb.sh: add waits with timeout helper

Quoted 6 lines · David Hildenbrand (Red Hat)
Quoted 3 lines · Li Wang

The hugetlb cgroup usage wait loops in charge_reserved_hugetlb.sh were unbounded and could hang forever if the expected cgroup file value never appears (e.g. due to bugs, timing issues, or unexpected behavior).

Did you actually hit that in practice? Just wondering.

Yes.

On an aarch64 64k setup with 512MB hugepages, the test failed earlier (hugetlbfs got mounted with an effective size of 0 due to size=256M), so write_to_hugetlbfs couldn’t allocate the expected pages. After that, the script’s wait loops never observed the target value, so they spun forever.

Detail see below logs.

Quoted 75 lines
Quoted 62 lines

--- Error log ---

   # uname -r
   6.12.0-xxx.el10.aarch64+64k
   # ls /sys/kernel/mm/hugepages/hugepages-*
   hugepages-16777216kB/  hugepages-2048kB/  hugepages-524288kB/
   #./charge_reserved_hugetlb.sh -cgroup-v2
   # -----------------------------------------
   ...
   # nr hugepages = 10
   # writing cgroup limit: 5368709120
   # writing reseravation limit: 5368709120
   ...
   # write_to_hugetlbfs: Error mapping the file: Cannot allocate memory
   # Waiting for hugetlb memory reservation to reach size 2684354560.
   # 0
   # Waiting for hugetlb memory reservation to reach size 2684354560.
   # 0
   # Waiting for hugetlb memory reservation to reach size 2684354560.
   # 0
   # Waiting for hugetlb memory reservation to reach size 2684354560.
   # 0
   # Waiting for hugetlb memory reservation to reach size 2684354560.
   # 0
   # Waiting for hugetlb memory reservation to reach size 2684354560.
   # 0
   ...

Introduce a small helper, wait_for_file_value(), and use it for:
- waiting for reservation usage to drop to 0,
- waiting for reservation usage to reach a given size,
- waiting for fault usage to reach a given size.

This makes the waits consistent and adds a hard timeout (120 tries with 0.5s sleep) so the test fails instead of stalling indefinitely.

Cc David Hildenbrand <[email protected]>
Cc Mark Brown <[email protected]>
Cc Shuah Khan <[email protected]>
Cc Waiman Long <[email protected]>
---
  .../selftests/mm/charge_reserved_hugetlb.sh   | 47 ++++++++++---------
  1 file changed, 26 insertions(+), 21 deletions(-)
tools/testing/selftests/mm/charge_reserved_hugetlb.sh +1 -1
index e1fe16bcbbe8..249a5776c074 100755
@@ -100,7 +100,7 @@ function setup_cgroup() {
    echo writing cgroup limit: "$cgroup_limit"
    echo "$cgroup_limit" >$cgroup_path/$name/hugetlb.${MB}MB.$fault_limit_file
 
-  echo writing reseravation limit: "$reservation_limit"
+  echo writing reservation limit: "$reservation_limit"
    echo "$reservation_limit" > \
      $cgroup_path/$name/hugetlb.${MB}MB.$reservation_limit_file
 

tools/testing/selftests/mm/charge_reserved_hugetlb.sh function setup_cgroup() { · line 120

Quoted 9 lines
tools/testing/selftests/mm/charge_reserved_hugetlb.sh +6 -0
@@ -112,41 +112,46 @@ function setup_cgroup() {
    fi
  }
 
+function wait_for_file_value() {
+  local path="$1"
+  local expect="$2"
+  local max_tries="120"
+
+  local i cur

I would just move "cur" into the loop; I don't see a reason to print it on the error path when you printed the value on the last "Waiting" line?

Quoted 1 line
        local cur="$(cat "$path")"

+1

Quoted 5 lines

Also, not sure if you really need the "local i" here.

What if the path does not exist, do we want to catch that earlier and bail out instead of letting "cat" fail here?

Yes, we can add a file check before the "cat" loop.

Quoted 10 lines

tools/testing/selftests/mm/charge_reserved_hugetlb.sh function setup_cgroup() { · line 127

Quoted 8 lines
tools/testing/selftests/mm/charge_reserved_hugetlb.sh +7 -0
+  for ((i=1; i<=max_tries; i++)); do
+    cur="$(cat "$path")"
+    if [[ "$cur" == "$expect" ]]; then
+      return 0
+    fi
+    echo "Waiting for $path to become '$expect' (current: '$cur') (try $i/$max_tries)"
+    sleep 0.5

Any reason we don't go for the more intuitive "wait 1s" - max 60s wait?

Sure, the total loop time are same.

Signature · 2 lines
Regards,
Li Wang
#6 lore raw

Re: [PATCH v2 2/3] selftests/mm/charge_reserved_hugetlb.sh: add waits with timeout helper

Quoted 7 lines · Li Wang
Quoted 5 lines · David Hildenbrand (Red Hat)
Quoted 3 lines · Li Wang

The hugetlb cgroup usage wait loops in charge_reserved_hugetlb.sh were unbounded and could hang forever if the expected cgroup file value never appears (e.g. due to bugs, timing issues, or unexpected behavior).

Quoted 8 lines
Quoted 1 line

Did you actually hit that in practice? Just wondering.

Yes.

On an aarch64 64k setup with 512MB hugepages, the test failed earlier (hugetlbfs got mounted with an effective size of 0 due to size=256M), so write_to_hugetlbfs couldn’t allocate the expected pages. After that, the script’s wait loops never observed the target value, so they spun forever.

Okay, so essentially what you fix in patch #3, correct?

It might make sense to reorder #2 and #3, and likely current #3 should get a Fixes: tag.

Then you can just briefly describe here that this was previously hit due to other tests issues. Although I wonder how much value this patch here as after #3 is in. But it looks like a cleanup and the timeout of 60s sounds reasonable.

I know the reservation of hugetlb folios can take a rather long time in some environments, though.

Signature · 3 lines
Cheers

David
author
#7 lore raw

Re: [PATCH v2 2/3] selftests/mm/charge_reserved_hugetlb.sh: add waits with timeout helper

Quoted 18 lines · David Hildenbrand (Red Hat)
Quoted 7 lines · Li Wang
Quoted 5 lines · David Hildenbrand (Red Hat)
Quoted 3 lines · Li Wang

The hugetlb cgroup usage wait loops in charge_reserved_hugetlb.sh were unbounded and could hang forever if the expected cgroup file value never appears (e.g. due to bugs, timing issues, or unexpected behavior).

Quoted 8 lines
Quoted 1 line

Did you actually hit that in practice? Just wondering.

Yes.

On an aarch64 64k setup with 512MB hugepages, the test failed earlier (hugetlbfs got mounted with an effective size of 0 due to size=256M), so write_to_hugetlbfs couldn’t allocate the expected pages. After that, the script’s wait loops never observed the target value, so they spun forever.

Quoted 4 lines

Okay, so essentially what you fix in patch #3, correct?

It might make sense to reorder #2 and #3, and likely current #3 should get a Fixes: tag.

+1

Quoted 4 lines

Then you can just briefly describe here that this was previously hit due to other tests issues. Although I wonder how much value this patch here as after #3 is in. But it looks like a cleanup and the timeout of 60s sounds reasonable.

The reason is that I improved the infinite loop before debugging the #3 issue. But your suggestion makes sense, and I will reorder patch #2 and #3.

Signature · 2 lines
Regards,
Li Wang
author
#8 lore raw

PATCH v2 3/3 selftests/mm/charge_reserved_hugetlb: fix hugetlbfs mount size for large hugepages

In reply to Li Wang

charge_reserved_hugetlb.sh mounts a hugetlbfs instance at /mnt/huge with a fixed size of 256M. On systems with large base hugepages (e.g. 512MB), this is smaller than a single hugepage, so the hugetlbfs mount ends up with effectively zero capacity (often visible as size=0 in mount output).

As a result, write_to_hugetlbfs fails with ENOMEM and the test can hang waiting for progress.

--- Error log ---

  # uname -r
  6.12.0-xxx.el10.aarch64+64k

#./charge_reserved_hugetlb.sh -cgroup-v2
# -----------------------------------------
...

  # nr hugepages = 10
  # writing cgroup limit: 5368709120
  # writing reseravation limit: 5368709120
  ...
  # write_to_hugetlbfs: Error mapping the file: Cannot allocate memory
  # Waiting for hugetlb memory reservation to reach size 2684354560.
  # 0
  # Waiting for hugetlb memory reservation to reach size 2684354560.
  # 0
  ...
  # mount |grep /mnt/huge
  none on /mnt/huge type hugetlbfs (rw,relatime,seclabel,pagesize=512M,size=0)
  # grep -i huge /proc/meminfo
  ...
  HugePages_Total:      10
  HugePages_Free:       10
  HugePages_Rsvd:        0
  HugePages_Surp:        0
  Hugepagesize:     524288 kB
  Hugetlb:         5242880 kB

Mount hugetlbfs with size=${size}, the number of bytes the test will reserve/write, so the filesystem capacity is sufficient regardless of HugeTLB page size.

Cc David Hildenbrand <[email protected]>
Cc Mark Brown <[email protected]>
Cc Shuah Khan <[email protected]>
Cc Waiman Long <[email protected]>
---
 tools/testing/selftests/mm/charge_reserved_hugetlb.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/mm/charge_reserved_hugetlb.sh +2 -2
index 249a5776c074..ac2744dbc0bd 100755
@@ -295,7 +295,7 @@ function run_test() {
   setup_cgroup "hugetlb_cgroup_test" "$cgroup_limit" "$reservation_limit"
 
   mkdir -p /mnt/huge
-  mount -t hugetlbfs -o pagesize=${MB}M,size=256M none /mnt/huge
+  mount -t hugetlbfs -o pagesize=${MB}M,size=${size} none /mnt/huge
 
   write_hugetlbfs_and_get_usage "hugetlb_cgroup_test" "$size" "$populate" \
     "$write" "/mnt/huge/test" "$method" "$private" "$expect_failure" \
@@ -349,7 +349,7 @@ function run_multiple_cgroup_test() {
   setup_cgroup "hugetlb_cgroup_test2" "$cgroup_limit2" "$reservation_limit2"
 
   mkdir -p /mnt/huge
-  mount -t hugetlbfs -o pagesize=${MB}M,size=256M none /mnt/huge
+  mount -t hugetlbfs -o pagesize=${MB}M,size=${size} none /mnt/huge
 
   write_hugetlbfs_and_get_usage "hugetlb_cgroup_test1" "$size1" \
     "$populate1" "$write1" "/mnt/huge/test1" "$method" "$private" \
Signature · 1 line
2.49.0
#9 lore raw

Re: [PATCH v2 3/3] selftests/mm/charge_reserved_hugetlb: fix hugetlbfs mount size for large hugepages

Quoted 7 lines · Li Wang

charge_reserved_hugetlb.sh mounts a hugetlbfs instance at /mnt/huge with a fixed size of 256M. On systems with large base hugepages (e.g. 512MB), this is smaller than a single hugepage, so the hugetlbfs mount ends up with effectively zero capacity (often visible as size=0 in mount output).

As a result, write_to_hugetlbfs fails with ENOMEM and the test can hang waiting for progress.

I'm curious, what's the history of using "256MB" in the first place (or specifying any size?).

Signature · 3 lines
Cheers

David
author
#10 lore raw

Re: [PATCH v2 3/3] selftests/mm/charge_reserved_hugetlb: fix hugetlbfs mount size for large hugepages

Quoted 11 lines · David Hildenbrand (Red Hat)
Quoted 7 lines · Li Wang

charge_reserved_hugetlb.sh mounts a hugetlbfs instance at /mnt/huge with a fixed size of 256M. On systems with large base hugepages (e.g. 512MB), this is smaller than a single hugepage, so the hugetlbfs mount ends up with effectively zero capacity (often visible as size=0 in mount output).

As a result, write_to_hugetlbfs fails with ENOMEM and the test can hang waiting for progress.

I'm curious, what's the history of using "256MB" in the first place (or specifying any size?).

Seems the script initializes it with "256MB" from:

commit 29750f71a9b4cfae57cdddfbd8ca287eddca5503

Author: Mina Almasry <[email protected]>
Date:   Wed Apr 1 21:11:38 2020 -0700

hugetlb_cgroup: add hugetlb_cgroup reservation tests

Signature · 2 lines
Regards,
Li Wang
#11 lore raw

Re: [PATCH v2 3/3] selftests/mm/charge_reserved_hugetlb: fix hugetlbfs mount size for large hugepages

Quoted 13 lines · Li Wang
Quoted 11 lines · David Hildenbrand (Red Hat)
Quoted 7 lines · Li Wang

charge_reserved_hugetlb.sh mounts a hugetlbfs instance at /mnt/huge with a fixed size of 256M. On systems with large base hugepages (e.g. 512MB), this is smaller than a single hugepage, so the hugetlbfs mount ends up with effectively zero capacity (often visible as size=0 in mount output).

As a result, write_to_hugetlbfs fails with ENOMEM and the test can hang waiting for progress.

I'm curious, what's the history of using "256MB" in the first place (or specifying any size?).

Quoted 7 lines

Seems the script initializes it with "256MB" from:

commit 29750f71a9b4cfae57cdddfbd8ca287eddca5503

Author: Mina Almasry <[email protected]>
Date:   Wed Apr 1 21:11:38 2020 -0700

hugetlb_cgroup: add hugetlb_cgroup reservation tests

What would happen if we don't specify a size at all?

Signature · 3 lines
Cheers

David
author
#12 lore raw

Re: [PATCH v2 3/3] selftests/mm/charge_reserved_hugetlb: fix hugetlbfs mount size for large hugepages

Quoted 17 lines · David Hildenbrand (Red Hat)
Quoted 15 lines · Li Wang
Quoted 11 lines · David Hildenbrand (Red Hat)
Quoted 7 lines · Li Wang

charge_reserved_hugetlb.sh mounts a hugetlbfs instance at /mnt/huge with a fixed size of 256M. On systems with large base hugepages (e.g. 512MB), this is smaller than a single hugepage, so the hugetlbfs mount ends up with effectively zero capacity (often visible as size=0 in mount output).

As a result, write_to_hugetlbfs fails with ENOMEM and the test can hang waiting for progress.

I'm curious, what's the history of using "256MB" in the first place (or specifying any size?).

Seems the script initializes it with "256MB" from:

Quoted 7 lines
Quoted 5 lines

commit 29750f71a9b4cfae57cdddfbd8ca287eddca5503

Author: Mina Almasry <[email protected]>
Date:   Wed Apr 1 21:11:38 2020 -0700

hugetlb_cgroup: add hugetlb_cgroup reservation tests

What would happen if we don't specify a size at all?

It still works well, I have gone through the whole file and there is no subtest that relies on the 256M capability.

So we could just:

    mount -t hugetlbfs -o pagesize=${MB}M none /mnt/huge
Signature · 2 lines
Regards,
Li Wang