Skip to contentSkip to conversation

soundwire: intel_ace2x: add SND_HDA_CORE dependency

PATCH Applied Arnd Bergmann 2 participants 2 messages Dec 23, 2025 – Dec 24, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soundwire: intel_ace2x: add SND_HDA_CORE dependency

From: Arnd Bergmann <[email protected]>

The ace2x driver can optionally use the HDA infrastructure, but can still build without that. However, with SND_HDA_CORE=m and SND_HDA_ALIGNED_MMIO=y, it fails to link as built-in:

aarch64-linux-ld: drivers/soundwire/intel_ace2x.o: in function `intel_shim_wake':
intel_ace2x.c:(.text+0x2518): undefined reference to `snd_hdac_aligned_read'
aarch64-linux-ld: intel_ace2x.c:(.text+0x25d4): undefined reference to `snd_hdac_aligned_read'
aarch64-linux-ld: intel_ace2x.c:(.text+0x268c): undefined reference to `snd_hdac_aligned_write'

Add a Kconfig dependency that forces the soundwire driver to be a loadable module if necessary.

Fixes 79e7123c078d ("soundwire: intel_ace2x: fix wakeup handling")

---
I saw this build failure only once, but don't know if this is a recent regression or was originally caused by the 79e7123c078d commit.

---
 drivers/soundwire/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/soundwire/Kconfig +1 -0
index ad56393e4c93..196a7daaabdb 100644
@@ -40,6 +40,7 @@ config SOUNDWIRE_INTEL
 	select AUXILIARY_BUS
 	depends on ACPI && SND_SOC
 	depends on SND_SOC_SOF_HDA_MLINK || !SND_SOC_SOF_HDA_MLINK
+	depends on SND_HDA_CORE || !SND_HDA_ALIGNED_MMIO
 	help
 	  SoundWire Intel Master driver.
 	  If you have an Intel platform which has a SoundWire Master then
Signature · 1 line
2.39.5
maintainer Applied
#1 lore raw
Quoted 10 lines · Arnd Bergmann

The ace2x driver can optionally use the HDA infrastructure, but can still build without that. However, with SND_HDA_CORE=m and SND_HDA_ALIGNED_MMIO=y, it fails to link as built-in:

aarch64-linux-ld: drivers/soundwire/intel_ace2x.o: in function `intel_shim_wake':
intel_ace2x.c:(.text+0x2518): undefined reference to `snd_hdac_aligned_read'
aarch64-linux-ld: intel_ace2x.c:(.text+0x25d4): undefined reference to `snd_hdac_aligned_read'
aarch64-linux-ld: intel_ace2x.c:(.text+0x268c): undefined reference to `snd_hdac_aligned_write'

[...]

Applied, thanks!

[1/1] soundwire: intel_ace2x: add SND_HDA_CORE dependency

      commit: dddbe80536f3676b9b14a034058c81a1798fe374

Best regards,

Signature · 1 line
~Vinod