Skip to contentSkip to conversation

mm/damon/core: get memcg reference before access

PATCH Applied Shakeel Butt 2 participants 2 messages Dec 25, 2025

Subsystems (3)
Memory management cgroup DAMON
lore
Share & tools
lore

Shakeel Butt

author
#0 lore raw

PATCH v2 1/1 mm/damon/core: get memcg reference before access

The commit b74a120bcf507 ("mm/damon/core: implement DAMOS_QUOTA_NODE_MEMCG_USED_BP") added accesses to memcg structure without getting reference to it. This is unsafe. Let's get the reference before accessing the memcg.

Fixes b74a120bcf507 ("mm/damon/core: implement DAMOS_QUOTA_NODE_MEMCG_USED_BP")
Signed-off-by Shakeel Butt <[email protected]>
Reviewed-by SeongJae Park <[email protected]>

---
Changes since v1:
- Changed the subject as requested by SJ.

 mm/damon/core.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
mm/damon/core.c +6 -2
index 4ad5f290d382..89982e0229f0 100644
@@ -2051,13 +2051,15 @@ static unsigned long damos_get_node_memcg_used_bp(
 
 	rcu_read_lock();
 	memcg = mem_cgroup_from_id(goal->memcg_id);
-	rcu_read_unlock();
-	if (!memcg) {
+	if (!memcg || !mem_cgroup_tryget(memcg)) {
+		rcu_read_unlock();
 		if (goal->metric == DAMOS_QUOTA_NODE_MEMCG_USED_BP)
 			return 0;
 		else	/* DAMOS_QUOTA_NODE_MEMCG_FREE_BP */
 			return 10000;
 	}
+	rcu_read_unlock();
+
 	mem_cgroup_flush_stats(memcg);
 	lruvec = mem_cgroup_lruvec(memcg, NODE_DATA(goal->nid));
 	used_pages = lruvec_page_state(lruvec, NR_ACTIVE_ANON);

@@ -2065,6 +2067,8 @@ static unsigned long damos_get_node_memcg_used_bp(
 	used_pages += lruvec_page_state(lruvec, NR_ACTIVE_FILE);
 	used_pages += lruvec_page_state(lruvec, NR_INACTIVE_FILE);
 
+	mem_cgroup_put(memcg);
+
 	si_meminfo_node(&i, goal->nid);
 	if (goal->metric == DAMOS_QUOTA_NODE_MEMCG_USED_BP)
 		numerator = used_pages;
Signature · 1 line
2.47.3
maintainer
#1 lore raw
Quoted 11 lines · On Wed, 24 Dec 2025 16:29:04 -0800 Shakeel Butt <[email protected]> wrote:

The commit b74a120bcf507 ("mm/damon/core: implement DAMOS_QUOTA_NODE_MEMCG_USED_BP") added accesses to memcg structure without getting reference to it. This is unsafe. Let's get the reference before accessing the memcg.

Fixes b74a120bcf507 ("mm/damon/core: implement DAMOS_QUOTA_NODE_MEMCG_USED_BP")
Signed-off-by Shakeel Butt <[email protected]>
Reviewed-by SeongJae Park <[email protected]>

---
Changes since v1:
- Changed the subject as requested by SJ.

Thank you, Shakeel!

Thanks,
SJ

[...]