dt-bindings: vendor-prefixes: Document ifm electronic gmbh
Subsystems (2)
PATCH v4 1/4 dt-bindings: vendor-prefixes: Document ifm electronic gmbh
ifm is a manufacturer of industrial sensors, control technology and automation solutions. Document their vendor prefix, which is already used for ifm,ac14xx and other powerpc devices.
---
Cc: Christian Eggers <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Markus Heidelberg <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V2: Add AB from Rob
V3: No change
V4: No change
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -755,6 +755,8 @@ patternProperties: description: IEI Integration Corp. "^ifi,.*": description: Ingenieurburo Fur Ic-Technologie (I/F/I) + "^ifm,.*": + description: ifm electronic gmbh "^ilitek,.*": description: ILI Technology Corporation (ILITEK) "^imagis,.*":
Signature · 1 line
2.51.0
PATCH v4 2/4 dt-bindings: arm: fsl: Document ifm VHIP4 EvalBoard v1 and v2
Document ifm i.MX8MN VHIP4 EvalBoard v1 and v2 reference design binding. This system exists in two generations, v1 and v2, which share a lot of commonality. The boards come with either single gigabit ethernet or an KSZ8794 fast-ethernet switch, boot from eMMC, and offer CAN interfaces via Microchip MCP25xx SPI CAN controllers, UART, and USB host. The GPU is not available in the SoC populated on these devices.
---
Cc: Christian Eggers <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Markus Heidelberg <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V2: Add AB from Rob
V3: No change
V4: No change
--- Documentation/devicetree/bindings/arm/fsl.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +9 -0
@@ -1071,6 +1071,15 @@ properties: - gw,imx8mn-gw7902 # i.MX8MM Gateworks Board - const: fsl,imx8mn + - description: ifm i.MX8MN VHIP4 based boards + items: + - enum: + - ifm,imx8mn-vhip4-evalboard-v1 + - ifm,imx8mn-vhip4-evalboard-v2 + - const: ifm,imx8mn-vhip4-evalboard + - const: ifm,imx8mn-vhip4 + - const: fsl,imx8mn + - description: Variscite VAR-SOM-MX8MN based boards items: - enum:
Signature · 1 line
2.51.0
PATCH v4 3/4 arm64: dts: imx8mn: Add SNVS LPGPR
In reply to Marek VasutAdd SNVS LPGPR bindings to MX8M Nano, the LPGPR is used to store boot counter.
---
Cc: Christian Eggers <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Markus Heidelberg <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V2: New patch
V3: No change
V4: No change
--- arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/freescale/imx8mn.dtsi +5 -0
@@ -628,6 +628,11 @@ snvs_pwrkey: snvs-powerkey { wakeup-source; status = "disabled"; }; + + snvs_lpgpr: snvs-lpgpr { + compatible = "fsl,imx8mn-snvs-lpgpr", + "fsl,imx7d-snvs-lpgpr"; + }; }; clk: clock-controller@30380000 {
Signature · 1 line
2.51.0
Re: [PATCH v4 3/4] arm64: dts: imx8mn: Add SNVS LPGPR
Quoted 4 lines · Marek Vasut
Add SNVS LPGPR bindings to MX8M Nano, the LPGPR is used to store boot counter.
Signed-off-by Marek Vasut <[email protected]>
PATCH v4 4/4 arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard v1 and v2
In reply to Marek VasutFrom: Fedor Ross <[email protected]>
Add support for ifm i.MX8MN VHIP4 EvalBoard v1 and v2 reference design. This system exists in two generations, v1 and v2, which share a lot of commonality. The boards come with either single gigabit ethernet or an KSZ8794 fast-ethernet switch, boot from eMMC, and offer CAN interfaces via Microchip MCP25xx SPI CAN controllers, UART, and USB host. The GPU is not available in the SoC populated on these devices.
---
Cc: Christian Eggers <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Markus Heidelberg <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V2: - Drop snvs-lpgpr node in favor of separate patch to imx8mn.dtsi
- Sort properties and update newlines according to V1 feedback
V3: - Drop fsl,magic-packet
V4: - Switch USB hub to compatible = "usb424,2512", "usb424,2514"
- Use temperature-sensor@48 for temperature sensor node names
- Sort pinctrl_gpio_5 iomux node
--- arch/arm64/boot/dts/freescale/Makefile | 19 + .../imx8mn-vhip4-evalboard-common.dtsi | 398 ++++++++++++++++++ ...imx8mn-vhip4-evalboard-ksz8794-common.dtsi | 98 +++++ ...mn-vhip4-evalboard-v1-overlay-ksz8794.dtso | 24 ++ ...mn-vhip4-evalboard-v1-overlay-ksz9031.dtso | 48 +++ .../freescale/imx8mn-vhip4-evalboard-v1.dts | 258 ++++++++++++ ...n-vhip4-evalboard-v2-overlay-adin1300.dtso | 60 +++ ...mn-vhip4-evalboard-v2-overlay-ksz8794.dtso | 24 ++ .../freescale/imx8mn-vhip4-evalboard-v2.dts | 221 ++++++++++ 9 files changed, 1150 insertions(+) create mode 100644 arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-common.dtsi create mode 100644 arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-ksz8794-common.dtsi create mode 100644 arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-v1-overlay-ksz8794.dtso create mode 100644 arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-v1-overlay-ksz9031.dtso create mode 100644 arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-v1.dts create mode 100644 arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-v2-overlay-adin1300.dtso create mode 100644 arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-v2-overlay-ksz8794.dtso create mode 100644 arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-v2.dts
arch/arm64/boot/dts/freescale/Makefile +19 -0
@@ -191,6 +191,25 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mn-tqma8mqnl-mba8mx.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mn-var-som-symphony.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mn-venice-gw7902.dtb +imx8mn-vhip4-evalboard-v1-overlay-ksz8794-dtbs := imx8mn-vhip4-evalboard-v1.dtb \ + imx8mn-vhip4-evalboard-v1-overlay-ksz8794.dtbo +imx8mn-vhip4-evalboard-v1-overlay-ksz9031-dtbs := imx8mn-vhip4-evalboard-v1.dtb \ + imx8mn-vhip4-evalboard-v1-overlay-ksz9031.dtbo +imx8mn-vhip4-evalboard-v2-overlay-ksz8794-dtbs := imx8mn-vhip4-evalboard-v2.dtb \ + imx8mn-vhip4-evalboard-v2-overlay-ksz8794.dtbo +imx8mn-vhip4-evalboard-v2-overlay-adin1300-dtbs := imx8mn-vhip4-evalboard-v2.dtb \ + imx8mn-vhip4-evalboard-v2-overlay-adin1300.dtbo +dtb-$(CONFIG_ARCH_MXC) += imx8mn-vhip4-evalboard-v1.dtb \ + imx8mn-vhip4-evalboard-v1-overlay-ksz8794.dtb \ + imx8mn-vhip4-evalboard-v1-overlay-ksz8794.dtbo \ + imx8mn-vhip4-evalboard-v1-overlay-ksz9031.dtb \ + imx8mn-vhip4-evalboard-v1-overlay-ksz9031.dtbo \ + imx8mn-vhip4-evalboard-v2.dtb \ + imx8mn-vhip4-evalboard-v2-overlay-adin1300.dtb \ + imx8mn-vhip4-evalboard-v2-overlay-adin1300.dtbo \ + imx8mn-vhip4-evalboard-v2-overlay-ksz8794.dtb \ + imx8mn-vhip4-evalboard-v2-overlay-ksz8794.dtbo + imx8mn-tqma8mqnl-mba8mx-lvds-tm070jvhg33-dtbs += imx8mn-tqma8mqnl-mba8mx.dtb imx8mn-tqma8mqnl-mba8mx-lvds-tm070jvhg33.dtbo imx8mn-tqma8mqnl-mba8mx-usbotg-dtbs += imx8mn-tqma8mqnl-mba8mx.dtb imx8mn-tqma8mqnl-mba8mx-usbotg.dtbo dtb-$(CONFIG_ARCH_MXC) += imx8mn-tqma8mqnl-mba8mx-lvds-tm070jvhg33.dtb
arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-common.dtsi new file +398 -0
398 lines not on this page · raw message
arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-ksz8794-common.dtsi new file +98 -0
98 lines not on this page · raw message
arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-v1-overlay-ksz8794.dtso new file +24 -0
@@ -0,0 +1,24 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (C) 2021 Marek Vasut + */ +/dts-v1/; +/plugin/; + +#include <dt-bindings/gpio/gpio.h> + +#include "imx8mn-pinfunc.h" + +&pinctrl_ecspi1 { + fsl,pins = < + MX8MN_IOMUXC_ECSPI1_SCLK_ECSPI1_SCLK 0x10 + MX8MN_IOMUXC_ECSPI1_MOSI_ECSPI1_MOSI 0x10 + MX8MN_IOMUXC_ECSPI1_MISO_ECSPI1_MISO 0x90 + /* KS8794 nCS */ + MX8MN_IOMUXC_I2C4_SDA_GPIO5_IO21 0x150 + /* ANV32C81 nCS */ + MX8MN_IOMUXC_ECSPI1_SS0_GPIO5_IO9 0x150 + >; +}; + +#include "imx8mn-vhip4-evalboard-ksz8794-common.dtsi"
arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-v1-overlay-ksz9031.dtso new file +48 -0
48 lines not on this page · raw message
arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-v1.dts new file +258 -0
258 lines not on this page · raw message
arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-v2-overlay-adin1300.dtso new file +60 -0
60 lines not on this page · raw message
arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-v2-overlay-ksz8794.dtso new file +24 -0
@@ -0,0 +1,24 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (C) 2021 Marek Vasut + */ +/dts-v1/; +/plugin/; + +#include <dt-bindings/gpio/gpio.h> + +#include "imx8mn-pinfunc.h" + +&pinctrl_ecspi1 { + fsl,pins = < + MX8MN_IOMUXC_ECSPI1_SCLK_ECSPI1_SCLK 0x10 + MX8MN_IOMUXC_ECSPI1_MOSI_ECSPI1_MOSI 0x10 + MX8MN_IOMUXC_ECSPI1_MISO_ECSPI1_MISO 0x90 + /* KS8794 nCS */ + MX8MN_IOMUXC_GPIO1_IO11_GPIO1_IO11 0x150 + /* ANV32C81 nCS */ + MX8MN_IOMUXC_ECSPI1_SS0_GPIO5_IO9 0x150 + >; +}; + +#include "imx8mn-vhip4-evalboard-ksz8794-common.dtsi"
arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-v2.dts new file +221 -0
221 lines not on this page · raw message
Signature · 1 line
2.51.0
Re: [PATCH v4 4/4] arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard v1 and v2
Hi Marek,
Sorry for jumping in at V4.
Quoted 2 lines · Marek Vasut
From: Fedor Ross <[email protected]>
...
arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-common.dtsi line 123
Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-common.dtsi new file +5
-0+ +&ecspi1 { + pinctrl-names = "default", "cs"; + pinctrl-0 = <&pinctrl_ecspi1>; + pinctrl-1 = <&pinctrl_ecspi1_cs>;
Not get the point of using a separate pinctrl for "cs", I not see driver using it, or I may miss someting.
Review
Quoted 2 lines
(quoted diff) +2
-0+ /delete-property/ dmas; + /delete-property/ dma-names;
Why disable DMA here?
arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-common.dtsi line 133
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-common.dtsi new file +8
-0+}; + +&ecspi3 { + pinctrl-names = "default", "cs"; + pinctrl-0 = <&pinctrl_ecspi3>; + pinctrl-1 = <&pinctrl_ecspi3_cs>; + /delete-property/ dmas; + /delete-property/ dma-names;
Ditto.
Review
Quoted 2 lines
(quoted diff) +2
-0+}; +
Regards
Peng
Re: [PATCH v4 4/4] arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard v1 and v2
On 1/6/26 3:37 PM, Peng Fan wrote:
Hello Peng,
Quoted 1 line
Sorry for jumping in at V4.
Thank you for the review.
Quoted 5 lines · Marek Vasut
Quoted 2 lines
From: Fedor Ross <[email protected]>
...
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-common.dtsi line 123
Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mn-vhip4-evalboard-common.dtsi new file +5
-0+ +&ecspi1 { + pinctrl-names = "default", "cs"; + pinctrl-0 = <&pinctrl_ecspi1>; + pinctrl-1 = <&pinctrl_ecspi1_cs>;Not get the point of using a separate pinctrl for "cs", I not see driver using it, or I may miss someting.
That's a good find, I believe it should be this way, because the pinctrl_ecspi1 is common and pinctrl_ecspi1_cs differs between v1 and v2 boards. I'll include this in V5, I hope that looks better ?
&ecspi1 {
- pinctrl-names = "default", "cs";
- pinctrl-0 = <&pinctrl_ecspi1>;
- pinctrl-1 = <&pinctrl_ecspi1_cs>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ecspi1>, <&pinctrl_ecspi1_cs>;
/delete-property/ dmas;
/delete-property/ dma-names;
};
&ecspi3 {
- pinctrl-names = "default", "cs";
- pinctrl-0 = <&pinctrl_ecspi3>;
- pinctrl-1 = <&pinctrl_ecspi3_cs>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ecspi3>, <&pinctrl_ecspi3_cs>;
/delete-property/ dmas;
/delete-property/ dma-names;
};
Quoted 4 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ /delete-property/ dmas; + /delete-property/ dma-names;Why disable DMA here?
The devices on this SPI bus are slow and do only short register IO, so setting up a DMA for that would make the register IO slower, hence PIO only.