Skip to contentSkip to conversation

selftests/bpf: veristat: fix printing order in output_stats()

PATCH Applied Puranjay Mohan 2 participants 2 messages Dec 31, 2025 – Jan 1

Subsystems (3)
Kselftest BPF BPF selftests
lore
Share & tools
lore

Puranjay Mohan

author
#0 lore raw

PATCH v2 1/1 selftests/bpf: veristat: fix printing order in output_stats()

The order of the variables in the printf() doesn't match the text and therefore veristat prints something like this:

Done. Processed 24 files, 0 programs. Skipped 62 files, 0 programs.

When it should print:

Done. Processed 24 files, 62 programs. Skipped 0 files, 0 programs.

Fix the order of variables in the printf() call.

Fixes 518fee8bfaf2 ("selftests/bpf: make veristat skip non-BPF and failing-to-open BPF objects")
Tested-by Eduard Zingerman <[email protected]>
Signed-off-by Puranjay Mohan <[email protected]>

---
v1: https://lore.kernel.org/all/[email protected]/
Changes in v1->v2:
- Fix typo in commit message.
- Add fixes tag.

---
 tools/testing/selftests/bpf/veristat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/veristat.c +1 -1
index e962f133250c..1be1e353d40a 100644
@@ -2580,7 +2580,7 @@ static void output_stats(const struct verif_stats *s, enum resfmt fmt, bool last
 	if (last && fmt == RESFMT_TABLE) {
 		output_header_underlines();
 		printf("Done. Processed %d files, %d programs. Skipped %d files, %d programs.\n",
-		       env.files_processed, env.files_skipped, env.progs_processed, env.progs_skipped);
+		       env.files_processed, env.progs_processed, env.files_skipped, env.progs_skipped);
 	}
 }

base-commit: 17c736a7b58a18e3683df2583b60f0edeaf65070

Signature · 1 line
2.47.3
CI Applied
#1 lore raw
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Quoted 8 lines · On Wed, 31 Dec 2025 14:10:50 -0800 you wrote:

The order of the variables in the printf() doesn't match the text and therefore veristat prints something like this:

Done. Processed 24 files, 0 programs. Skipped 62 files, 0 programs.

When it should print:

[...]

Here is the summary with links:
- [bpf-next,v2] selftests/bpf: veristat: fix printing order in output_stats()

    https://git.kernel.org/bpf/bpf-next/c/c286e7e9d1f1

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html