Skip to contentSkip to conversation

5.15.y, 5.10.y: media: uvcvideo: please backport 5b9c75c794ce

REGRESSION Applied Naoki Matsumoto 3 participants 4 messages Nov 17 – Nov 19

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi

I use a UVC device of USB3 at v5.15.y. I found the frame rate down with the below message after updating stable version.

uvcvideo 2-3:1.3: UVC non compliance: the max payload transmission size (1729) exceeds the size of the ep max packet (1024). Using the max size.

This message is from by eb6059474e70 ("media: uvcvideo: Fix bandwidth issue for Alcor camera").

    5.15.190: eb6059474e70
    5.10.241: 3eaf16ff8165

kernel-5.15 supports usb3 of course. This problem is stream->maxpsize is not support usb3. Since this function parses it directly, USB 3 support seems to have been overlooked. I found the patch at v5.19

Please apply 5b9c75c794ce ("media: uvcvideo: Undup use uvc_endpoint_max_bpi() code") to 5.15.y and 5.10.y.

I confirmed that it cherry-picks cleanly and fixes the problem on 5.15.

#regzbot introduced: eb6059474e70

Thank you,
Naoki Matsumoto

#1 lore raw

Hi Naoki

Quoted 15 lines · Naoki Matsumoto

Hi

I use a UVC device of USB3 at v5.15.y. I found the frame rate down with the below message after updating stable version.

uvcvideo 2-3:1.3: UVC non compliance: the max payload transmission size (1729) exceeds the size of the ep max packet (1024). Using the max size.

This message is from by eb6059474e70 ("media: uvcvideo: Fix bandwidth issue for Alcor camera").

    5.15.190: eb6059474e70
    5.10.241: 3eaf16ff8165
Quoted 8 lines

kernel-5.15 supports usb3 of course. This problem is stream->maxpsize is not support usb3. Since this function parses it directly, USB 3 support seems to have been overlooked. I found the patch at v5.19

Please apply 5b9c75c794ce ("media: uvcvideo: Undup use uvc_endpoint_max_bpi() code") to 5.15.y and 5.10.y.

I confirmed that it cherry-picks cleanly and fixes the problem on 5.15.

Thanks a lot for your email. I believe I already asked stable to cherry-pick this
https://lore.kernel.org/stable/[email protected]/

Sasha, Greg, could you check what happened?

Thanks!

Quoted 6 lines

#regzbot introduced: eb6059474e70

Thank you,
Naoki Matsumoto

Signature · 1 line
Ricardo Ribalda
maintainer Applied
#3 lore raw
In reply to Naoki Matsumoto
Quoted 2 lines

I use a UVC device of USB3 at v5.15.y. I found the frame rate down with the below message after updating stable version.

Queued for 5.15 and 5.10, thanks.

Signature · 2 lines
Thanks,
Sasha