Skip to contentSkip to conversation

libdvbv5: modify T2 delivery system descriptor

PATCH Superseded Martin Vallevand 2 participants 2 messages Jan 1 – Jan 2 Media (V4L/DVB)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libdvbv5: modify T2 delivery system descriptor

ETSI EN 300 468 6.4.4.3 defines frequency_loop_length as length in bytes when used. libdvbv5 redefines it to be the count of centre frequencies. This patch converts to the count with proper display and avoids memory corruption and buffer overflows.

Of note the count is defined in the spec as 2-6 centre frequencies but more are possible.

---
 lib/libdvbv5/descriptors/desc_t2_delivery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/libdvbv5/descriptors/desc_t2_delivery.c +1 -1
index f88718d35..5d245cc97 100644
@@ -76,7 +76,7 @@ int dvb_desc_t2_delivery_init(struct dvb_v5_fe_parms *parms,
 		p += sizeof(uint16_t);
 
 		if (d->tfs_flag) {
-			d->cell[d->num_cell].num_freqs = *p;
+			d->cell[d->num_cell].num_freqs = *p / sizeof(*d->centre_frequency);
 			p++;
 		}
 		else

--
2.50.1.windows.1

#1 lore raw

I have received the attached and I don't have a clue what it means. If anyone can help please let me know.

Patchwork Integration <[email protected]>

6:30 PM (38 minutes ago)

to me
Dear Martin Vallevand:

Thanks for your patches! Unfortunately the Media CI robot has not been able to test them.

Make sure that the whole series [email protected] is available at lore. And that it can be cherry-picked on top the "next" branch of "https://gitlab.freedesktop.org/linux-media/media-committers.git".

You can try something like this:
git fetch
https://gitlab.freedesktop.org/linux-media/media-committers.git next
git checkout FETCH_HEAD
b4 shazam [email protected]

Error message:
Trying branch next b70886ff5833cf499e77af77d2324ce8f68b60ce... Running in OFFLINE mode
Analyzing 1 messages in the thread
Checking attestation on all messages, may take a moment...
---
[PATCH] libdvbv5: modify T2 delivery system descriptor
+ Link:
https://lore.kernel.org/r/[email protected]
---
Total patches: 1
---
Applying: libdvbv5: modify T2 delivery system descriptor
Patch failed at 0001 libdvbv5: modify T2 delivery system descriptor When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
error: lib/libdvbv5/descriptors/desc_t2_delivery.c: does not exist in index
hint: Use 'git am --show-current-patch=diff' to see the failed patch

Trying branch fixes 27afd6e066cfd80ddbe22a4a11b99174ac89cced... Running in OFFLINE mode
Analyzing 1 messages in the thread
Checking attestation on all messages, may take a moment...
---
[PATCH] libdvbv5: modify T2 delivery system descriptor
+ Link:
https://lore.kernel.org/r/[email protected]
---
Total patches: 1
---
Applying: libdvbv5: modify T2 delivery system descriptor
Patch failed at 0001 libdvbv5: modify T2 delivery system descriptor When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
error: lib/libdvbv5/descriptors/desc_t2_delivery.c: does not exist in index
hint: Use 'git am --show-current-patch=diff' to see the failed patch

Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.

---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html

If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message.