Skip to contentSkip to conversation

package/igt-gpu-tools: depends on little endian

PATCH In review Bernd Kuhls 2 participants 2 messages Jan 2 – Feb 3

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/igt-gpu-tools: depends on little endian

Buildroot commit f9a91bf60e35617157b950eea05fc6f6144d650c bumped igt-gpu- tools to 2.3 including upstream commit
https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/commit/b542242f5b116e3b554b4068ef5dfa4451075b2b
which limits the package to little endian archs causing build errors on big endian archs:

In file included from ../lib/igt_panthor.c:5:
../lib/igt_panthor.h:61:2: error: #error "big endian not supported"
61 | #error "big endian not supported"

Fixes:
https://autobuild.buildroot.org/results/e3faeba1bff3d0e781032ddc9a760f34a9bf5714/

---
 package/igt-gpu-tools/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)
package/igt-gpu-tools/Config.in +6 -0
index 184acb4cf1..87268969a1 100644
@@ -1,5 +1,10 @@
+config BR2_PACKAGE_IGT_GPU_TOOLS_ARCH_SUPPORTS
+	bool
+	default y if BR2_ENDIAN = "LITTLE"
+
 config BR2_PACKAGE_IGT_GPU_TOOLS
 	bool "igt-gpu-tools"
+	depends on BR2_PACKAGE_IGT_GPU_TOOLS_ARCH_SUPPORTS
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_ENABLE_LOCALE
 	depends on !BR2_STATIC_LIBS
@@ -35,6 +40,7 @@ config BR2_PACKAGE_IGT_GPU_TOOLS_TESTS
 endif
 
 comment "igt-gpu-tools needs udev /dev management and toolchain w/ NPTL, wchar, dynamic library, locale, headers >= 4.11"
+	depends on BR2_PACKAGE_IGT_GPU_TOOLS_ARCH_SUPPORTS
 	depends on BR2_USE_MMU
 	depends on !BR2_PACKAGE_HAS_UDEV || BR2_STATIC_LIBS || \
 		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_USE_WCHAR || \
Signature · 6 lines
2.47.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello Bernd,

Thanks for the patch!

Quoted 3 lines · Bernd Kuhls

Buildroot commit f9a91bf60e35617157b950eea05fc6f6144d650c bumped igt-gpu- tools to 2.3 including upstream commit
https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/commit/b542242f5b116e3b554b4068ef5dfa4451075b2b

This wasn't the commit introducing the problematic change, so I've fixed that up with the correct commit, and applied.

However, I've also filed an issue an upstream, because it looks quite intentional that this change adding Panthor tests prevents the whole project from building on big endian architectures:

https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/200

Best regards,

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot