Skip to contentSkip to conversation

dt-bindings: crypto: eip93: add clock gate and reset line

PATCH In review Aleksander Jan Bajkowski 3 participants 7 messages Jan 2 – Jan 12

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/3 dt-bindings: crypto: eip93: add clock gate and reset line

Add the clock gate and reset line, both of which are available on the Airoha AN7581.

---
v3:
- introduce patch

---
 .../crypto/inside-secure,safexcel-eip93.yaml       | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml +14 -0
index 997bf9717f9e..c6c99c08dc68 100644
@@ -48,20 +48,34 @@ properties:
   interrupts:
     maxItems: 1
 
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
 required:
   - compatible
   - reg
   - interrupts
+  - clocks
+  - resets
 
 additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/en7523-clk.h>
     #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/reset/airoha,en7581-reset.h>
 
     crypto@1e004000 {
       compatible = "airoha,en7581-eip93", "inside-secure,safexcel-eip93ies";
       reg = <0x1fb70000 0x1000>;
 
+      clocks = <&scuclk EN7523_CLK_CRYPTO>;
+
       interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+
+      resets = <&scuclk EN7581_CRYPTO_RST>;
     };
Signature · 1 line
2.47.3
#1 lore raw

PATCH v3 2/3 dt-bindings: crypto: eip93: add support for Mediatek MT7621 SoC

Add compatible for Mediatek MT7621 SoC. The implementation is exactly the same os in the Airoha SoC.

---
v3:
- Use enum
v2:
- Corrected commit description

---
 .../bindings/crypto/inside-secure,safexcel-eip93.yaml         | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml +3 -1
index c6c99c08dc68..acd7c68178dc 100644
@@ -31,7 +31,9 @@ properties:
   compatible:
     oneOf:
       - items:
-          - const: airoha,en7581-eip93
+          - enum:
+            - airoha,en7581-eip93
+            - mediatek,mt7621-eip93
           - const: inside-secure,safexcel-eip93ies
       - items:
           - not: {}
Signature · 1 line
2.47.3
#2 lore raw

Re: [PATCH v3 2/3] dt-bindings: crypto: eip93: add support for Mediatek MT7621 SoC

Quoted 4 lines · Aleksander Jan Bajkowski

Add compatible for Mediatek MT7621 SoC. The implementation is exactly the same os in the Airoha SoC.

Quoted 9 lines

---
v3:
- Use enum
v2:
- Corrected commit description

---
 .../bindings/crypto/inside-secure,safexcel-eip93.yaml         | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml:35:13: [warning] wrong indentation: expected 14 but found 12 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.

#3 lore raw

PATCH v3 3/3 mips: dts: ralink: mt7621: add crypto offload support

In reply to Aleksander Jan Bajkowski

Add support for the built-in cryptographic accelerator. This accelerator supports 3DES, AES (128/192/256 bit), ARC4, MD5, SHA1, SHA224, and SHA256. It also supports full IPSEC, SRTP and TLS offload.

---
v3:
- Add reset line and clock gate
- Change commit description
- Wrap long line

---
 arch/mips/boot/dts/ralink/mt7621.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)
arch/mips/boot/dts/ralink/mt7621.dtsi +13 -0
index 0704eab4a80b..e1047dd861c0 100644
@@ -361,6 +361,19 @@ cdmm: cdmm@1fbf8000 {
 		reg = <0x1fbf8000 0x8000>;
 	};
 
+	crypto@1e004000 {
+		compatible = "mediatek,mt7621-eip93",
+			     "inside-secure,safexcel-eip93ies";
+		reg = <0x1e004000 0x1000>;
+
+		clocks = <&sysc MT7621_CLK_CRYPTO>;
+
+		interrupt-parent = <&gic>;
+		interrupts = <GIC_SHARED 19 IRQ_TYPE_LEVEL_HIGH>;
+
+		resets = <&sysc MT7621_RST_CRYPTO>;
+	};
+
 	ethernet: ethernet@1e100000 {
 		compatible = "mediatek,mt7621-eth";
 		reg = <0x1e100000 0x10000>;
Signature · 1 line
2.47.3
#4 lore raw
In reply to Aleksander Jan Bajkowski
Quoted 21 lines · Aleksander Jan Bajkowski

Add the clock gate and reset line, both of which are available on the Airoha AN7581.

---
v3:
- introduce patch

---
 .../crypto/inside-secure,safexcel-eip93.yaml       | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml +2 -0
index 997bf9717f9e..c6c99c08dc68 100644
@@ -48,20 +48,34 @@ properties:
   interrupts:
     maxItems: 1
 
+  clocks:
+    maxItems: 1

Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml properties: · line 62

Quoted 10 lines
Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml +6 -0
+
+  resets:
+    maxItems: 1
+
 required:
   - compatible
   - reg
   - interrupts
+  - clocks
+  - resets

That's ABI break without explanation in the commit msg.

Best regards,
Krzysztof

#5 lore raw

Hi Krzysztof,

Quoted 20 lines · Krzysztof Kozlowski
Quoted 19 lines · Aleksander Jan Bajkowski

Add the clock gate and reset line, both of which are available on the Airoha AN7581.

---
v3:
- introduce patch

---
  .../crypto/inside-secure,safexcel-eip93.yaml       | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml +0 -0
index 997bf9717f9e..c6c99c08dc68 100644
@@ -48,20 +48,34 @@ properties:
    interrupts:
      maxItems: 1
 
Quoted 14 lines

Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml properties: · line 62

Quoted 12 lines
Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml +8 -0
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
  required:
    - compatible
    - reg
    - interrupts
+  - clocks
+  - resets

That's ABI break without explanation in the commit msg.

I think that the reset line and clock gate are available on all SoCs with this IP Core. Should the reset line and clock gate only be required for newly added SoCs, and remain optional for existing ones?

Best regards,
Aleksander

#6 lore raw
Quoted 37 lines · Aleksander Jan Bajkowski

Hi Krzysztof,

Quoted 20 lines · Krzysztof Kozlowski
Quoted 19 lines · Aleksander Jan Bajkowski

Add the clock gate and reset line, both of which are available on the Airoha AN7581.

---
v3:
- introduce patch

---
  .../crypto/inside-secure,safexcel-eip93.yaml       | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml +0 -0
index 997bf9717f9e..c6c99c08dc68 100644
@@ -48,20 +48,34 @@ properties:
    interrupts:
      maxItems: 1
 
Quoted 14 lines

Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml properties: · line 62

Quoted 12 lines
Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml +8 -0
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
  required:
    - compatible
    - reg
    - interrupts
+  - clocks
+  - resets

That's ABI break without explanation in the commit msg.

Quoted 2 lines

I think that the reset line and clock gate are available on all SoCs with this IP Core. Should the reset line and clock gate only be

Not related. I did not say that hardware has or has not. I speak about ABI, so the interface.

Quoted 1 line

required for newly added SoCs, and remain optional for existing ones?

Best regards,
Krzysztof