Skip to contentSkip to conversation

RDMA/irdma: Remove redundant dma_wmb() before writel()

PATCH Applied Jacob Moroni 2 participants 2 messages Jan 3 – Jan 13

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/irdma: Remove redundant dma_wmb() before writel()

A dma_wmb() is not necessary before a writel() because writel() already has an even stronger store barrier. A dma_wmb() is only required to order writes to consistent/DMA memory whereas the barrier in writel() is specified to order writes to DMA memory as well as MMIO.

---
 drivers/infiniband/hw/irdma/ctrl.c | 2 --
 drivers/infiniband/hw/irdma/uk.c   | 3 ---
 2 files changed, 5 deletions(-)
drivers/infiniband/hw/irdma/ctrl.c +0 -2
index ce5cf89c463c..eec5b3d7a703 100644
@@ -3887,8 +3887,6 @@ void irdma_sc_ccq_arm(struct irdma_sc_cq *ccq)
 	set_64bit_val(ccq->cq_uk.shadow_area, 32, temp_val);
 	spin_unlock_irqrestore(&ccq->dev->cqp_lock, flags);
 
-	dma_wmb(); /* make sure shadow area is updated before arming */
-
 	writel(ccq->cq_uk.cq_id, ccq->dev->cq_arm_db);
 }
 
drivers/infiniband/hw/irdma/uk.c +0 -3
index f0846b800913..d651f9210f13 100644
@@ -114,7 +114,6 @@ void irdma_clr_wqes(struct irdma_qp_uk *qp, u32 qp_wqe_idx)
  */
 void irdma_uk_qp_post_wr(struct irdma_qp_uk *qp)
 {
-	dma_wmb();
 	writel(qp->qp_id, qp->wqe_alloc_db);
 }
 
@@ -1107,8 +1106,6 @@ void irdma_uk_cq_request_notification(struct irdma_cq_uk *cq,
 
 	set_64bit_val(cq->shadow_area, 32, temp_val);
 
-	dma_wmb(); /* make sure WQE is populated before valid bit is set */
-
 	writel(cq->cq_id, cq->cqe_alloc_db);
 }
 
Signature · 1 line
2.52.0.223.gf5cc29aaa4-goog
#1 lore raw
Quoted 8 lines · Jacob Moroni

A dma_wmb() is not necessary before a writel() because writel() already has an even stronger store barrier. A dma_wmb() is only required to order writes to consistent/DMA memory whereas the barrier in writel() is specified to order writes to DMA memory as well as MMIO.

[...]

Applied, thanks!

[1/1] RDMA/irdma: Remove redundant dma_wmb() before writel()

      https://git.kernel.org/rdma/rdma/c/52f3d34c292b62

Best regards,

Signature · 1 line
Leon Romanovsky <[email protected]>