virtio-gpu-virgl: correct parent for blob memory region
PATCH v3 1/1 virtio-gpu-virgl: correct parent for blob memory region
When owner == mr, object_unparent will crash:
object_unparent(mr) ->object_property_del_child(mr, mr) ->object_finalize_child_property(mr, name, mr) ->object_unref(mr) ->object_finalize(mr) ->object_property_del_all(mr) ->object_finalize_child_property(mr, name, mr) ->object_unref(mr) ->
fail on g_assert(obj->ref > 0)
However, passing a different owner to memory_region_init does not work. memory_region_ref has an optimization where it takes a ref only on the owner. That means when flatviews are created, it does not take a ref on the region and you can get a UAF from flatview_destroy called from RCU.
The correct fix therefore is to use NULL as the name which will set the owner but not the parent (which is still NULL). This allows us to use memory_region_ref on itself while not having to rely on unparent for cleanup.
--- hw/display/virtio-gpu-virgl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
hw/display/virtio-gpu-virgl.c +2 -2
@@ -123,7 +123,7 @@ virtio_gpu_virgl_map_resource_blob(VirtIOGPU *g, vmr->g = g; mr = &vmr->mr; -memory_region_init_ram_ptr (mr,OBJECT (mr),"blob" , size, data); +memory_region_init_ram_ptr (mr,OBJECT (mr),NULL , size, data);memory_region_add_subregion (&b->hostmem, offset, mr);memory_region_set_enabled (mr, true);
@@ -189,7 +189,7 @@ virtio_gpu_virgl_unmap_resource_blob(VirtIOGPU *g,/* memory region owns self res->mr object and frees it by itself */ memory_region_set_enabled (mr, false);memory_region_del_subregion (&b->hostmem, mr); -object_unparent (OBJECT (mr)); +object_unref (OBJECT (mr)); }return 0 ;
Signature · 1 line
2.50.1 (Apple Git-155)
Quoted 18 lines · Joelle van Dyne
When
owner==mr,object_unparentwill crash:
object_unparent(mr)->object_property_del_child(mr, mr)->object_finalize_child_property(mr, name, mr)->object_unref(mr)->object_finalize(mr)->object_property_del_all(mr)->object_finalize_child_property(mr, name, mr)->object_unref(mr)->
fail ong_assert(obj->ref > 0)However, passing a different
ownertomemory_region_initdoes not work.memory_region_refhas an optimization where it takes a ref only on the owner. That means when flatviews are created, it does not take a ref on the region and you can get a UAF fromflatview_destroycalled from RCU.
Quoted 6 lines
The correct fix therefore is to use
NULLas the name which will set theownerbut not theparent(which is still NULL). This allows us to usememory_region_refon itself while not having to rely on unparent for cleanup.Signed-off-by Joelle van Dyne <[email protected]>