Skip to contentSkip to conversation

tee: amdtee: Remove unused return variables

PATCH In review Thorsten Blum 2 participants 2 messages Jan 5 – Jan 14 TEE

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tee: amdtee: Remove unused return variables

In tee_params_to_amd_params() and amd_params_to_tee_params(), return 0 directly and remove the unused return variables.

---
 drivers/tee/amdtee/call.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/tee/amdtee/call.c +4 -4
index 4c21b02be4af..460b0c9e511f 100644
@@ -15,7 +15,7 @@
 static int tee_params_to_amd_params(struct tee_param *tee, u32 count,
 				    struct tee_operation *amd)
 {
-	int i, ret = 0;
+	int i;
 	u32 type;
 
 	if (!count)
@@ -66,13 +66,13 @@ static int tee_params_to_amd_params(struct tee_param *tee, u32 count,
 				 i, amd->params[i].val.b);
 		}
 	}
-	return ret;
+	return 0;
 }
 
 static int amd_params_to_tee_params(struct tee_param *tee, u32 count,
 				    struct tee_operation *amd)
 {
-	int i, ret = 0;
+	int i;
 	u32 type;
 
 	if (!count)
@@ -118,7 +118,7 @@ static int amd_params_to_tee_params(struct tee_param *tee, u32 count,
 				 i, amd->params[i].val.b);
 		}
 	}
-	return ret;
+	return 0;
 }
 
 static DEFINE_MUTEX(ta_refcount_mutex);
Signature · 2 lines
Thorsten Blum <[email protected]>
GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4
#1 lore raw
Quoted 8 lines · Thorsten Blum

In tee_params_to_amd_params() and amd_params_to_tee_params(), return 0 directly and remove the unused return variables.

---
 drivers/tee/amdtee/call.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Looks good. I'm picking up this.

Thanks,
Jens

Quoted 43 lines
drivers/tee/amdtee/call.c +4 -5
index 4c21b02be4af..460b0c9e511f 100644
@@ -15,7 +15,7 @@
 static int tee_params_to_amd_params(struct tee_param *tee, u32 count,
                                    struct tee_operation *amd)
 {
-       int i, ret = 0;
+       int i;
        u32 type;
 
        if (!count)
@@ -66,13 +66,13 @@ static int tee_params_to_amd_params(struct tee_param *tee, u32 count,
                                 i, amd->params[i].val.b);
                }
        }
-       return ret;
+       return 0;
 }
 
 static int amd_params_to_tee_params(struct tee_param *tee, u32 count,
                                    struct tee_operation *amd)
 {
-       int i, ret = 0;
+       int i;
        u32 type;
 
        if (!count)
@@ -118,7 +118,7 @@ static int amd_params_to_tee_params(struct tee_param *tee, u32 count,
                                 i, amd->params[i].val.b);
                }
        }
-       return ret;
+       return 0;
 }
 
 static DEFINE_MUTEX(ta_refcount_mutex);
--

Thorsten Blum <[email protected]>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4