FAILED: patch "[PATCH] leds: leds-lp50xx: Enable chip before any communication" failed to apply to 5.10-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 5.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y
git checkout FETCH_HEAD
git cherry-pick -x 434959618c47efe9e5f2e20f4a850caac4f6b823
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026010519-botanical-suds-31fa@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^..
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 434959618c47efe9e5f2e20f4a850caac4f6b823 Mon Sep 17 00:00:00 2001
From: Christian Hitz <[email protected]>
Date: Tue, 28 Oct 2025 16:51:40 +0100
Subject: [PATCH] leds: leds-lp50xx: Enable chip before any communication
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
If a GPIO is used to control the chip's enable pin, it needs to be pulled high before any i2c communication is attempted.
Currently, the enable GPIO handling is not correct.
Assume the enable GPIO is low when the probe function is entered. In this case the device is in SHUTDOWN mode and does not react to i2c commands.
During probe the following sequence happens:
1. The call to lp50xx_reset() on line 548 has no effect as i2c is not possible yet.
2. Then - on line 552 - lp50xx_enable_disable() is called. As "priv->enable_gpio“ has not yet been initialized, setting the GPIO has no effect. Also the i2c enable command is not executed as the device is still in SHUTDOWN.
3. On line 556 the call to lp50xx_probe_dt() finally parses the rest of
the DT and the configured priv->enable_gpio is set up.
As a result the device is still in SHUTDOWN mode and not ready for operation.
Split lp50xx_enable_disable() into distinct enable and disable functions to enforce correct ordering between enable_gpio manipulations and i2c commands.
Read enable_gpio configuration from DT before attempting to manipulate enable_gpio.
Add delays to observe correct wait timing after manipulating enable_gpio and before any i2c communication.
drivers/leds/leds-lp50xx.c +40 -15
@@ -50,6 +50,12 @@#define LP50XX_SW_RESET 0xff#define LP50XX_CHIP_EN BIT(6) +#define LP50XX_CHIP_DISABLE 0x00 +#define LP50XX_START_TIME_US 500 +#define LP50XX_RESET_TIME_US 3 + +#define LP50XX_EN_GPIO_LOW 0 +#define LP50XX_EN_GPIO_HIGH 1/* There are 3 LED outputs per bank */ #define LP50XX_LEDS_PER_MODULE 3
@@ -369,19 +375,42 @@ static int lp50xx_reset(struct lp50xx *priv)return regmap_write (priv->regmap, priv->chip_info->reset_reg,LP50XX_SW_RESET ); } -static int lp50xx_enable_disable (struct lp50xx *priv,int enable_disable) +static int lp50xx_enable (struct lp50xx *priv) {int ret; - ret =gpiod_direction_output (priv->enable_gpio, enable_disable); +if (priv->enable_gpio) { + ret =gpiod_direction_output (priv->enable_gpio,LP50XX_EN_GPIO_HIGH ); +if (ret) +return ret; + +udelay (LP50XX_START_TIME_US ); + } + + ret =lp50xx_reset (priv);if (ret)return ret; -if (enable_disable) -return regmap_write (priv->regmap,LP50XX_DEV_CFG0 ,LP50XX_CHIP_EN ); -else -return regmap_write (priv->regmap,LP50XX_DEV_CFG0 ,0 ); +return regmap_write (priv->regmap,LP50XX_DEV_CFG0 ,LP50XX_CHIP_EN ); +} +static int lp50xx_disable (struct lp50xx *priv) +{ +int ret; + + ret =regmap_write (priv->regmap,LP50XX_DEV_CFG0 ,LP50XX_CHIP_DISABLE ); +if (ret) +return ret; + +if (priv->enable_gpio) { + ret =gpiod_direction_output (priv->enable_gpio,LP50XX_EN_GPIO_LOW ); +if (ret) +return ret; + +udelay (LP50XX_RESET_TIME_US ); + } + +return 0 ; } static int lp50xx_probe_leds(struct fwnode_handle *child, struct lp50xx *priv,
@@ -445,6 +474,10 @@ static int lp50xx_probe_dt(struct lp50xx *priv)return dev_err_probe (priv->dev,PTR_ERR (priv->enable_gpio),"Failed to get enable GPIO\n" ); + ret =lp50xx_enable (priv); +if (ret) +return ret; + priv->regulator =devm_regulator_get (priv->dev,"vled" );if (IS_ERR (priv->regulator)) priv->regulator =NULL ;
@@ -545,14 +578,6 @@ static int lp50xx_probe(struct i2c_client *client)return ret; } - ret =lp50xx_reset (led); -if (ret) -return ret; - - ret =lp50xx_enable_disable (led,1 ); -if (ret) -return ret; -return lp50xx_probe_dt (led); }
@@ -561,7 +586,7 @@ static void lp50xx_remove(struct i2c_client *client)struct lp50xx *led =i2c_get_clientdata (client);int ret; - ret =lp50xx_enable_disable (led,0 ); + ret =lp50xx_disable (led);if (ret)dev_err (led->dev,"Failed to disable chip\n" );
Sasha Levin
maintainerPATCH 1/4 leds: lp50xx: Reduce level of dereferences
From: Andy Shevchenko <[email protected]>
[ Upstream commit 556f15fe023ec1d9f9cd2781ba6cd14bda650d22 ]
The priv->dev is effectively the same as &priv->client->dev. So, drop the latter for the former.
Stable-dep-of: 434959618c47 ("leds: leds-lp50xx: Enable chip before any communication")
--- drivers/leds/leds-lp50xx.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-)
drivers/leds/leds-lp50xx.c +12 -14
@@ -322,7 +322,7 @@ static int lp50xx_brightness_set(struct led_classdev *cdev, ret =regmap_write (led->priv->regmap, reg_val, brightness);if (ret) { -dev_err (&led->priv->client->dev, +dev_err (led->priv->dev,"Cannot write brightness value %d\n" , ret); goto out; }
@@ -338,7 +338,7 @@ static int lp50xx_brightness_set(struct led_classdev *cdev, ret =regmap_write (led->priv->regmap, reg_val, mc_dev->subled_info[i].intensity);if (ret) { -dev_err (&led->priv->client->dev, +dev_err (led->priv->dev,"Cannot write intensity value %d\n" , ret); goto out; }
@@ -404,7 +404,7 @@ static int lp50xx_probe_leds(struct fwnode_handle *child, struct lp50xx *priv,if (num_leds >1 ) {if (num_leds > priv->chip_info->max_modules) { -dev_err (&priv->client->dev,"reg property is invalid\n" ); +dev_err (priv->dev,"reg property is invalid\n" );return -EINVAL ; }
@@ -412,13 +412,13 @@ static int lp50xx_probe_leds(struct fwnode_handle *child, struct lp50xx *priv, ret =fwnode_property_read_u32_array (child,"reg" , led_banks, num_leds);if (ret) { -dev_err (&priv->client->dev,"reg property is missing\n" ); +dev_err (priv->dev,"reg property is missing\n" );return ret; } ret =lp50xx_set_banks (priv, led_banks);if (ret) { -dev_err (&priv->client->dev,"Cannot setup banked LEDs\n" ); +dev_err (priv->dev,"Cannot setup banked LEDs\n" );return ret; }
@@ -426,12 +426,12 @@ static int lp50xx_probe_leds(struct fwnode_handle *child, struct lp50xx *priv, }else { ret =fwnode_property_read_u32 (child,"reg" , &led_number);if (ret) { -dev_err (&priv->client->dev,"led reg property missing\n" ); +dev_err (priv->dev,"led reg property missing\n" );return ret; }if (led_number > priv->chip_info->num_leds) { -dev_err (&priv->client->dev,"led-sources property is invalid\n" ); +dev_err (priv->dev,"led-sources property is invalid\n" );return -EINVAL ; }
@@ -470,7 +470,7 @@ static int lp50xx_probe_dt(struct lp50xx *priv) led = &priv->leds[i]; ret =fwnode_property_count_u32 (child,"reg" );if (ret <0 ) { -dev_err (&priv->client->dev,"reg property is invalid\n" ); +dev_err (priv->dev,"reg property is invalid\n" ); goto child_out; }
@@ -520,12 +520,11 @@ static int lp50xx_probe_dt(struct lp50xx *priv) led_cdev = &led->mc_cdev.led_cdev; led_cdev->brightness_set_blocking = lp50xx_brightness_set; - ret =devm_led_classdev_multicolor_register_ext (&priv->client->dev, + ret =devm_led_classdev_multicolor_register_ext (priv->dev, &led->mc_cdev, &init_data);if (ret) { -dev_err (&priv->client->dev,"led register err: %d\n" , - ret); +dev_err (priv->dev,"led register err: %d\n" , ret); goto child_out; } i++;
@@ -588,15 +587,14 @@ static int lp50xx_remove(struct i2c_client *client) ret =lp50xx_enable_disable (led,0 );if (ret) { -dev_err (&led->client->dev,"Failed to disable chip\n" ); +dev_err (led->dev,"Failed to disable chip\n" );return ret; }if (led->regulator) { ret =regulator_disable (led->regulator);if (ret) -dev_err (&led->client->dev, -"Failed to disable regulator\n" ); +dev_err (led->dev,"Failed to disable regulator\n" ); }mutex_destroy (&led->lock);
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 2/4 leds: lp50xx: Get rid of redundant check in lp50xx_enable_disable()
From: Andy Shevchenko <[email protected]>
[ Upstream commit 5d2bfb3fb95b2d448c0fbcaa2c58b215b2fa87fc ]
Since GPIO is optional the API is NULL aware and will check descriptor anyway. Remove duplicate redundant check in lp50xx_enable_disable().
Stable-dep-of: 434959618c47 ("leds: leds-lp50xx: Enable chip before any communication")
--- drivers/leds/leds-lp50xx.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/leds/leds-lp50xx.c +3 -5
@@ -382,11 +382,9 @@ static int lp50xx_enable_disable(struct lp50xx *priv, int enable_disable) {int ret; -if (priv->enable_gpio) { - ret =gpiod_direction_output (priv->enable_gpio, enable_disable); -if (ret) -return ret; - } + ret =gpiod_direction_output (priv->enable_gpio, enable_disable); +if (ret) +return ret;if (enable_disable)return regmap_write (priv->regmap,LP50XX_DEV_CFG0 ,LP50XX_CHIP_EN );
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 3/4 leds: lp50xx: Remove duplicated error reporting in .remove()
In reply to Sasha LevinFrom: Uwe Kleine-König <[email protected]>
[ Upstream commit 73bce575ed90c752eaa4b2b9a70860481d58d240 ]
Returning an error value from an i2c remove callback results in an error message being emitted by the i2c core, but otherwise it doesn't make a difference. The device goes away anyhow and the devm cleanups are called.
As stk3310_set_state() already emits an error message on failure and the additional error message by the i2c core doesn't add any useful information, don't pass the error value up the stack. Instead continue to clean up and return 0.
This patch is a preparation for making i2c remove callbacks return void.
Stable-dep-of: 434959618c47 ("leds: leds-lp50xx: Enable chip before any communication")
--- drivers/leds/leds-lp50xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/leds/leds-lp50xx.c +1 -3
@@ -584,10 +584,8 @@ static int lp50xx_remove(struct i2c_client *client)int ret; ret =lp50xx_enable_disable (led,0 ); -if (ret) { +if (ret)dev_err (led->dev,"Failed to disable chip\n" ); -return ret; - }if (led->regulator) { ret =regulator_disable (led->regulator);
Signature · 1 line
2.51.0
Sasha Levin
maintainerPATCH 4/4 leds: leds-lp50xx: Enable chip before any communication
In reply to Sasha LevinFrom: Christian Hitz <[email protected]>
[ Upstream commit 434959618c47efe9e5f2e20f4a850caac4f6b823 ]
If a GPIO is used to control the chip's enable pin, it needs to be pulled high before any i2c communication is attempted.
Currently, the enable GPIO handling is not correct.
Assume the enable GPIO is low when the probe function is entered. In this case the device is in SHUTDOWN mode and does not react to i2c commands.
During probe the following sequence happens:
1. The call to lp50xx_reset() on line 548 has no effect as i2c is not possible yet.
2. Then - on line 552 - lp50xx_enable_disable() is called. As "priv->enable_gpio“ has not yet been initialized, setting the GPIO has no effect. Also the i2c enable command is not executed as the device is still in SHUTDOWN.
3. On line 556 the call to lp50xx_probe_dt() finally parses the rest of
the DT and the configured priv->enable_gpio is set up.
As a result the device is still in SHUTDOWN mode and not ready for operation.
Split lp50xx_enable_disable() into distinct enable and disable functions to enforce correct ordering between enable_gpio manipulations and i2c commands.
Read enable_gpio configuration from DT before attempting to manipulate enable_gpio.
Add delays to observe correct wait timing after manipulating enable_gpio and before any i2c communication.
--- drivers/leds/leds-lp50xx.c | 55 +++++++++++++++++++++++++++----------- 1 file changed, 40 insertions(+), 15 deletions(-)
drivers/leds/leds-lp50xx.c +40 -15
@@ -53,6 +53,12 @@#define LP50XX_SW_RESET 0xff#define LP50XX_CHIP_EN BIT(6) +#define LP50XX_CHIP_DISABLE 0x00 +#define LP50XX_START_TIME_US 500 +#define LP50XX_RESET_TIME_US 3 + +#define LP50XX_EN_GPIO_LOW 0 +#define LP50XX_EN_GPIO_HIGH 1/* There are 3 LED outputs per bank */ #define LP50XX_LEDS_PER_MODULE 3
@@ -378,19 +384,42 @@ static int lp50xx_reset(struct lp50xx *priv)return regmap_write (priv->regmap, priv->chip_info->reset_reg,LP50XX_SW_RESET ); } -static int lp50xx_enable_disable (struct lp50xx *priv,int enable_disable) +static int lp50xx_enable (struct lp50xx *priv) {int ret; - ret =gpiod_direction_output (priv->enable_gpio, enable_disable); +if (priv->enable_gpio) { + ret =gpiod_direction_output (priv->enable_gpio,LP50XX_EN_GPIO_HIGH ); +if (ret) +return ret; + +udelay (LP50XX_START_TIME_US ); + } + + ret =lp50xx_reset (priv);if (ret)return ret; -if (enable_disable) -return regmap_write (priv->regmap,LP50XX_DEV_CFG0 ,LP50XX_CHIP_EN ); -else -return regmap_write (priv->regmap,LP50XX_DEV_CFG0 ,0 ); +return regmap_write (priv->regmap,LP50XX_DEV_CFG0 ,LP50XX_CHIP_EN ); +} +static int lp50xx_disable (struct lp50xx *priv) +{ +int ret; + + ret =regmap_write (priv->regmap,LP50XX_DEV_CFG0 ,LP50XX_CHIP_DISABLE ); +if (ret) +return ret; + +if (priv->enable_gpio) { + ret =gpiod_direction_output (priv->enable_gpio,LP50XX_EN_GPIO_LOW ); +if (ret) +return ret; + +udelay (LP50XX_RESET_TIME_US ); + } + +return 0 ; } static int lp50xx_probe_leds(struct fwnode_handle *child, struct lp50xx *priv,
@@ -460,6 +489,10 @@ static int lp50xx_probe_dt(struct lp50xx *priv)return ret; } + ret =lp50xx_enable (priv); +if (ret) +return ret; + priv->regulator =devm_regulator_get (priv->dev,"vled" );if (IS_ERR (priv->regulator)) priv->regulator =NULL ;
@@ -567,14 +600,6 @@ static int lp50xx_probe(struct i2c_client *client,return ret; } - ret =lp50xx_reset (led); -if (ret) -return ret; - - ret =lp50xx_enable_disable (led,1 ); -if (ret) -return ret; -return lp50xx_probe_dt (led); }
@@ -583,7 +608,7 @@ static int lp50xx_remove(struct i2c_client *client)struct lp50xx *led =i2c_get_clientdata (client);int ret; - ret =lp50xx_enable_disable (led,0 ); + ret =lp50xx_disable (led);if (ret)dev_err (led->dev,"Failed to disable chip\n" );
Signature · 1 line
2.51.0