Skip to contentSkip to conversation

arm64: dts: rockchip: rk3399-roc-pc-plus: Add missing everest,es8388 supplies

PATCH Applied Rob Herring (Arm) 2 participants 2 messages Jan 5 – Jan 6

Subsystems (2)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: rk3399-roc-pc-plus: Add missing everest,es8388 supplies

The regulator supplies for everest,es8388 audio codec are missing and are required. Add them based on the schematics found here:

https://personalbsd.org/download/Documents/SCH/ROC-RK3399-PC-PLUS-V20-20210809.pdf

With this, "regulator-always-on" should no longer be necessary for LDO5.

---
I don't have this h/w, so completely untested.

---
 arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts | 4 ++++
 arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi     | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts +4 -0
index 8e3858cf988c..4f2831097624 100644
@@ -116,6 +116,10 @@ es8388: es8388@11 {
 		reg = <0x11>;
 		clocks = <&cru SCLK_I2S_8CH_OUT>;
 		#sound-dai-cells = <0>;
+		AVDD-supply = <&vcca3v0_codec>;
+		DVDD-supply = <&vcca1v8_codec>;
+		HPVDD-supply = <&vcca3v0_codec>;
+		PVDD-supply = <&vcca1v8_codec>;
 	};
 };
 
arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi +0 -1
index fc9279627ef6..ac62e8f5d9f5 100644
@@ -408,7 +408,6 @@ regulator-state-mem {
 
 			vcca3v0_codec: LDO_REG5 {
 				regulator-name = "vcca3v0_codec";
-				regulator-always-on;
 				regulator-boot-on;
 				regulator-min-microvolt = <3000000>;
 				regulator-max-microvolt = <3000000>;
Signature · 1 line
2.51.0
maintainer Applied
#1 lore raw
Quoted 8 lines · Rob Herring (Arm)

The regulator supplies for everest,es8388 audio codec are missing and are required. Add them based on the schematics found here:

https://personalbsd.org/download/Documents/SCH/ROC-RK3399-PC-PLUS-V20-20210809.pdf

With this, "regulator-always-on" should no longer be necessary for LDO5.

[...]

Applied, thanks!

[1/1] arm64: dts: rockchip: rk3399-roc-pc-plus: Add missing everest,es8388 supplies

      commit: 77712fe6847b2471a558ec88868311a4784afdce

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>