Skip to contentSkip to conversation

shadow-securetty: Remove unneeded recipe

PATCH In review Andrew Davis 4 participants 9 messages Jan 5 – Jan 7 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 shadow-securetty: Remove unneeded recipe

The first 4 entries are already in the default securetty file provided by oe-core, and we don't need all 5 anyway. Remove this recipe.

---
 .../shadow/shadow-securetty-arago.inc             | 15 ---------------
 .../shadow/shadow-securetty_%.bbappend            |  4 ----
 2 files changed, 19 deletions(-)
 delete mode 100644 meta-arago-distro/recipes-extended/shadow/shadow-securetty-arago.inc
 delete mode 100644 meta-arago-distro/recipes-extended/shadow/shadow-securetty_%.bbappend
meta-arago-distro/recipes-extended/shadow/shadow-securetty-arago.inc deleted +0 -15
deleted file mode 100644
index 62999d2a..00000000
@@ -1,15 +0,0 @@
-PR:append = ".arago0"
-
-do_install:append () {
-    # Allow telnet sessions to login as root
-    securetty_file=${D}${sysconfdir}/securetty
-
-    echo '' >> $securetty_file
-    echo '# Allow 5 telnet login' >> $securetty_file
-    echo 'pts/0' >> $securetty_file
-    echo 'pts/1' >> $securetty_file
-    echo 'pts/2' >> $securetty_file
-    echo 'pts/3' >> $securetty_file
-    echo 'pts/4' >> $securetty_file
-
-}
meta-arago-distro/recipes-extended/shadow/shadow-securetty_%.bbappend deleted +0 -4
deleted file mode 100644
index eea8f292..00000000
@@ -1,4 +0,0 @@
-SHADOW_SECURETTY_ARAGO = ""
-SHADOW_SECURETTY_ARAGO:arago = "shadow-securetty-arago.inc"
-
-require ${SHADOW_SECURETTY_ARAGO}
Signature · 1 line
2.39.2
#1 lore raw

PATCH 2/2 telnetd: Move telnet daemon scripts to meta-arago-test

These are only used (and only ever should be used) in testing images. Move these out of the base distro images and only into images including the ti-test packagegroup. Move the recipes themselves also over to meta-arago-test.

---
 check_yocto_rules.json                                        | 4 ++--
 .../recipes-core/packagegroups/packagegroup-arago-base.bb     | 2 --
 .../initscript-telnetd/initscript-telnetd.bb                  | 0
 .../initscript-telnetd/initscript-telnetd/telnetd             | 0
 .../recipes-connectivity/systemd-telnetd/systemd-telnetd.bb   | 0
 .../systemd-telnetd/systemd-telnetd/telnetd.service           | 0
 meta-arago-test/recipes-core/packagegroups/ti-test.bb         | 2 ++
 7 files changed, 4 insertions(+), 4 deletions(-)
 rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb (100%)
 rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd (100%)
 rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb (100%)
 rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service (100%)
check_yocto_rules.json +2 -2
index 7b3e20db..26275421 100644
@@ -27,8 +27,6 @@
     "PV-1" :{
         "skip_files" : [
             "meta-arago-distro/recipes-connectivity/bt-enable/bt-enable.bb",
-            "meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb",
-            "meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb",
             "meta-arago-distro/recipes-core/arago-gpl-notice/arago-gpl-notice.bb",
             "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk-server.bb",
             "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk.bb",
@@ -38,6 +36,8 @@
             "meta-arago-extras/recipes-extended/sysrepo/nw-configurator.bb",
             "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb",
             "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb"
+            "meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb",
+            "meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb",
         ]
     }
 }
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb +0 -2
index b80697e5..d36b4397 100644
@@ -16,8 +16,6 @@ ARAGO_BASE = "\
     mtd-utils \
     mtd-utils-ubifs \
     curl \
-    initscript-telnetd \
-    systemd-telnetd \
     ethtool \
     bash \
     opkg-bash-completion \
meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb renamed from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb
rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb
meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd renamed from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd
rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd
meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb renamed from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb
rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb
meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service renamed from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service
rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service
meta-arago-test/recipes-core/packagegroups/ti-test.bb +2 -0
index 22957218..ebac81c2 100644
@@ -22,6 +22,7 @@ TI_TEST_BASE = "\
     hwspinlocktest \
     hdparm \
     i2c-tools \
+    initscript-telnetd \
     iozone3 \
     iproute2-tc \
     iproute2-devlink \
@@ -57,6 +58,7 @@ TI_TEST_BASE = "\
     stress \
     stress-ng \
     strongswan \
+    systemd-telnetd \
     tcpdump \
     v4l-utils \
     xdp-tools-arago \
Signature · 1 line
2.39.2
#2 lore raw

Re: [meta-arago][master][PATCH 2/2] telnetd: Move telnet daemon scripts to meta-arago-test

This one may not work. This assumes that you have ti-test intstalled (which not all images do). And without ti-test in the image, then you cannot telnet to the board during test.

Quoted 91 lines · Andrew Davis

These are only used (and only ever should be used) in testing images. Move these out of the base distro images and only into images including the ti-test packagegroup. Move the recipes themselves also over to meta-arago-test.

---
  check_yocto_rules.json                                        | 4 ++--
  .../recipes-core/packagegroups/packagegroup-arago-base.bb     | 2 --
  .../initscript-telnetd/initscript-telnetd.bb                  | 0
  .../initscript-telnetd/initscript-telnetd/telnetd             | 0
  .../recipes-connectivity/systemd-telnetd/systemd-telnetd.bb   | 0
  .../systemd-telnetd/systemd-telnetd/telnetd.service           | 0
  meta-arago-test/recipes-core/packagegroups/ti-test.bb         | 2 ++
  7 files changed, 4 insertions(+), 4 deletions(-)

rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb (100%) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd (100%) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb (100%) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service (100%)

check_yocto_rules.json +2 -2
index 7b3e20db..26275421 100644
@@ -27,8 +27,6 @@
      "PV-1" :{
          "skip_files" : [
              "meta-arago-distro/recipes-connectivity/bt-enable/bt-enable.bb",
-            "meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb",
-            "meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb",
              "meta-arago-distro/recipes-core/arago-gpl-notice/arago-gpl-notice.bb",
              "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk-server.bb",
              "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk.bb",
@@ -38,6 +36,8 @@
              "meta-arago-extras/recipes-extended/sysrepo/nw-configurator.bb",
              "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb",
              "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb"
+            "meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb",
+            "meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb",
          ]
      }
  }
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb +0 -2
index b80697e5..d36b4397 100644
@@ -16,8 +16,6 @@ ARAGO_BASE = "\
      mtd-utils \
      mtd-utils-ubifs \
      curl \
-    initscript-telnetd \
-    systemd-telnetd \
      ethtool \
      bash \
      opkg-bash-completion \
meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb renamed from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb
rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb
meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd renamed from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd
rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd
meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb renamed from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb
rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb
meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service renamed from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service
rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service
meta-arago-test/recipes-core/packagegroups/ti-test.bb +2 -0
index 22957218..ebac81c2 100644
@@ -22,6 +22,7 @@ TI_TEST_BASE = "\
      hwspinlocktest \
      hdparm \
      i2c-tools \
+    initscript-telnetd \
      iozone3 \
      iproute2-tc \
      iproute2-devlink \
@@ -57,6 +58,7 @@ TI_TEST_BASE = "\
      stress \
      stress-ng \
      strongswan \
+    systemd-telnetd \
      tcpdump \
      v4l-utils \
      xdp-tools-arago \
Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#3 lore raw

Re: [meta-arago][master][PATCH 2/2] telnetd: Move telnet daemon scripts to meta-arago-test

Quoted 3 lines · Ryan Eatmon

This one may not work.  This assumes that you have ti-test intstalled (which not all images do).  And without ti-test in the image, then you cannot telnet to the board during test.

Why would you need to telnet onto a board to check on test if you are not testing? If you are testing, then you would have ti-test.

Removing this from images that are not specifically meant for use by our test automation is 100% intentional. Right now anyone can telnet into, as root, without a password, all of our images. As much as we love to claim no one should be using these images as a base for their production image, absolutly every single customer is anyway. Which means we have a huge security foot-gun here, and customers *will* end up shipping devices with this massive security issue.

Andrew

Quoted 94 lines · Andrew Davis
Quoted 91 lines

These are only used (and only ever should be used) in testing images. Move these out of the base distro images and only into images including the ti-test packagegroup. Move the recipes themselves also over to meta-arago-test.

---
  check_yocto_rules.json                                        | 4 ++-- .../recipes-core/packagegroups/packagegroup-arago-base.bb     | 2 -- .../initscript-telnetd/initscript-telnetd.bb                  | 0 .../initscript-telnetd/initscript-telnetd/telnetd             | 0 .../recipes-connectivity/systemd-telnetd/systemd-telnetd.bb   | 0 .../systemd-telnetd/systemd-telnetd/telnetd.service           | 0 meta-arago-test/recipes-core/packagegroups/ti-test.bb         | 2 ++

  7 files changed, 4 insertions(+), 4 deletions(-)

  rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb (100%) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd (100%) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb (100%) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service (100%)

check_yocto_rules.json +0 -0
index 7b3e20db..26275421 100644
@@ -27,8 +27,6 @@
       "PV-1" :{

          "skip_files" : [ "meta-arago-distro/recipes-connectivity/bt-enable/bt-enable.bb",
-            "meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", -            "meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb", "meta-arago-distro/recipes-core/arago-gpl-notice/arago-gpl-notice.bb", "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk-server.bb", "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk.bb",

check_yocto_rules.json +0 -0
@@ -38,6 +36,8 @@
               "meta-arago-extras/recipes-extended/sysrepo/nw-configurator.bb",
               "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb",

              "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb" +            "meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", +            "meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb", ]
      }
  }

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb +0 -2
index b80697e5..d36b4397 100644
@@ -16,8 +16,6 @@ ARAGO_BASE = "\
       mtd-utils \
       mtd-utils-ubifs \
       curl \
-    initscript-telnetd \
-    systemd-telnetd \
       ethtool \
       bash \
       opkg-bash-completion \
meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb renamed from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb
rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb
meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd renamed from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd
rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd
meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb renamed from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb
rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb
meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service renamed from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service
rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service
meta-arago-test/recipes-core/packagegroups/ti-test.bb +2 -0
index 22957218..ebac81c2 100644
@@ -22,6 +22,7 @@ TI_TEST_BASE = "\
       hwspinlocktest \
       hdparm \
       i2c-tools \
+    initscript-telnetd \
       iozone3 \
       iproute2-tc \
       iproute2-devlink \
@@ -57,6 +58,7 @@ TI_TEST_BASE = "\
       stress \
       stress-ng \
       strongswan \
+    systemd-telnetd \
       tcpdump \
       v4l-utils \
       xdp-tools-arago \
#4 lore raw

Re: [meta-arago][master][PATCH 2/2] telnetd: Move telnet daemon scripts to meta-arago-test

Quoted 7 lines · Andrew Davis
Quoted 3 lines · Ryan Eatmon

This one may not work.  This assumes that you have ti-test intstalled (which not all images do).  And without ti-test in the image, then you cannot telnet to the board during test.

Why would you need to telnet onto a board to check on test if you are not testing? If you are testing, then you would have ti-test.

The base image is kept small to do network based tests. They then install the ti-test package from the NAS. But that assumes that the test framework could telnet to the board after boot in order to run commands... That's the scenario I'm thinking of.

The best solution is to update all of the tests to use ssh, but that still means we are still hardcoding something in the file system to allow connecting in a bad way.

What if we also combined the above with a variable that we set in the local.conf during our builds, but is off by default. And that varible override would make us include the ti-test-required. We could even just add that setting to the local.conf...

Quoted 118 lines

Removing this from images that are not specifically meant for use by our test automation is 100% intentional. Right now anyone can telnet into, as root, without a password, all of our images. As much as we love to claim no one should be using these images as a base for their production image, absolutly every single customer is anyway. Which means we have a huge security foot-gun here, and customers *will* end up shipping devices with this massive security issue.

Andrew

Quoted 107 lines · Andrew Davis
Quoted 104 lines

These are only used (and only ever should be used) in testing images. Move these out of the base distro images and only into images including the ti-test packagegroup. Move the recipes themselves also over to meta-arago-test.

---
  check_yocto_rules.json                                        | 4 ++-- .../recipes-core/packagegroups/packagegroup-arago-base.bb     | 2 -- .../initscript-telnetd/initscript-telnetd.bb                  | 0 .../initscript-telnetd/initscript-telnetd/telnetd             | 0 .../recipes-connectivity/systemd-telnetd/systemd-telnetd.bb   | 0 .../systemd-telnetd/systemd-telnetd/telnetd.service           | 0 meta-arago-test/recipes-core/packagegroups/ti-test.bb         | 2 ++

  7 files changed, 4 insertions(+), 4 deletions(-)

  rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb (100%) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd (100%) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb (100%) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service (100%)

check_yocto_rules.json +0 -0
index 7b3e20db..26275421 100644
@@ -27,8 +27,6 @@
       "PV-1" :{

          "skip_files" : [

"meta-arago-distro/recipes-connectivity/bt-enable/bt-enable.bb",
- "meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", - "meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb",

"meta-arago-distro/recipes-core/arago-gpl-notice/arago-gpl-notice.bb",

"meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk-server.bb",

"meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk.bb",

check_yocto_rules.json +0 -0
@@ -38,6 +36,8 @@
 
 "meta-arago-extras/recipes-extended/sysrepo/nw-configurator.bb",
 
 "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb",
 

"meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb" + "meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", + "meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb", ]
      }
  }

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb +0 -1
index b80697e5..d36b4397 100644
--- 

a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
+++
b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb +0 -2
@@ -16,8 +16,6 @@ ARAGO_BASE = "\
       mtd-utils \
       mtd-utils-ubifs \
       curl \
-    initscript-telnetd \
-    systemd-telnetd \
       ethtool \
       bash \
       opkg-bash-completion \
meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb renamed from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb
rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb
meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd renamed from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd
rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd
meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb renamed from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb
rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb
meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service renamed from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service
rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service
meta-arago-test/recipes-core/packagegroups/ti-test.bb +2 -0
index 22957218..ebac81c2 100644
@@ -22,6 +22,7 @@ TI_TEST_BASE = "\
       hwspinlocktest \
       hdparm \
       i2c-tools \
+    initscript-telnetd \
       iozone3 \
       iproute2-tc \
       iproute2-devlink \
@@ -57,6 +58,7 @@ TI_TEST_BASE = "\
       stress \
       stress-ng \
       strongswan \
+    systemd-telnetd \
       tcpdump \
       v4l-utils \
       xdp-tools-arago \
Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#5 lore raw

Re: [meta-arago][master][PATCH 2/2] telnetd: Move telnet daemon scripts to meta-arago-test

There's a standard DEBUG_BUILD variable that can be reused for this. But...

It is a build-time condition, which means you end up with two separate builds for release and debugging. Do you test both? Or how can you ensure testing debug build also covers the release build properly?

The idea of only building release images and then installing test packages at run-time for testing was to mitigate the above ambiguity...

That said, I don't understand why it has to drive the run-time testing over telnet or ssh? Isn't the early boot testing already done over serial? Can the user-space Linux testing be done over serial as well?

Signature · 1 line
Denys
Quoted 137 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 9 lines · Andrew Davis
Quoted 5 lines · Ryan Eatmon

This one may not work.  This assumes that you have ti-test intstalled (which not all images do).  And without ti-test in the image, then you cannot telnet to the board during test.

Why would you need to telnet onto a board to check on test if you are not testing? If you are testing, then you would have ti-test.

The base image is kept small to do network based tests. They then install the ti-test package from the NAS. But that assumes that the test framework could telnet to the board after boot in order to run commands... That's the scenario I'm thinking of.

The best solution is to update all of the tests to use ssh, but that still means we are still hardcoding something in the file system to allow connecting in a bad way.

What if we also combined the above with a variable that we set in the local.conf during our builds, but is off by default. And that varible override would make us include the ti-test-required. We could even just add that setting to the local.conf...

Quoted 109 lines

Removing this from images that are not specifically meant for use by our test automation is 100% intentional. Right now anyone can telnet into, as root, without a password, all of our images. As much as we love to claim no one should be using these images as a base for their production image, absolutly every single customer is anyway. Which means we have a huge security foot-gun here, and customers *will* end up shipping devices with this massive security issue.

Andrew

Quoted 99 lines · Andrew Davis
Quoted 97 lines

These are only used (and only ever should be used) in testing images. Move these out of the base distro images and only into images including the ti-test packagegroup. Move the recipes themselves also over to meta-arago-test.

---
  check_yocto_rules.json                                        | 4 ++-- .../recipes-core/packagegroups/packagegroup-arago-base.bb     | 2 -- .../initscript-telnetd/initscript-telnetd.bb                  | 0 .../initscript-telnetd/initscript-telnetd/telnetd             | 0 .../recipes-connectivity/systemd-telnetd/systemd-telnetd.bb   | 0 .../systemd-telnetd/systemd-telnetd/telnetd.service           | 0 meta-arago-test/recipes-core/packagegroups/ti-test.bb         | 2 ++

  7 files changed, 4 insertions(+), 4 deletions(-)

  rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb (100%)
  rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd (100%)
  rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb (100%)
  rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service (100%)

check_yocto_rules.json +0 -0
index 7b3e20db..26275421 100644
@@ -27,8 +27,6 @@
       "PV-1" :{

          "skip_files" : [ "meta-arago-distro/recipes-connectivity/bt-enable/bt-enable.bb",

check_yocto_rules.json +0 -2
-            "meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb",
-            "meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb",

"meta-arago-distro/recipes-core/arago-gpl-notice/arago-gpl-notice.bb", "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk-server.bb", "meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk.bb",

check_yocto_rules.json +0 -0
@@ -38,6 +36,8 @@
 "meta-arago-extras/recipes-extended/sysrepo/nw-configurator.bb",
 "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb",

"meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb"

check_yocto_rules.json +2 -0
+            "meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb",
+            "meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb",

          ]
      }
  }

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb +0 -2
index b80697e5..d36b4397 100644
@@ -16,8 +16,6 @@ ARAGO_BASE = "\
       mtd-utils \
       mtd-utils-ubifs \
       curl \
-    initscript-telnetd \
-    systemd-telnetd \
       ethtool \
       bash \
       opkg-bash-completion \
meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb renamed from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb
rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb
meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd renamed from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd
rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd
meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb renamed from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb
rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb
meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service renamed from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service
rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service

diff --git a/meta-arago-test/recipes-core/packagegroups/ti-test.bb b/meta-arago-test/recipes-core/packagegroups/ti-test.bb index 22957218..ebac81c2 100644

meta-arago-test/recipes-core/packagegroups/ti-test.bb +2 -0
@@ -22,6 +22,7 @@ TI_TEST_BASE = "\
       hwspinlocktest \
       hdparm \
       i2c-tools \
+    initscript-telnetd \
       iozone3 \
       iproute2-tc \
       iproute2-devlink \
@@ -57,6 +58,7 @@ TI_TEST_BASE = "\
       stress \
       stress-ng \
       strongswan \
+    systemd-telnetd \
       tcpdump \
       v4l-utils \
       xdp-tools-arago \
#6 lore raw

Re: [meta-arago][master][PATCH 2/2] telnetd: Move telnet daemon scripts to meta-arago-test

Quoted 9 lines · Denys Dmytriyenko

There's a standard DEBUG_BUILD variable that can be reused for this. But...

It is a build-time condition, which means you end up with two separate builds for release and debugging. Do you test both? Or how can you ensure testing debug build also covers the release build properly?

The idea of only building release images and then installing test packages at run-time for testing was to mitigate the above ambiguity...

I believe it is always best to test the same configuration we release, so I'd like to avoid splitting the build. Instead simply looking to have a cleaner split between images with testing packages and images without (all built with the same configuration). Having the ti-test packages installed after by the test infra itself is also a reasonable solution.

Quoted 4 lines

That said, I don't understand why it has to drive the run-time testing over telnet or ssh? Isn't the early boot testing already done over serial? Can the user-space Linux testing be done over serial as well?

This would be much better. As Ryan pointed out, even SSH doesn't save us completely as we would need to still inject login info and such. Serial at least requires some level of physical access to the HW before getting root. Not perfect, but so much better than open root exposed over network.

Andrew

A message that is not in the archive (sent off-list or not yet received): [email protected]

#8 lore raw

Re: [meta-arago][master][PATCH 2/2] telnetd: Move telnet daemon scripts to meta-arago-test

Maybe we should make a ti-test-core? or ti-test-required? And put things like this into that package and have it in ti-test as well. Then we could change the image dependencies to require the new ti-test-required... Would that work?

Quoted 110 lines · Ryan Eatmon via lists.yoctoproject.org

This one may not work.  This assumes that you have ti-test intstalled (which not all images do).  And without ti-test in the image, then you cannot telnet to the board during test.

Quoted 104 lines · Andrew Davis

These are only used (and only ever should be used) in testing images. Move these out of the base distro images and only into images including the ti-test packagegroup. Move the recipes themselves also over to meta-arago-test.

---
  check_yocto_rules.json                                        | 4 ++-- .../recipes-core/packagegroups/packagegroup-arago-base.bb     | 2 -- .../initscript-telnetd/initscript-telnetd.bb                  | 0 .../initscript-telnetd/initscript-telnetd/telnetd             | 0 .../recipes-connectivity/systemd-telnetd/systemd-telnetd.bb   | 0 .../systemd-telnetd/systemd-telnetd/telnetd.service           | 0 meta-arago-test/recipes-core/packagegroups/ti-test.bb         | 2 ++

  7 files changed, 4 insertions(+), 4 deletions(-)

  rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb (100%) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd (100%) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb (100%) rename {meta-arago-distro => meta-arago-test}/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service (100%)

check_yocto_rules.json +0 -0
index 7b3e20db..26275421 100644
@@ -27,8 +27,6 @@
       "PV-1" :{

          "skip_files" : [

"meta-arago-distro/recipes-connectivity/bt-enable/bt-enable.bb",
- "meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", - "meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb",

"meta-arago-distro/recipes-core/arago-gpl-notice/arago-gpl-notice.bb",

"meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk-server.bb",

"meta-arago-distro/recipes-core/meta/meta-toolchain-arago-tisdk.bb",

check_yocto_rules.json +0 -0
@@ -38,6 +36,8 @@
 
 "meta-arago-extras/recipes-extended/sysrepo/nw-configurator.bb",
 
 "meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb",
 

"meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb" + "meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb", + "meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb", ]
      }
  }

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb +0 -1
index b80697e5..d36b4397 100644
--- 

a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
+++
b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb

meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb +0 -2
@@ -16,8 +16,6 @@ ARAGO_BASE = "\
       mtd-utils \
       mtd-utils-ubifs \
       curl \
-    initscript-telnetd \
-    systemd-telnetd \
       ethtool \
       bash \
       opkg-bash-completion \
meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb renamed from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb
rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb
meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd renamed from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd
rename to meta-arago-test/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd
meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb renamed from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb
rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd.bb
meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service renamed from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service +0 -0
similarity index 100%
rename from meta-arago-distro/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service
rename to meta-arago-test/recipes-connectivity/systemd-telnetd/systemd-telnetd/telnetd.service
meta-arago-test/recipes-core/packagegroups/ti-test.bb +2 -0
index 22957218..ebac81c2 100644
@@ -22,6 +22,7 @@ TI_TEST_BASE = "\
       hwspinlocktest \
       hdparm \
       i2c-tools \
+    initscript-telnetd \
       iozone3 \
       iproute2-tc \
       iproute2-devlink \
@@ -57,6 +58,7 @@ TI_TEST_BASE = "\
       stress \
       stress-ng \
       strongswan \
+    systemd-telnetd \
       tcpdump \
       v4l-utils \
       xdp-tools-arago \
Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#9 lore raw
In reply to Andrew Davis

meta-arago / na / 20260105221926.2503358-1-afd

PRC Results: FAIL

=========================================================
check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
All patches passed

=========================================================
apply-yocto-patch: PASS
=========================================================
master
=====================
Summary:
- Patch Series: [meta-arago][master][PATCH 1/2] shadow-securetty: Remove unneeded recipe
- Submitter: From: Andrew Davis <[email protected]>
- Date: Date: Mon, 5 Jan 2026 16:19:25 -0600
- Num Patches: 2
- Mailing List (public inbox) Commit SHA: ae7cca927d79ef506ad4b042e2643536649b9873

Applied to:
- Repository: lcpd-prc-meta-arago
- Base Branch: master-wip
- Commit Author: Ryan Eatmon <[email protected]>
- Commit Subject: libdrm: Remove upstreamed patch
- Commit SHA: 8c190b1e4f6a53ea641ba9d6150ef873f561c706

Patches
----------------------------------------
All patches applied

=========================================================
check-yocto-repo: FAIL
=========================================================
master
=====================
FAIL