Skip to contentSkip to conversation

tisdk-default-image: Use core packagegroup to include valgrind

PATCH In review Andrew Davis 3 participants 7 messages Jan 5 – Jan 23

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 tisdk-default-image: Use core packagegroup to include valgrind

This packagegroup includes valgrind and handles the arch compatibility selection for us.

---
 meta-arago-distro/recipes-core/images/tisdk-default-image.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arago-distro/recipes-core/images/tisdk-default-image.bb +1 -1
index bc067857..a35e8321 100644
@@ -34,12 +34,12 @@ DEVTOOLS = " \
     linux-libc-headers-dev \
     build-essential \
     packagegroup-core-tools-debug \
+    packagegroup-core-tools-profile \
     git \
     dtc \
 "
 
 IMAGE_INSTALL += "\
     ${DEVTOOLS} \
-    ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \
     docker \
 "
Signature · 1 line
2.39.2
#1 lore raw

PATCH 2/2 ti-world: Use core packagegroup to include valgrind

This packagegroup includes valgrind and handles the arch compatibility selection for us.

---
 meta-arago-distro/recipes-core/packagegroups/ti-world.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arago-distro/recipes-core/packagegroups/ti-world.bb +1 -1
index 25642831..be7720e7 100644
@@ -23,6 +23,7 @@ DEVTOOLS = " \
     linux-libc-headers-dev \
     build-essential \
     packagegroup-core-tools-debug \
+    packagegroup-core-tools-profile \
     git \
 "
 
@@ -40,7 +41,6 @@ RDEPENDS:${PN} = "\
     ${@bb.utils.contains('DISTRO_FEATURES','opengl','','packagegroup-arago-base-tisdk-server-extra',d)} \
     ${@bb.utils.contains("BBFILE_COLLECTIONS", "meta-python2", "${PYTHON2APPS}", "", d)} \
     ${DEVTOOLS} \
-    ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \
     packagegroup-arago-misc \
     ${PREFERRED_PROVIDER_virtual/docker} \
 "
Signature · 1 line
2.39.2
#2 lore raw
In reply to Andrew Davis

meta-arago / na / 20260105222205.2503660-1-afd

PRC Results: PASS

=========================================================
check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
All patches passed

=========================================================
apply-yocto-patch: PASS
=========================================================
master
=====================
Summary:
- Patch Series: [meta-arago][master][PATCH 1/2] tisdk-default-image: Use core packagegroup to include valgrind
- Submitter: From: Andrew Davis <[email protected]>
- Date: Date: Mon, 5 Jan 2026 16:22:04 -0600
- Num Patches: 2
- Mailing List (public inbox) Commit SHA: 196cc6fcca1cccdac12fbed2302b1f8a28db5b94

Applied to:
- Repository: lcpd-prc-meta-arago
- Base Branch: master-wip
- Commit Author: Ryan Eatmon <[email protected]>
- Commit Subject: libdrm: Remove upstreamed patch
- Commit SHA: 8c190b1e4f6a53ea641ba9d6150ef873f561c706

Patches
----------------------------------------
All patches applied

=========================================================
check-yocto-repo: PASS
=========================================================
master
=====================
PASS

=========================================================
yocto-check-layers: PASS
=========================================================
master - PASS
=====================
All checks passed

#3 lore raw
In reply to Andrew Davis

Build issue with this patch. Including that packagegroup includes the lttng package which is a tracing tool. That code requires that the kernel have CONFIG_TRACEPOINTS turned on to compile, but it is not turned on for our kernels.

We need to resolve this issue before we can take this patch series.

scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c: In function 'lttng_tracepoint_coming':
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:227:36: error: 'struct module' has no member named 'num_tracepoints'
227 | for (i = 0; i < tp_mod->mod->num_tracepoints; i++) {
| ^~
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:232:61: error: 'struct module' has no member named 'tracepoints_ptrs'
232 | tp =
lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]);
| ^~
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c: In function 'lttng_tracepoint_going':
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:268:36: error: 'struct module' has no member named 'num_tracepoints'
268 | for (i = 0; i < tp_mod->mod->num_tracepoints; i++) {
| ^~
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:273:61: error: 'struct module' has no member named 'tracepoints_ptrs'
273 | tp =
lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]);
| ^~

Quoted 26 lines · Andrew Davis

This packagegroup includes valgrind and handles the arch compatibility selection for us.

---
  meta-arago-distro/recipes-core/images/tisdk-default-image.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-arago-distro/recipes-core/images/tisdk-default-image.bb +1 -1
index bc067857..a35e8321 100644
@@ -34,12 +34,12 @@ DEVTOOLS = " \
      linux-libc-headers-dev \
      build-essential \
      packagegroup-core-tools-debug \
+    packagegroup-core-tools-profile \
      git \
      dtc \
  "
 
  IMAGE_INSTALL += "\
      ${DEVTOOLS} \
-    ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \
      docker \
  "
Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#4 lore raw
Quoted 4 lines · Ryan Eatmon

Build issue with this patch.  Including that packagegroup includes the lttng package which is a tracing tool.  That code requires that the kernel have CONFIG_TRACEPOINTS turned on to compile, but it is not turned on for our kernels.

Looks like there was a fix for this, but it is not functioning as it should,

https://git.openembedded.org/openembedded-core/tree/meta/recipes-kernel/lttng/lttng-modules/0001-src-Kbuild-change-missing-CONFIG_TRACEPOINTS-to-warn.patch

Quoted 47 lines

We need to resolve this issue before we can take this patch series.

scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c: In function 'lttng_tracepoint_coming':
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:227:36: error: 'struct module' has no member named 'num_tracepoints'
  227 |         for (i = 0; i < tp_mod->mod->num_tracepoints; i++) {
      |                                    ^~
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:232:61: error: 'struct module' has no member named 'tracepoints_ptrs'
  232 |                 tp = lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]);
      |                                                             ^~
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c: In function 'lttng_tracepoint_going':
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:268:36: error: 'struct module' has no member named 'num_tracepoints'
  268 |         for (i = 0; i < tp_mod->mod->num_tracepoints; i++) {
      |                                    ^~
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:273:61: error: 'struct module' has no member named 'tracepoints_ptrs'
  273 |                 tp = lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]);
      |                                                             ^~

Quoted 25 lines · Andrew Davis

This packagegroup includes valgrind and handles the arch compatibility selection for us.

---
  meta-arago-distro/recipes-core/images/tisdk-default-image.bb | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
meta-arago-distro/recipes-core/images/tisdk-default-image.bb +1 -0
index bc067857..a35e8321 100644
@@ -34,12 +34,12 @@ DEVTOOLS = " \
       linux-libc-headers-dev \
       build-essential \
       packagegroup-core-tools-debug \
+    packagegroup-core-tools-profile \
       git \
       dtc \

  "
  IMAGE_INSTALL += "\
      ${DEVTOOLS} \
-    ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \
      docker \
  "

#5 lore raw
Quoted 9 lines · Andrew Davis
Quoted 4 lines · Ryan Eatmon

Build issue with this patch.  Including that packagegroup includes the lttng package which is a tracing tool.  That code requires that the kernel have CONFIG_TRACEPOINTS turned on to compile, but it is not turned on for our kernels.

Looks like there was a fix for this, but it is not functioning as it should,

https://git.openembedded.org/openembedded-core/tree/meta/recipes-kernel/lttng/lttng-modules/0001-src-Kbuild-change-missing-CONFIG_TRACEPOINTS-to-warn.patch

Sigh.

ifdef CONFIG_LOCALVERSION # Check if dot-config is included.
ifeq ($(CONFIG_TRACEPOINTS),)

    $(warning The option CONFIG_TRACEPOINTS needs to be enabled in your 

kernel configuration)
DISABLE_MODULE = y
endif # CONFIG_TRACEPOINTS
endif # ifdef CONFIG_LOCALVERSION

ifneq ($(DISABLE_MODULE),y)

Quoted 1 line

grep CONFIG_LOCALVERSION .config

CONFIG_LOCALVERSION=""
CONFIG_LOCALVERSION_AUTO=y

So the checking code doesn't kick in because CONFIG_LOCALVERSION is ""...

Does the #ifdef return false if the variable is set to "" ?

Quoted 49 lines
Quoted 48 lines

We need to resolve this issue before we can take this patch series.

scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c: In function 'lttng_tracepoint_coming':
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:227:36: error: 'struct module' has no member named 'num_tracepoints' 227 |         for (i = 0; i < tp_mod->mod->num_tracepoints; i++) {
       |                                    ^~ /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:232:61: error: 'struct module' has no member named 'tracepoints_ptrs' 232 |                 tp = lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]);
       |                                                             ^~ /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c: In function 'lttng_tracepoint_going':
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:268:36: error: 'struct module' has no member named 'num_tracepoints' 268 |         for (i = 0; i < tp_mod->mod->num_tracepoints; i++) {
       |                                    ^~ /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:273:61: error: 'struct module' has no member named 'tracepoints_ptrs' 273 |                 tp = lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]);
       |                                                             ^~

Quoted 26 lines · Andrew Davis

This packagegroup includes valgrind and handles the arch compatibility selection for us.

---
  meta-arago-distro/recipes-core/images/tisdk-default-image.bb | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
meta-arago-distro/recipes-core/images/tisdk-default-image.bb +1 -0
index bc067857..a35e8321 100644
@@ -34,12 +34,12 @@ DEVTOOLS = " \
       linux-libc-headers-dev \
       build-essential \
       packagegroup-core-tools-debug \
+    packagegroup-core-tools-profile \
       git \
       dtc \

  "
  IMAGE_INSTALL += "\
      ${DEVTOOLS} \
-    ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \
      docker \
  "

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#6 lore raw
Quoted 25 lines · Ryan Eatmon
Quoted 9 lines · Andrew Davis
Quoted 4 lines · Ryan Eatmon

Build issue with this patch.  Including that packagegroup includes the lttng package which is a tracing tool.  That code requires that the kernel have CONFIG_TRACEPOINTS turned on to compile, but it is not turned on for our kernels.

Looks like there was a fix for this, but it is not functioning as it should,

https://git.openembedded.org/openembedded-core/tree/meta/recipes-kernel/lttng/lttng-modules/0001-src-Kbuild-change-missing-CONFIG_TRACEPOINTS-to-warn.patch

Sigh.

ifdef CONFIG_LOCALVERSION   # Check if dot-config is included.
  ifeq ($(CONFIG_TRACEPOINTS),)
    $(warning The option CONFIG_TRACEPOINTS needs to be enabled in your kernel configuration) DISABLE_MODULE = y
  endif # CONFIG_TRACEPOINTS
endif # ifdef CONFIG_LOCALVERSION

ifneq ($(DISABLE_MODULE),y)

Quoted 9 lines
Quoted 1 line

grep CONFIG_LOCALVERSION .config

CONFIG_LOCALVERSION=""
CONFIG_LOCALVERSION_AUTO=y

So the checking code doesn't kick in because CONFIG_LOCALVERSION is ""...

Does the #ifdef return false if the variable is set to "" ?

You would think it would still work, but yeah I noticed the same, I just removed the ifdef CONFIG_LOCALVERSION check altogether and the rest of the ifeq checks do still work as they should.

Surprised this must have been broken upstream for a while now, either no one uses lttng-modules/lttng-tools, or everyone just uses a kernel with TRACEPOINTS set. (actually it seems our v6.12 kernel *does* have this set, the issue is also CONFIG_KPROBES must be set too, so even when we fix the LOCALVERSION thing, we will need to add KPROBES to the first check).

Quoted 51 lines
Quoted 50 lines
Quoted 49 lines

We need to resolve this issue before we can take this patch series.

scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c: In function 'lttng_tracepoint_coming':
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:227:36: error: 'struct module' has no member named 'num_tracepoints' 227 |         for (i = 0; i < tp_mod->mod->num_tracepoints; i++) {
       |                                    ^~ /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:232:61: error: 'struct module' has no member named 'tracepoints_ptrs' 232 |                 tp = lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]);
       |                                                             ^~ /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c: In function 'lttng_tracepoint_going':
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:268:36: error: 'struct module' has no member named 'num_tracepoints' 268 |         for (i = 0; i < tp_mod->mod->num_tracepoints; i++) {
       |                                    ^~ /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:273:61: error: 'struct module' has no member named 'tracepoints_ptrs' 273 |                 tp = lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]);
       |                                                             ^~

Quoted 25 lines · Andrew Davis

This packagegroup includes valgrind and handles the arch compatibility selection for us.

---
  meta-arago-distro/recipes-core/images/tisdk-default-image.bb | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
meta-arago-distro/recipes-core/images/tisdk-default-image.bb +1 -0
index bc067857..a35e8321 100644
@@ -34,12 +34,12 @@ DEVTOOLS = " \
       linux-libc-headers-dev \
       build-essential \
       packagegroup-core-tools-debug \
+    packagegroup-core-tools-profile \
       git \
       dtc \

  "
  IMAGE_INSTALL += "\
      ${DEVTOOLS} \
-    ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \
      docker \
  "