Skip to contentSkip to conversation

staging: greybus: replace WD_STATE_COLDBOOT_TRIG with state

PATCH In review Gideon Adjei 2 participants 2 messages Jan 4 – Jan 5

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: greybus: replace WD_STATE_COLDBOOT_TRIG with state

use state temporary variable to replace WD_STATE_COLDBOOT_TRIG argument in arche_platform_set_wake_detect_state. This keeps lines under 80 columns and satisfies kernel style guidelines.

---
 drivers/staging/greybus/arche-platform.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/greybus/arche-platform.c +3 -2
index 8aaff4e45660..bb9b3c3c7a2d 100644
@@ -155,6 +155,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
 {
 	struct arche_platform_drvdata *arche_pdata = devid;
 	unsigned long flags;
+	int state;
 
 	spin_lock_irqsave(&arche_pdata->wake_lock, flags);
 
@@ -179,8 +180,8 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
 				 */
 				if (arche_pdata->wake_detect_state !=
 						WD_STATE_COLDBOOT_START) {
-					arche_platform_set_wake_detect_state(arche_pdata,
-									     WD_STATE_COLDBOOT_TRIG);
+					state = WD_STATE_COLDBOOT_TRIG;
+					arche_platform_set_wake_detect_state(arche_pdata, state);
 					spin_unlock_irqrestore(&arche_pdata->wake_lock,
 							       flags);
 					return IRQ_WAKE_THREAD;
Signature · 1 line
2.34.1
#1 lore raw
Quoted 22 lines · Gideon Adjei

use state temporary variable to replace WD_STATE_COLDBOOT_TRIG argument in arche_platform_set_wake_detect_state. This keeps lines under 80 columns and satisfies kernel style guidelines.

---
 drivers/staging/greybus/arche-platform.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/greybus/arche-platform.c +1 -0
index 8aaff4e45660..bb9b3c3c7a2d 100644
@@ -155,6 +155,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
 {
 	struct arche_platform_drvdata *arche_pdata = devid;
 	unsigned long flags;
+	int state;
 
 	spin_lock_irqsave(&arche_pdata->wake_lock, flags);
 

drivers/staging/greybus/arche-platform.c static irqreturn_t arche_platform_wd_irq(int irq, void *devid) · line 184

Quoted 7 lines
drivers/staging/greybus/arche-platform.c +2 -2
@@ -179,8 +180,8 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
 				 */
 				if (arche_pdata->wake_detect_state !=
 						WD_STATE_COLDBOOT_START) {
-					arche_platform_set_wake_detect_state(arche_pdata,
-									     WD_STATE_COLDBOOT_TRIG);
+					state = WD_STATE_COLDBOOT_TRIG;
+					arche_platform_set_wake_detect_state(arche_pdata, state);

No, sorry, the original code here is just fine, don't do things like this just to make checkpatch "quiet".

thanks,

greg k-h