Skip to contentSkip to conversation

arm64: dts: rockchip: Fix wrong register range of rk3576 gpu

PATCH Applied Chaoyi Chen 2 participants 2 messages Jan 6

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: dts: rockchip: Fix wrong register range of rk3576 gpu

From: Chaoyi Chen <[email protected]>

According to RK3576 TRM part1 Table 1-1 Address Mapping, the size of the GPU registers is 128 KB.

The current mapping incorrectly includes the addresses of multiple following IP like the eInk interface at 0x27900000. This has not been detected by the DT tooling as none of the extra mapped IP is described in the upstream RK3576 DT so far.

Fixes 57b1ce903966 ("arm64: dts: rockchip: Add rk3576 SoC base DT")

---

Changes in v2:
- Add more accurate problem description comment.
- Link to v1: https://lore.kernel.org/all/[email protected]/

 arch/arm64/boot/dts/rockchip/rk3576.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3576.dtsi +1 -1
index 6284e7bdc442..b375015f0662 100644
@@ -1271,7 +1271,7 @@ power-domain@RK3576_PD_VO1 {
 
 		gpu: gpu@27800000 {
 			compatible = "rockchip,rk3576-mali", "arm,mali-bifrost";
-			reg = <0x0 0x27800000 0x0 0x200000>;
+			reg = <0x0 0x27800000 0x0 0x20000>;
 			assigned-clocks = <&scmi_clk SCMI_CLK_GPU>;
 			assigned-clock-rates = <198000000>;
 			clocks = <&cru CLK_GPU>;
Signature · 1 line
2.51.1
maintainer Applied
#1 lore raw
Quoted 9 lines · Chaoyi Chen

According to RK3576 TRM part1 Table 1-1 Address Mapping, the size of the GPU registers is 128 KB.

The current mapping incorrectly includes the addresses of multiple following IP like the eInk interface at 0x27900000. This has not been detected by the DT tooling as none of the extra mapped IP is described in the upstream RK3576 DT so far.

[...]

Applied, thanks!

[1/1] arm64: dts: rockchip: Fix wrong register range of rk3576 gpu

      commit: 955b263c421c6fe5075369c52199f278289ec8c4

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>