Revert "gpio: swnode: don't use the swnode's name as the key for GPIO lookup"
Subsystems (2)
PATCH v2 1/1 Revert "gpio: swnode: don't use the swnode's name as the key for GPIO lookup"
This reverts commit e5d527be7e6984882306b49c067f1fec18920735.
This software node change doesn't actually fix any current issues with the kernel, it is an improvement to the lookup process rather than fixing a live bug. It also causes a couple of regressions with shipping laptops, which relied on the label based lookup.
There is a fix for the regressions in mainline, the first 5 patches of [1]. However, those patches are fairly substantial changes and given the patch causing the regression doesn't actually fix a bug it seems better to just revert it in stable.
CC [email protected] # 6.18
Signed-off-by Charles Keepax <[email protected]>
---
Changes since v1:
- Corrected commit ID to match 6.18
drivers/gpio/gpiolib-swnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpiolib-swnode.c +1 -1
@@ -41,7 +41,7 @@ static struct gpio_device *swnode_get_gpio_device(struct fwnode_handle *fwnode) !strcmp(gdev_node->name, GPIOLIB_SWNODE_UNDEFINED_NAME))return ERR_PTR (-ENOENT ); - gdev =gpio_device_find_by_fwnode (fwnode); + gdev =gpio_device_find_by_label (gdev_node->name);return gdev ?:ERR_PTR (-EPROBE_DEFER ); }
Signature · 1 line
2.47.3