Skip to contentSkip to conversation

sunrpc: rpc_debug and others are defined even if CONFIG_SUNRPC_DEBUG unset

PATCH New Ben Dooks 1 participant 1 message Jan 6

Subsystems (2)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 sunrpc: rpc_debug and others are defined even if CONFIG_SUNRPC_DEBUG unset

The rpc_debug, nfs_debug, nfsd_debug and nlm_debug are exported even if CONFIG_SUNRPC_DEBUG is not set. This means that the debug header should also define these to remove the following sparse warnings:

net/sunrpc/sysctl.c:29:17: warning: symbol 'rpc_debug' was not declared. Should it be static? net/sunrpc/sysctl.c:32:17: warning: symbol 'nfs_debug' was not declared. Should it be static? net/sunrpc/sysctl.c:35:17: warning: symbol 'nfsd_debug' was not declared. Should it be static? net/sunrpc/sysctl.c:38:17: warning: symbol 'nlm_debug' was not declared. Should it be static?

---
 include/linux/sunrpc/debug.h | 2 --
 1 file changed, 2 deletions(-)
include/linux/sunrpc/debug.h +0 -2
index 891f6173c951..eb4bd62df319 100644
@@ -14,12 +14,10 @@
 /*
  * Debugging macros etc
  */
-#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)
 extern unsigned int		rpc_debug;
 extern unsigned int		nfs_debug;
 extern unsigned int		nfsd_debug;
 extern unsigned int		nlm_debug;
-#endif
 
 #define dprintk(fmt, ...)						\
 	dfprintk(FACILITY, fmt, ##__VA_ARGS__)
Signature · 1 line
2.37.2.352.g3c44437643