Skip to contentSkip to conversation

atp: drop ancient parallel port Ethernet driver

RFC PATCH In review Ethan Nelson-Moore 2 participants 4 messages Jan 7

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 atp: drop ancient parallel port Ethernet driver

This driver is old and almost certainly entirely unused. The two other parallel port Ethernet drivers (de600/de620) were removed by Paul Gortmaker in commit 168e06ae26dd327df347e70b7244218ff1766a1f, but this driver remained. Drop it - Paul's reasoning applies here as well. To quote him:

"The parallel port is largely replaced by USB [...] Let us not pretend that anyone cares about these drivers anymore, or worse - pretend that anyone is using them on a modern kernel."

---
 drivers/net/ethernet/realtek/Kconfig  |  16 +-
 drivers/net/ethernet/realtek/Makefile |   1 -
 drivers/net/ethernet/realtek/atp.c    | 886 --------------------------
 drivers/net/ethernet/realtek/atp.h    | 262 --------
 4 files changed, 1 insertion(+), 1164 deletions(-)
 delete mode 100644 drivers/net/ethernet/realtek/atp.c
 delete mode 100644 drivers/net/ethernet/realtek/atp.h
drivers/net/ethernet/realtek/Kconfig +1 -15
index 272c83bfdc6c..9b0f4f9631db 100644
@@ -6,7 +6,7 @@
 config NET_VENDOR_REALTEK
 	bool "Realtek devices"
 	default y
-	depends on PCI || (PARPORT && X86)
+	depends on PCI
 	help
 	  If you have a network (Ethernet) card belonging to this class, say Y.
 
@@ -17,20 +17,6 @@ config NET_VENDOR_REALTEK
 
 if NET_VENDOR_REALTEK
 
-config ATP
-	tristate "AT-LAN-TEC/RealTek pocket adapter support"
-	depends on PARPORT && X86
-	select CRC32
-	help
-	  This is a network (Ethernet) device which attaches to your parallel
-	  port. Read the file <file:drivers/net/ethernet/realtek/atp.c>
-	  if you want to use this.  If you intend to use this driver, you
-	  should have said N to the "Parallel printer support", because the two
-	  drivers don't like each other.
-
-	  To compile this driver as a module, choose M here: the module
-	  will be called atp.
-
 config 8139CP
 	tristate "RealTek RTL-8139 C+ PCI Fast Ethernet Adapter support"
 	depends on PCI
drivers/net/ethernet/realtek/Makefile +0 -1
index 046adf503ff4..12a9c399f40c 100644
@@ -5,7 +5,6 @@
 
 obj-$(CONFIG_8139CP) += 8139cp.o
 obj-$(CONFIG_8139TOO) += 8139too.o
-obj-$(CONFIG_ATP) += atp.o
 r8169-y += r8169_main.o r8169_firmware.o r8169_phy_config.o
 r8169-$(CONFIG_R8169_LEDS) += r8169_leds.o
 obj-$(CONFIG_R8169) += r8169.o
drivers/net/ethernet/realtek/atp.c deleted +0 -886

886 lines not on this page · raw message

drivers/net/ethernet/realtek/atp.h deleted +0 -262

262 lines not on this page · raw message

Signature · 1 line
2.43.0
#1 lore raw
Quoted 5 lines · Ethan Nelson-Moore

This driver is old and almost certainly entirely unused. The two other parallel port Ethernet drivers (de600/de620) were removed by Paul Gortmaker in commit 168e06ae26dd327df347e70b7244218ff1766a1f, but this driver remained. Drop it - Paul's reasoning applies here as well. To quote him:

Hi Ethan

Please slow down. Get one patch correctly merged to learn the processes. Then move onto the next. All you submissions are broken, so you are just wasting everybody's time.

Andrew

#2 lore raw
Quoted 3 lines · Andrew Lunn

Please slow down. Get one patch correctly merged to learn the processes. Then move onto the next. All you submissions are broken, so you are just wasting everybody's time.

Hi, Andrew,

Sorry about that. Next time I will run get-maintainer and make cover letters for my patch series.
Is there anything broken about the content/commit messages of my patches, or just the way in which I sent them?
What should my next steps be regarding these patches? Resending them with the CCs added would just create noise on the mailing list. Should I directly forward them to maintainers?

Ethan

#3 lore raw
Quoted 11 lines · Ethan Nelson-Moore
Quoted 3 lines · Andrew Lunn

Please slow down. Get one patch correctly merged to learn the processes. Then move onto the next. All you submissions are broken, so you are just wasting everybody's time.

Hi, Andrew,

Sorry about that. Next time I will run get-maintainer and make cover letters for my patch series.
Is there anything broken about the content/commit messages of my patches, or just the way in which I sent them?

Please take a look at:

https://docs.kernel.org/process/submitting-patches.html
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

Quoted 1 line

What should my next steps be regarding these patches?

Work on just one patch. Worth through those two documents, fixup what you got wrong and submit that one patch.

'b4 prep' is a good tool to use for handling patches.

Andrew