can: mcp251xfd: fix UAF from workqueue double-destroy
Subsystems (2)
PATCH 1/1 can: mcp251xfd: fix UAF from workqueue double-destroy
mcp251xfd_open() allocates priv->wq after the controller is started. If request_threaded_irq() or mcp251xfd_chip_interrupts_enable() fails, the error path destroys the workqueue but leaves priv->wq unchanged.
This leaves a dangling non-NULL pointer that can later be destroyed again, for example:
- a retry to open the device fails before priv->wq is reallocated and a later close/remove cleanup destroys the stale pointer; or
- reset/recovery paths end up calling mcp251xfd_stop() after the failed open and destroy priv->wq again.
Clear priv->wq after destroy_workqueue() to make teardown idempotent and avoid double-destroy/use-after-free crashes.
This is the same bug class as CVE-2024-26802 (stmmac workqueue teardown).
--- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c +2 -0
@@ -1661,6 +1661,8 @@ static int mcp251xfd_open(struct net_device *ndev)free_irq (spi->irq, priv); out_destroy_workqueue:destroy_workqueue (priv->wq); +if (priv->wq) + priv->wq =NULL ; out_can_rx_offload_disable:can_rx_offload_disable (&priv->offload);set_bit (MCP251XFD_FLAGS_DOWN , priv->flags);
Signature · 1 line
2.34.1
Marc Kleine-Budde
maintainerQuoted 8 lines · Kery Qi
mcp251xfd_open()allocatespriv->wqafter the controller is started. Ifrequest_threaded_irq()ormcp251xfd_chip_interrupts_enable()fails, the error path destroys the workqueue but leavespriv->wqunchanged.This leaves a dangling non-NULL pointer that can later be destroyed again, for example:
- a retry to open the device fails beforepriv->wqis reallocated and a later close/remove cleanup destroys the stale pointer; or
Can you point me to the exact code path.
Quoted 2 lines
- reset/recovery paths end up calling
mcp251xfd_stop()after the failed open and destroypriv->wqagain.
mcp251xfd_stop() is only called from net_device_ops:
| static const struct net_device_ops mcp251xfd_netdev_ops = {
| .ndo_stop = mcp251xfd_stop,
| }Is this ndo_stop is called if ndo_open failed?
Quoted 4 lines
Clear
priv->wqafterdestroy_workqueue()to make teardown idempotent and avoid double-destroy/use-after-free crashes.This is the same bug class as CVE-2024-26802 (stmmac workqueue teardown).
regards,
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |