Skip to contentSkip to conversation

ASoC: dt-bindings: realtek,rt5640: Add missing properties/node

PATCH In review Rob Herring (Arm) 2 participants 3 messages Jan 8 – Jan 12

Subsystems (3)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/2 ASoC: dt-bindings: realtek,rt5640: Add missing properties/node

The RT5640 has an MCLK pin and several users already define a clocks entry. A 'port' node is also in use and a common node for codecs.

---
 .../devicetree/bindings/sound/realtek,rt5640.yaml        | 9 +++++++++
 1 file changed, 9 insertions(+)
Documentation/devicetree/bindings/sound/realtek,rt5640.yaml +9 -0
index 3f4f59287c1c..a0b8bf6cb110 100644
@@ -47,6 +47,12 @@ properties:
   reg:
     maxItems: 1
 
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: mclk
+
   interrupts:
     maxItems: 1
     description: The CODEC's interrupt output.
@@ -121,6 +127,9 @@ properties:
       - 2 # Scale current by 1.0
       - 3 # Scale current by 1.5
 
+  port:
+    $ref: /schemas/graph.yaml#/properties/port
+
 required:
   - compatible
   - reg
Signature · 1 line
2.51.0
author maintainer
#1 lore raw

PATCH 2/2 ASoC: dt-bindings: realtek,rt5640: Allow 7 for realtek,jack-detect-source

The driver accepts and uses a value of 7 for realtek,jack-detect-source. What exactly it means isn't clear though.

---
 Documentation/devicetree/bindings/sound/realtek,rt5640.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/sound/realtek,rt5640.yaml +1 -0
index a0b8bf6cb110..cd95d7189d34 100644
@@ -104,6 +104,7 @@ properties:
       - 4 # Use GPIO2 for jack-detect
       - 5 # Use GPIO3 for jack-detect
       - 6 # Use GPIO4 for jack-detect
+      - 7 # HDA?
 
   realtek,jack-detect-not-inverted:
     description:
Signature · 1 line
2.51.0
maintainer
#2 lore raw
In reply to Rob Herring (Arm)
Quoted 4 lines · Rob Herring (Arm)

The RT5640 has an MCLK pin and several users already define a clocks entry. A 'port' node is also in use and a common node for codecs.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: dt-bindings: realtek,rt5640: Add missing properties/node

      commit: 101b982654ac0305ab286b54d46de79b5b982f3a
[2/2] ASoC: dt-bindings: realtek,rt5640: Allow 7 for realtek,jack-detect-source
      commit: f66e7da2a6b1ba055d47d7c97c9c855729f868ed

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark