PCI: Disable bus reset for ASM1164 SATA controller
PATCH 1/1 PCI: Disable bus reset for ASM1164 SATA controller
User forums report issues when assigning ASM1164 SATA controllers to VMs, especially in configurations with multiple controllers. Logs show the device fails to retrain after bus reset. Reports suggest this is an issue across multiple platforms. The device indicates support for PM reset, therefore the device still has a viable function level reset mechanism. The reporting user confirms the device is well behaved in this use case with bus reset disabled.
--- drivers/pci/quirks.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/pci/quirks.c +10 -0
@@ -3791,6 +3791,16 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_CAVIUM, 0xa100, quirk_no_bus_reset);*/ DECLARE_PCI_FIXUP_HEADER (PCI_VENDOR_ID_TI ,0xb005 , quirk_no_bus_reset); +/* +* Reports from users making use of PCI device assignment with ASM1164 +* controllers indicate an issue with bus reset where the device fails to +* retrain. The issue appears more common in configurations with multiple +* controllers. The device does indicate PM reset support (NoSoftRst-), +* therefore this still leaves a viable reset method. +* https://forum.proxmox.com/threads/problems-with-pcie-passthrough-with-two-identical-devices.149003/ +*/ +DECLARE_PCI_FIXUP_HEADER (PCI_VENDOR_ID_ASMEDIA ,0x1164 , quirk_no_bus_reset); +static void quirk_no_pm_reset (struct pci_dev *dev) {/*
Signature · 1 line
2.51.0
Bjorn Helgaas
AppliedQuoted 11 lines · Alex Williamson
User forums report issues when assigning ASM1164 SATA controllers to VMs, especially in configurations with multiple controllers. Logs show the device fails to retrain after bus reset. Reports suggest this is an issue across multiple platforms. The device indicates support for PM reset, therefore the device still has a viable function level reset mechanism. The reporting user confirms the device is well behaved in this use case with bus reset disabled.
Applied to pci/virtualization for v6.20, thanks!
Quoted 28 lines
--- drivers/pci/quirks.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/pci/quirks.c +10
-0@@ -3791,6 +3791,16 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_CAVIUM, 0xa100, quirk_no_bus_reset);*/ DECLARE_PCI_FIXUP_HEADER (PCI_VENDOR_ID_TI ,0xb005 , quirk_no_bus_reset); +/* +* Reports from users making use of PCI device assignment with ASM1164 +* controllers indicate an issue with bus reset where the device fails to +* retrain. The issue appears more common in configurations with multiple +* controllers. The device does indicate PM reset support (NoSoftRst-), +* therefore this still leaves a viable reset method. +* https://forum.proxmox.com/threads/problems-with-pcie-passthrough-with-two-identical-devices.149003/ +*/ +DECLARE_PCI_FIXUP_HEADER (PCI_VENDOR_ID_ASMEDIA ,0x1164 , quirk_no_bus_reset); +static void quirk_no_pm_reset (struct pci_dev *dev) {/* Signature · 1 line
2.51.0