Skip to contentSkip to conversation

tracing: Remove redundant call to event_trigger_reset_filter() in event_hist_trigger_parse()

PATCH In review Steven Rostedt 2 participants 2 messages Jan 8 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tracing: Remove redundant call to event_trigger_reset_filter() in event_hist_trigger_parse()

From: Steven Rostedt <[email protected]>

With the change to replace kfree() with trigger_data_free(), which starts out doing the exact same thing as event_trigger_reset_filter(), there's no reason to call event_trigger_reset_filter() before calling trigger_data_free(). Remove the call to it.

---
 kernel/trace/trace_events_hist.c | 2 --
 1 file changed, 2 deletions(-)
kernel/trace/trace_events_hist.c +0 -2
index f9886fff7123..4a7f945e368d 100644
@@ -6898,8 +6898,6 @@ static int event_hist_trigger_parse(struct event_command *cmd_ops,
  out_unreg:
 	event_trigger_unregister(cmd_ops, file, glob+1, trigger_data);
  out_free:
-	event_trigger_reset_filter(cmd_ops, trigger_data);
-
 	remove_hist_vars(hist_data);
 
 	trigger_data_free(trigger_data);
Signature · 1 line
2.51.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Thu, 8 Jan 2026 17:44:29 -0500 Steven Rostedt <[email protected]> wrote:

From: Steven Rostedt <[email protected]>

With the change to replace kfree() with trigger_data_free(), which starts out doing the exact same thing as event_trigger_reset_filter(), there's no reason to call event_trigger_reset_filter() before calling trigger_data_free(). Remove the call to it.

Looks good to me.

Thanks,

Quoted 21 lines
---
 kernel/trace/trace_events_hist.c | 2 --
 1 file changed, 2 deletions(-)
kernel/trace/trace_events_hist.c +0 -2
index f9886fff7123..4a7f945e368d 100644
@@ -6898,8 +6898,6 @@ static int event_hist_trigger_parse(struct event_command *cmd_ops,
  out_unreg:
 	event_trigger_unregister(cmd_ops, file, glob+1, trigger_data);
  out_free:
-	event_trigger_reset_filter(cmd_ops, trigger_data);
-
 	remove_hist_vars(hist_data);
 
 	trigger_data_free(trigger_data);
Signature · 1 line
2.51.0
Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>