HID: magicmouse: Do not crash on missing msc->input
Subsystems (2)
PATCH 1/1 HID: magicmouse: Do not crash on missing msc->input
Fake USB devices can send their own report descriptors for which the input_mapping() hook does not get called. In this case, msc->input stays NULL, leading to a crash at a later time.
Detect this condition in the input_configured() hook and reject the device.
This is not supposed to happen with actual magic mouse devices, but can be provoked by imposing as a magic mouse USB device.
--- drivers/hid/hid-magicmouse.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/hid/hid-magicmouse.c +5 -0
@@ -726,6 +726,11 @@ static int magicmouse_input_configured(struct hid_device *hdev,struct magicmouse_sc *msc =hid_get_drvdata (hdev);int ret; +if (!msc->input) { +hid_err (hdev,"magicmouse setup input failed (no input)" ); +return -EINVAL ; + } + ret =magicmouse_setup_input (msc->input, hdev);if (ret) {hid_err (hdev,"magicmouse setup input failed (%d)\n" , ret);
Signature · 1 line
2.52.0.457.g6b5491de43-goog
Quoted 9 lines · Günther Noack
Fake USB devices can send their own report descriptors for which the
input_mapping()hook does not get called. In this case,msc->inputstays N= ULL,
leading to a crash at a later time.Detect this condition in the
input_configured()hook and reject the device.This is not supposed to happen with actual magic mouse devices, but can be provoked by imposing as a magic mouse USB device.
Applied to hid.git#for-6.19/upstream-fixes, thanks Guenther.
Signature · 2 lines
Jiri Kosina SUSE Labs