Skip to contentSkip to conversation

perf/core: make nr_addr_filters attribute static

PATCH In review Ben Dooks 2 participants 2 messages Jan 9 – Jan 12 perf events

lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 perf/core: make nr_addr_filters attribute static

The 'dev_attr_nr_addr_filters' attribute is not exported outside of the kernel/events/core.c file so make it static to avoid the following sparse warning:

kernel/events/core.c:12170:1: warning: symbol 'dev_attr_nr_addr_filters' was not declared. Should it be static?

Fixes 6e855cd4f4b52 ("perf/core: Let userspace know if the PMU supports address filters")
---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/events/core.c +1 -1
index dad0d3d2e85f..b79f9be8f074 100644
@@ -12167,7 +12167,7 @@ static ssize_t nr_addr_filters_show(struct device *dev,
 
 	return sysfs_emit(page, "%d\n", pmu->nr_addr_filters);
 }
-DEVICE_ATTR_RO(nr_addr_filters);
+static DEVICE_ATTR_RO(nr_addr_filters);
 
 static struct idr pmu_idr;
 
Signature · 1 line
2.37.2.352.g3c44437643
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Ben Dooks

The 'dev_attr_nr_addr_filters' attribute is not exported outside of the kernel/events/core.c file so make it static to avoid the following sparse warning:

kernel/events/core.c:12170:1: warning: symbol 'dev_attr_nr_addr_filters' was not declared. Should it be static?

Fixes 6e855cd4f4b52 ("perf/core: Let userspace know if the PMU supports address filters")
---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/events/core.c +0 -0
index dad0d3d2e85f..b79f9be8f074 100644

kernel/events/core.c static ssize_t nr_addr_filters_show(struct device *dev, · line 12173

Quoted 8 lines
kernel/events/core.c +1 -1
@@ -12167,7 +12167,7 @@ static ssize_t nr_addr_filters_show(struct device *dev,
 
 	return sysfs_emit(page, "%d\n", pmu->nr_addr_filters);
 }
-DEVICE_ATTR_RO(nr_addr_filters);
+static DEVICE_ATTR_RO(nr_addr_filters);
 
 static struct idr pmu_idr;