Skip to contentSkip to conversation

pinctrl: mediatek: remove unused drv_offset field

PATCH In review Akari Tsuyukusa 2 participants 3 messages Jan 11 – Feb 4

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: mediatek: remove unused drv_offset field

The 'drv_offset' member in 'struct mtk_pinctrl_devdata' has been unused since the driver's inception. Drive strength control for MediaTek pinctrl drivers is actually configured via 'pin_drv_grp', making this specific offset field redundant.

Remove the unused field from the common 'mtk_pinctrl_devdata' structure and its corresponding initialization in the mt8365 driver to clean up the code and avoid confusion.

---
 drivers/pinctrl/mediatek/pinctrl-mt8365.c     | 1 -
 drivers/pinctrl/mediatek/pinctrl-mtk-common.h | 1 -
 2 files changed, 2 deletions(-)
drivers/pinctrl/mediatek/pinctrl-mt8365.c +0 -1
index e3e0d66cfbbf..c20b9e2e02dd 100644
@@ -456,7 +456,6 @@ static const struct mtk_pinctrl_devdata mt8365_pinctrl_data = {
 	.smt_offset = 0x0470,
 	.pullen_offset = 0x0860,
 	.pullsel_offset = 0x0900,
-	.drv_offset = 0x0710,
 	.type1_start = 145,
 	.type1_end = 145,
 	.port_shf = 4,
drivers/pinctrl/mediatek/pinctrl-mtk-common.h +0 -1
index 11afa12a96cb..3b96f3dd338d 100644
@@ -263,7 +263,6 @@ struct mtk_pinctrl_devdata {
 	unsigned int smt_offset;
 	unsigned int pullen_offset;
 	unsigned int pullsel_offset;
-	unsigned int drv_offset;
 	unsigned int dout_offset;
 	unsigned int din_offset;
 	unsigned int pinmux_offset;
Signature · 1 line
2.52.0
maintainer
#1 lore raw
Quoted 10 lines · Akari Tsuyukusa

The 'drv_offset' member in 'struct mtk_pinctrl_devdata' has been unused since the driver's inception. Drive strength control for MediaTek pinctrl drivers is actually configured via 'pin_drv_grp', making this specific offset field redundant.

Remove the unused field from the common 'mtk_pinctrl_devdata' structure and its corresponding initialization in the mt8365 driver to clean up the code and avoid confusion.

No word from maintainers so patch applied.

Yours,
Linus Walleij

#2 lore raw

Hi Linus,

Thank you for picking this up and applying it!

Best regards,
Akari Tsuyukusa

Quoted 18 lines · Linus Walleij
Quoted 10 lines · Akari Tsuyukusa

The 'drv_offset' member in 'struct mtk_pinctrl_devdata' has been unused since the driver's inception. Drive strength control for MediaTek pinctrl drivers is actually configured via 'pin_drv_grp', making this specific offset field redundant.

Remove the unused field from the common 'mtk_pinctrl_devdata' structure and its corresponding initialization in the mt8365 driver to clean up the code and avoid confusion.

No word from maintainers so patch applied.

Yours,
Linus Walleij