i2c: cadence: fix reference leak when pm_runtime_get_sync fails The PM reference count is not expected to be incremented on return in functions starfive_wdt_probe.
Subsystems (2)
PATCH 1/1 i2c: cadence: fix reference leak when pm_runtime_get_sync fails The PM reference count is not expected to be incremented on return in functions starfive_wdt_probe.
However, pm_runtime_get_sync will increment pm usage counter even failed. Forgetting to putting operation will result in a reference leak here.
Replace it with pm_runtime_resume_and_get to keep usage counter balanced.
Fixes db728ea9c7be ("drivers: watchdog: Add StarFive Watchdog driver")
Signed-off-by Kery Qi <[email protected]>
--- drivers/watchdog/starfive-wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/starfive-wdt.c +1 -1
@@ -446,7 +446,7 @@ static int starfive_wdt_probe(struct platform_device *pdev)platform_set_drvdata (pdev, wdt);pm_runtime_enable (&pdev->dev);if (pm_runtime_enabled (&pdev->dev)) { - ret =pm_runtime_get_sync (&pdev->dev); + ret =pm_runtime_resume_and_get (&pdev->dev);if (ret <0 )return ret; }else {
Signature · 1 line
2.34.1