dma: ti: edma: Fix PM reference leak on probe failure
Subsystems (2)
PATCH 1/1 dma: ti: edma: Fix PM reference leak on probe failure
The PM reference count is not expected to be incremented on return in functions edma_probe.
However, pm_runtime_get_sync will increment pm usage counter even failed. Forgetting to putting operation will result in a reference leak here.
Replace it with pm_runtime_resume_and_get to keep usage counter balanced, since the failure path returns without a matching pm_runtime_put_noidle().
Fixes 2a03c1314506 ("dmaengine: ti: edma: add missed operations")
Signed-off-by Kery Qi <[email protected]>
--- drivers/dma/ti/edma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/dma/ti/edma.c +2 -2
@@ -2345,9 +2345,9 @@ static int edma_probe(struct platform_device *pdev)platform_set_drvdata (pdev, ecc);pm_runtime_enable (dev); - ret =pm_runtime_get_sync (dev); + ret =pm_runtime_resume_and_get (dev);if (ret <0 ) { -dev_err (dev,"pm_runtime_get_sync() failed\n" ); +dev_err (dev,"pm_runtime_resume_and_get() failed\n" );pm_runtime_disable (dev);return ret; }
Signature · 1 line
2.34.1