Skip to contentSkip to conversation

net: qualcomm: ppe: Remove redundant include of dev_printk.h

PATCH In review Jinseok Kim 2 participants 3 messages Jan 12 – Jan 15

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: qualcomm: ppe: Remove redundant include of dev_printk.h

The header <linux/device.h> already includes <linux/dev_printk.h>. Therefore, explicitly including <linux/dev_printk.h> is unnecessary.

This patch removes the redundant include. No functional changes.

---
 drivers/net/ethernet/qualcomm/ppe/ppe_debugfs.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/ethernet/qualcomm/ppe/ppe_debugfs.c +0 -1
index fd959a76ff43..df9f0cdad626 100644
@@ -7,7 +7,6 @@
 
 #include <linux/bitfield.h>
 #include <linux/debugfs.h>
-#include <linux/dev_printk.h>
 #include <linux/device.h>
 #include <linux/regmap.h>
 #include <linux/seq_file.h>

--
2.43.0

maintainer
#1 lore raw
Quoted 4 lines · On Sun, 11 Jan 2026 20:20:38 -0800 Jinseok Kim wrote:

The header <linux/device.h> already includes <linux/dev_printk.h>. Therefore, explicitly including <linux/dev_printk.h> is unnecessary.

This patch removes the redundant include. No functional changes.

Unless there's some effort to remove the dev_printk.h header let's leave it as is. Depending on header dependencies is not generally recommended.

Signature · 1 line
pw-bot: cr
#2 lore raw

Thanks for the review!

I suggested removing the direct #include <linux/dev_printk.h> because this is the only file under net/ethernet/qualcomm/ that explicitly includes it. All other files use dev_err() etc. just fine via <linux/device.h>.

But you're right — relying on indirect includes isn't ideal... I'll leave it as-is for now.