media: vivid: Simplify fb_vblank init in fb_blank
Subsystems (2)
PATCH 1/1 media: vivid: Simplify fb_vblank init in fb_blank
Adjust struct fb_vblank declaration scope and use aggregate init instead of memset for cleaner FBIOGET_VBLANK handling.
Signed-off-by jempty.liang <[email protected]>
--- drivers/media/test-drivers/vivid/vivid-osd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/media/test-drivers/vivid/vivid-osd.c +1 -3
@@ -73,12 +73,10 @@ void vivid_fb_clear(struct vivid_dev *dev)static int vivid_fb_ioctl (struct fb_info *info,unsigned cmd,unsigned long arg) {struct vivid_dev *dev = (struct vivid_dev *)info->par; +struct fb_vblank vblank = {};switch (cmd) {case FBIOGET_VBLANK : { -struct fb_vblank vblank; - -memset (&vblank,0 ,sizeof (vblank)); vblank.flags =FB_VBLANK_HAVE_COUNT |FB_VBLANK_HAVE_VCOUNT |FB_VBLANK_HAVE_VSYNC ; vblank.count =0 ;
Signature · 1 line
2.25.1
Quoted 13 lines · jempty.liang
Adjust struct
fb_vblankdeclaration scope and use aggregate init instead of memset for cleanerFBIOGET_VBLANKhandling.Signed-off-by jempty.liang <[email protected]>--- drivers/media/test-drivers/vivid/vivid-osd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/media/test-drivers/vivid/vivid-osd.c +0
-0
drivers/media/test-drivers/vivid/vivid-osd.c void vivid_fb_clear(struct vivid_dev *dev) · line 76
Quoted 4 lines
drivers/media/test-drivers/vivid/vivid-osd.c +1
-0@@ -73,12 +73,10 @@ void vivid_fb_clear(struct vivid_dev *dev)static int vivid_fb_ioctl (struct fb_info *info,unsigned cmd,unsigned long arg) {struct vivid_dev *dev = (struct vivid_dev *)info->par; +struct fb_vblank vblank = {};
Why move it out of the case?
drivers/media/test-drivers/vivid/vivid-osd.c void vivid_fb_clear(struct vivid_dev *dev) · line 79
Quoted 4 lines
drivers/media/test-drivers/vivid/vivid-osd.c +0
-1switch (cmd) {case FBIOGET_VBLANK : { -struct fb_vblank vblank;
just add '= {}' here and drop the memset.
drivers/media/test-drivers/vivid/vivid-osd.c void vivid_fb_clear(struct vivid_dev *dev) · line 82
Quoted 5 lines
drivers/media/test-drivers/vivid/vivid-osd.c +0
-2- -memset (&vblank,0 ,sizeof (vblank)); vblank.flags =FB_VBLANK_HAVE_COUNT |FB_VBLANK_HAVE_VCOUNT |FB_VBLANK_HAVE_VSYNC ; vblank.count =0 ;
Regards,
Hans